HBase
  1. HBase
  2. HBASE-6780

On the master status page the Number of Requests per second is incorrect for RegionServer's

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The number of requests per second is getting divided when it shouldn't be.

      1. HBASE-6780-0.patch
        0.7 kB
        Elliott Clark

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        stack added a comment -

        Right. It was brought on by the pb'ing.

        Show
        stack added a comment - Right. It was brought on by the pb'ing.
        Hide
        Lars Hofhansl added a comment -

        This is not an issue on 0.94, right?

        Show
        Lars Hofhansl added a comment - This is not an issue on 0.94, right?
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #173 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/173/)
        HBASE-6780 On the master status page the Number of Requests per second is incorrect for RegionServer's (Revision 1384648)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #173 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/173/ ) HBASE-6780 On the master status page the Number of Requests per second is incorrect for RegionServer's (Revision 1384648) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3330 (See https://builds.apache.org/job/HBase-TRUNK/3330/)
        HBASE-6780 On the master status page the Number of Requests per second is incorrect for RegionServer's (Revision 1384648)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3330 (See https://builds.apache.org/job/HBase-TRUNK/3330/ ) HBASE-6780 On the master status page the Number of Requests per second is incorrect for RegionServer's (Revision 1384648) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ServerLoad.java
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12545097/HBASE-6780-0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The patch appears to cause mvn compile goal to fail.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2865//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2865//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12545097/HBASE-6780-0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2865//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2865//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to trunk. Thanks Elliott.

        Show
        stack added a comment - Committed to trunk. Thanks Elliott.
        Hide
        Elliott Clark added a comment -

        Patch to remove the divide. The Protobuf that transfers NumberOfRequests gets the number from a rate, so there's no need to divide by metrics reporting period anymore.

        Show
        Elliott Clark added a comment - Patch to remove the divide. The Protobuf that transfers NumberOfRequests gets the number from a rate, so there's no need to divide by metrics reporting period anymore.
        Hide
        Elliott Clark added a comment -

        It's divided by the metrics reporting time (which seems like it should work assuming that the period is in seconds).

        Producing: http://imgur.com/nnoKC

        Show
        Elliott Clark added a comment - It's divided by the metrics reporting time (which seems like it should work assuming that the period is in seconds). Producing: http://imgur.com/nnoKC
        Hide
        Lars Hofhansl added a comment -

        What is it divided by?

        Show
        Lars Hofhansl added a comment - What is it divided by?

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Elliott Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development