Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6778

Deprecate Chore; its a thread per task when we should have one thread to do all tasks

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1.0, 2.0.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      Corresponding usages for new ScheduledChore vs. Deprecated Chore:
      Chore.interrupt() -> ScheduledChore.cancel(mayInterruptWhileRunning = true)
      Threads.setDaemonThreadRunning(Chore) -> ChoreService.scheduleChore(ScheduledChore)
      Chore.isAlive -> ScheduledChore.isScheduled()
      Chore.getSleeper().skipSleepCycle() -> ScheduledChore.triggerNow()
      Show
      Corresponding usages for new ScheduledChore vs. Deprecated Chore: Chore.interrupt() -> ScheduledChore.cancel(mayInterruptWhileRunning = true) Threads.setDaemonThreadRunning(Chore) -> ChoreService.scheduleChore(ScheduledChore) Chore.isAlive -> ScheduledChore.isScheduled() Chore.getSleeper().skipSleepCycle() -> ScheduledChore.triggerNow()

      Description

      Should use something like ScheduledThreadPoolExecutor instead (Elliott said this first I think; J-D said something similar just now).

        Attachments

        1. AFTER_thread_dump.txt
          170 kB
          Jonathan Lawlor
        2. BEFORE_thread_dump.txt
          174 kB
          Jonathan Lawlor
        3. HBASE_6778_v1.patch
          154 kB
          Jonathan Lawlor
        4. HBASE_6778_v2.patch
          159 kB
          Jonathan Lawlor
        5. HBASE_6778_v3.patch
          160 kB
          Michael Stack
        6. HBASE_6778_v3.patch
          160 kB
          Jonathan Lawlor
        7. HBASE_6778_v4.patch
          168 kB
          Jonathan Lawlor
        8. HBASE_6778_v5.patch
          168 kB
          Jonathan Lawlor
        9. HBASE_6778_v6.patch
          168 kB
          Jonathan Lawlor
        10. HBASE_6778_v6.patch
          168 kB
          Jonathan Lawlor
        11. HBASE_6778_WIP_v1.patch
          43 kB
          Jonathan Lawlor
        12. HBASE_6778_WIP_v2.patch
          140 kB
          Jonathan Lawlor
        13. HBASE-6778-branch-1-v1.patch
          169 kB
          Jonathan Lawlor
        14. thread_dump_HMaster.local.out
          170 kB
          Jonathan Lawlor

          Activity

            People

            • Assignee:
              jonathan.lawlor Jonathan Lawlor
              Reporter:
              stack Michael Stack
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: