HBase
  1. HBase
  2. HBASE-6743

Move EnvironmentEdge classes to hbase-common

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.

      1. 6743v1.txt
        6 kB
        Chris Trezzo
      2. 6743v2.txt
        12 kB
        Chris Trezzo
      3. 6743v3.txt
        13 kB
        stack

        Issue Links

          Activity

          Chris Trezzo created issue -
          Chris Trezzo made changes -
          Field Original Value New Value
          Link This issue is depended upon by HBASE-6476 [ HBASE-6476 ]
          Hide
          Chris Trezzo added a comment -

          Attached a first patch.

          Show
          Chris Trezzo added a comment - Attached a first patch.
          Chris Trezzo made changes -
          Attachment 6743v1.txt [ 12544267 ]
          Hide
          Chris Trezzo added a comment -

          Trying a HadoopQA run.

          Show
          Chris Trezzo added a comment - Trying a HadoopQA run.
          Chris Trezzo made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Chris Trezzo made changes -
          Fix Version/s 0.96.0 [ 12320040 ]
          Hide
          stack added a comment -

          Did you forget to svn add the classes back in hbase-common Chris? They are not in the patch?

          Show
          stack added a comment - Did you forget to svn add the classes back in hbase-common Chris? They are not in the patch?
          Hide
          Chris Trezzo added a comment -

          Yes. Woops. Moving files with svn can be a pain. Will fix. Thanks!

          Show
          Chris Trezzo added a comment - Yes. Woops. Moving files with svn can be a pain. Will fix. Thanks!
          Hide
          Chris Trezzo added a comment -

          Here is an updated patch using git.

          Show
          Chris Trezzo added a comment - Here is an updated patch using git.
          Chris Trezzo made changes -
          Attachment 6743v2.txt [ 12544328 ]
          Hide
          stack added a comment -

          Added the EnvironmentEdge tests and utils too.

          Show
          stack added a comment - Added the EnvironmentEdge tests and utils too.
          stack made changes -
          Attachment 6743v3.txt [ 12546960 ]
          Hide
          stack added a comment -

          Committed to trunk. Thanks for the patch Chris.

          Show
          stack added a comment - Committed to trunk. Thanks for the patch Chris.
          stack made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3388 (See https://builds.apache.org/job/HBase-TRUNK/3388/)
          HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3388 (See https://builds.apache.org/job/HBase-TRUNK/3388/ ) HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321) Result = SUCCESS stack : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #197 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/197/)
          HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
          • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
          • /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #197 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/197/ ) HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321) Result = FAILURE stack : Files : /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          stack made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4m 3s 1 Chris Trezzo 07/Sep/12 20:06
          Patch Available Patch Available Resolved Resolved
          20d 11h 7m 1 stack 28/Sep/12 07:13
          Resolved Resolved Closed Closed
          360d 12h 16m 1 stack 23/Sep/13 19:30

            People

            • Assignee:
              Chris Trezzo
              Reporter:
              Chris Trezzo
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development