[HBASE-6663] NPE race in HConnection if zookeeper is reset

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.94.1
• Fix Version/s: 0.94.2
• Component/s: Client
• Assignee: Gregory Chanan
• Reporter: Gregory Chanan
• Created: 25/Aug/12 01:08
• Updated: 24/Oct/12 05:40
• Resolved: 25/Aug/12 05:31

Description

On 0.94, HConnectionImplementation has code like this:

getZooKeeperWatcher();
String tableNameStr = Bytes.toString(tableName);
try {
  if (online) {
    return ZKTable.isEnabledTable(this.zooKeeper, tableNameStr);
  }
  return ZKTable.isDisabledTable(this.zooKeeper, tableNameStr);

The issue is that between the time that getZooKeeperWatcher is called and this.zooKeeper is used, this.zooKeeper can be set to null by another thread via resetZooKeeperTrackers.

The cleanest solution to me seems to be to cache the value. I have a patch that does this and a test that fails without the patch and passes with it.

This issue doesn't appear on 0.96 because the zookeeper code has been separated in HBASE-5399.