HBase
  1. HBase
  2. HBASE-6579

Unnecessary KV order check in StoreScanner

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.2
    • Component/s: None
    • Labels:
      None

      Description

      In StoreScanner.next(List<KeyValue>, int, String) I find this code:

            // Check that the heap gives us KVs in an increasing order.
            if (prevKV != null && comparator != null
                && comparator.compare(prevKV, kv) > 0) {
              throw new IOException("Key " + prevKV + " followed by a " +
                  "smaller key " + kv + " in cf " + store);
            }
            prevKV = kv;
      

      So this checks for bugs in the HFiles or the scanner code. It needs to compare each KVs with its predecessor. This seems unnecessary now, I propose that we remove this.

      1. 6579.txt
        1.0 kB
        Lars Hofhansl

        Activity

        Hide
        Todd Lipcon added a comment -

        Maybe change to an assert so that it still runs in the context of our test cases, but not in real clusters?

        Show
        Todd Lipcon added a comment - Maybe change to an assert so that it still runs in the context of our test cases, but not in real clusters?
        Hide
        Lars Hofhansl added a comment -

        I'll do that.

        Show
        Lars Hofhansl added a comment - I'll do that.
        Hide
        Lars Hofhansl added a comment -

        Replaces the check with an assert

        Show
        Lars Hofhansl added a comment - Replaces the check with an assert
        Hide
        Lars Hofhansl added a comment -

        This is a simple change, if there are no objections I'll commit this tomorrow to 0.94 and 0.96.

        Show
        Lars Hofhansl added a comment - This is a simple change, if there are no objections I'll commit this tomorrow to 0.94 and 0.96.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12540987/6579.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestAssignmentManager

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540987/6579.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestAssignmentManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2582//console This message is automatically generated.
        Hide
        binlijin added a comment -

        nice

        Show
        binlijin added a comment - nice
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 and 0.96.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 and 0.96.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3219 (See https://builds.apache.org/job/HBase-TRUNK/3219/)
        HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373537)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3219 (See https://builds.apache.org/job/HBase-TRUNK/3219/ ) HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373537) Result = SUCCESS larsh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #395 (See https://builds.apache.org/job/HBase-0.94/395/)
        HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #395 (See https://builds.apache.org/job/HBase-0.94/395/ ) HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #131 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/131/)
        HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373537)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #131 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/131/ ) HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373537) Result = FAILURE larsh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #48 (See https://builds.apache.org/job/HBase-0.94-security/48/)
        HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #48 (See https://builds.apache.org/job/HBase-0.94-security/48/ ) HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/)
        HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/ ) HBASE-6579 Unnecessary KV order check in StoreScanner (Revision 1373540) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
        Hide
        stack added a comment -

        Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

        Show
        stack added a comment - Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development