Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6579

Unnecessary KV order check in StoreScanner

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.2
    • Component/s: None
    • Labels:
      None

      Description

      In StoreScanner.next(List<KeyValue>, int, String) I find this code:

            // Check that the heap gives us KVs in an increasing order.
            if (prevKV != null && comparator != null
                && comparator.compare(prevKV, kv) > 0) {
              throw new IOException("Key " + prevKV + " followed by a " +
                  "smaller key " + kv + " in cf " + store);
            }
            prevKV = kv;
      

      So this checks for bugs in the HFiles or the scanner code. It needs to compare each KVs with its predecessor. This seems unnecessary now, I propose that we remove this.

        Attachments

        1. 6579.txt
          1.0 kB
          Lars Hofhansl

          Activity

            People

            • Assignee:
              lhofhansl Lars Hofhansl
              Reporter:
              lhofhansl Lars Hofhansl
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: