HBase
  1. HBase
  2. HBASE-6564

HDFS space is not reclaimed when a column family is deleted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.1
    • Fix Version/s: 0.95.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a column family of a table is deleted, the HDFS space of the column family does not seem to be reclaimed even after a major compaction.

      1. HBASE-6564-v5.patch
        12 kB
        J Mohamed Zahoor
      2. HBASE-6564-v4.patch
        12 kB
        J Mohamed Zahoor
      3. HBASE-6564-v3.patch
        12 kB
        J Mohamed Zahoor
      4. HBASE-6564-v2.patch
        15 kB
        J Mohamed Zahoor
      5. HBASE-6564-trunk.patch
        12 kB
        J Mohamed Zahoor

        Activity

        Hide
        J Mohamed Zahoor added a comment -

        Submitted a first patch for this on trunk

        Show
        J Mohamed Zahoor added a comment - Submitted a first patch for this on trunk
        Hide
        Ted Yu added a comment -
        +    fs.delete(delDir, true);
        

        Please check the return value from delete() call.

        TestTableFamilyHandlers.java misses license header.

        +   // TETS - Disable and delete the column family
        

        'TETS' seems to be misspelled above.
        Please add the following to the end of the new test:

          @org.junit.Rule
          public org.apache.hadoop.hbase.ResourceCheckerJUnitRule cu =
            new org.apache.hadoop.hbase.ResourceCheckerJUnitRule();
        

        Please try the patch on a cluster.

        Thanks

        Show
        Ted Yu added a comment - + fs.delete(delDir, true ); Please check the return value from delete() call. TestTableFamilyHandlers.java misses license header. + // TETS - Disable and delete the column family 'TETS' seems to be misspelled above. Please add the following to the end of the new test: @org.junit.Rule public org.apache.hadoop.hbase.ResourceCheckerJUnitRule cu = new org.apache.hadoop.hbase.ResourceCheckerJUnitRule(); Please try the patch on a cluster. Thanks
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541485/HBASE-6564-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541485/HBASE-6564-trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2614//console This message is automatically generated.
        Hide
        stack added a comment -

        Patch looks good except for what Ted said.

        Show
        stack added a comment - Patch looks good except for what Ted said.
        Hide
        J Mohamed Zahoor added a comment -

        Incorporated review comments. Thanks Ted and Stack.

        ./Zahoor

        Show
        J Mohamed Zahoor added a comment - Incorporated review comments. Thanks Ted and Stack. ./Zahoor
        Hide
        J Mohamed Zahoor added a comment -

        Changed the Patch file name to stick to convention.

        Show
        J Mohamed Zahoor added a comment - Changed the Patch file name to stick to convention.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541515/HBASE-6564-trunk-ver2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2618//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541515/HBASE-6564-trunk-ver2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2618//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541485/HBASE-6564-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.replication.TestReplication

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541485/HBASE-6564-trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2617//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12541520/HBASE-6564-v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2620//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541520/HBASE-6564-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2620//console This message is automatically generated.
        Hide
        J Mohamed Zahoor added a comment -

        Strange.. this patch applies to trunk in my setup and the "TestReplication" test also passes.

        Show
        J Mohamed Zahoor added a comment - Strange.. this patch applies to trunk in my setup and the "TestReplication" test also passes.
        Hide
        Ted Yu added a comment -

        @J:
        If you look at patch v2 closely, you can see that it is composed of two patch files (line 310).

        I suggest renaming TestTableFamilyHandlers.java -> TestTableDeleteFamilyHandler.java because only TableDeleteFamilyHandler is tested.
        There're a lot of two (successive) empty lines in this new file.
        Please remove redundant empty line.

         * Copyright 2009 The Apache Software Foundation
        

        The above line should be removed from license header.

           // 4 - Check if all the 3 column families exists in FS
        

        'exists' -> 'exist'

          public org.apache.hadoop.hbase.ResourceCheckerJUnitRule cu = new org.apache.hadoop.hbase.ResourceCheckerJUnitRule();
        

        The above line is longer than 100 characters. Please wrap.

        Please regenerate patch and attach to this JIRA.

        Thanks

        Show
        Ted Yu added a comment - @J: If you look at patch v2 closely, you can see that it is composed of two patch files (line 310). I suggest renaming TestTableFamilyHandlers.java -> TestTableDeleteFamilyHandler.java because only TableDeleteFamilyHandler is tested. There're a lot of two (successive) empty lines in this new file. Please remove redundant empty line. * Copyright 2009 The Apache Software Foundation The above line should be removed from license header. // 4 - Check if all the 3 column families exists in FS 'exists' -> 'exist' public org.apache.hadoop.hbase.ResourceCheckerJUnitRule cu = new org.apache.hadoop.hbase.ResourceCheckerJUnitRule(); The above line is longer than 100 characters. Please wrap. Please regenerate patch and attach to this JIRA. Thanks
        Hide
        Ted Yu added a comment -

        For MasterFileSystem.deleteFamily(), if fs.delete() returns false, I think we should raise IOException.

        Show
        Ted Yu added a comment - For MasterFileSystem.deleteFamily(), if fs.delete() returns false, I think we should raise IOException.
        Hide
        J Mohamed Zahoor added a comment -

        Thanks for the comments. I will incorporate it.
        But regarding the two patch situation.. will it not apply if you have two patches in a single patch?
        Anyway.. i will make it in to a single patch

        Show
        J Mohamed Zahoor added a comment - Thanks for the comments. I will incorporate it. But regarding the two patch situation.. will it not apply if you have two patches in a single patch? Anyway.. i will make it in to a single patch
        Hide
        J Mohamed Zahoor added a comment -

        Attached a V3 patch incorporating the above comments.

        Show
        J Mohamed Zahoor added a comment - Attached a V3 patch incorporating the above comments.
        Hide
        J Mohamed Zahoor added a comment -

        Corrected some spelling mistakes

        Show
        J Mohamed Zahoor added a comment - Corrected some spelling mistakes
        Hide
        Ted Yu added a comment -

        TestHRegion failed. See https://builds.apache.org/job/PreCommit-HBASE-Build/2669/console

        +  public void deleteFamily(HRegionInfo region, byte[] familyName)
        

        Please rename the above method deleteFamilyFromFS().

        +      if (fs.delete(delDir, true) == false) {
        +      throw new IOException("Could not delete family "
        

        Indent the throw statement to the right by two spaces.

        +          + Bytes.toString(familyName) + " from FileSystem for region "
        +          + region.getTableNameAsString());
        

        I think getTableNameAsString() shouldn't be used because you want to tell user the name of the region.
        For TestTableDeleteFamilyHandler.java:

        + * Copyright 2012 The Apache Software Foundation
        

        Year is not needed in license header.

        Show
        Ted Yu added a comment - TestHRegion failed. See https://builds.apache.org/job/PreCommit-HBASE-Build/2669/console + public void deleteFamily(HRegionInfo region, byte [] familyName) Please rename the above method deleteFamilyFromFS(). + if (fs.delete(delDir, true ) == false ) { + throw new IOException( "Could not delete family " Indent the throw statement to the right by two spaces. + + Bytes.toString(familyName) + " from FileSystem for region " + + region.getTableNameAsString()); I think getTableNameAsString() shouldn't be used because you want to tell user the name of the region. For TestTableDeleteFamilyHandler.java: + * Copyright 2012 The Apache Software Foundation Year is not needed in license header.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12542154/HBASE-6564-v4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient
        org.apache.hadoop.hbase.regionserver.TestHRegion
        org.apache.hadoop.hbase.replication.TestReplication
        org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542154/HBASE-6564-v4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient org.apache.hadoop.hbase.regionserver.TestHRegion org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2669//console This message is automatically generated.
        Hide
        J Mohamed Zahoor added a comment -

        Added review comments

        Show
        J Mohamed Zahoor added a comment - Added review comments
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12542790/HBASE-6564-v5.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 110 warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542790/HBASE-6564-v5.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. -1 javadoc. The javadoc tool appears to have generated 110 warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2721//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        I wonder what test hung in PreCommit build #2721.

        Show
        Ted Yu added a comment - I wonder what test hung in PreCommit build #2721.
        Hide
        J Mohamed Zahoor added a comment -

        I see this in the console output... I think it takes long time to execute the tests...
        Other than that i cant see any errors.

        [INFO] ------------------------------------------------------------------------
        [INFO] Reactor Summary:
        [INFO]
        [INFO] HBase ............................................. SUCCESS [1.868s]
        [INFO] HBase - Common .................................... SUCCESS [3.661s]
        [INFO] HBase - Hadoop Compatibility ...................... SUCCESS [1.158s]
        [INFO] HBase - Hadoop One Compatibility .................. SUCCESS [1.475s]
        [INFO] HBase - Server .................................... FAILURE [45:18.446s]
        [INFO] HBase - Hadoop Two Compatibility .................. SKIPPED
        [INFO] HBase - Integration Tests ......................... SKIPPED
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD FAILURE
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 45:27.023s
        [INFO] Finished at: Tue Aug 28 18:18:09 UTC 2012
        [INFO] Final Memory: 91M/614M
        [INFO] ------------------------------------------------------------------------
        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test (secondPartTestsExecution) on project hbase-server: Failure or timeout -> [Help 1]
        [ERROR]
        [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
        [ERROR] Re-run Maven using the -X switch to enable full debug logging.
        [ERROR]
        [ERROR] For more information about the errors and possible solutions, please read the following articles:
        [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
        [ERROR]
        [ERROR] After correcting the problems, you can resume the build with the command
        [ERROR] mvn <goals> -rf :hbase-server

        Show
        J Mohamed Zahoor added a comment - I see this in the console output... I think it takes long time to execute the tests... Other than that i cant see any errors. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] HBase ............................................. SUCCESS [1.868s] [INFO] HBase - Common .................................... SUCCESS [3.661s] [INFO] HBase - Hadoop Compatibility ...................... SUCCESS [1.158s] [INFO] HBase - Hadoop One Compatibility .................. SUCCESS [1.475s] [INFO] HBase - Server .................................... FAILURE [45:18.446s] [INFO] HBase - Hadoop Two Compatibility .................. SKIPPED [INFO] HBase - Integration Tests ......................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 45:27.023s [INFO] Finished at: Tue Aug 28 18:18:09 UTC 2012 [INFO] Final Memory: 91M/614M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK- HBASE-2 :test (secondPartTestsExecution) on project hbase-server: Failure or timeout -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hbase-server
        Hide
        Ted Yu added a comment -

        TestReplication wasn't in console output - not related to your patch.

        I will go over latest patch one more time and integrate if I don't see major issues.

        Show
        Ted Yu added a comment - TestReplication wasn't in console output - not related to your patch. I will go over latest patch one more time and integrate if I don't see major issues.
        Hide
        Ted Yu added a comment -

        Integrated to trunk.

        Thanks for the patch, J.

        Show
        Ted Yu added a comment - Integrated to trunk. Thanks for the patch, J.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3292 (See https://builds.apache.org/job/HBase-TRUNK/3292/)
        HBASE-6564 HDFS space is not reclaimed when a column family is deleted (J Mohamed) (Revision 1378648)

        Result = FAILURE
        Tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3292 (See https://builds.apache.org/job/HBase-TRUNK/3292/ ) HBASE-6564 HDFS space is not reclaimed when a column family is deleted (J Mohamed) (Revision 1378648) Result = FAILURE Tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #154 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/154/)
        HBASE-6564 HDFS space is not reclaimed when a column family is deleted (J Mohamed) (Revision 1378648)

        Result = FAILURE
        Tedyu :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #154 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/154/ ) HBASE-6564 HDFS space is not reclaimed when a column family is deleted (J Mohamed) (Revision 1378648) Result = FAILURE Tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Hide
        J Mohamed Zahoor added a comment -

        Thanks Ted.

        Show
        J Mohamed Zahoor added a comment - Thanks Ted.
        Hide
        Michael Drzal added a comment -

        Ted Yu can we close this out?

        Show
        Michael Drzal added a comment - Ted Yu can we close this out?
        Hide
        J Mohamed Zahoor added a comment -

        Yes. I guess.

        Show
        J Mohamed Zahoor added a comment - Yes. I guess.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #644 (See https://builds.apache.org/job/HBase-0.94/644/)
        HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #644 (See https://builds.apache.org/job/HBase-0.94/644/ ) HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #87 (See https://builds.apache.org/job/HBase-0.94-security/87/)
        HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #87 (See https://builds.apache.org/job/HBase-0.94-security/87/ ) HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/)
        HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/ ) HBASE-7283 Backport HBASE-6564 + HBASE-7202 to 0.94 (Revision 1423774) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java

          People

          • Assignee:
            J Mohamed Zahoor
            Reporter:
            J Mohamed Zahoor
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development