HBase
  1. HBase
  2. HBASE-6514

unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.2, 0.94.0
    • Fix Version/s: 0.94.2
    • Component/s: test
    • Labels:
      None
    • Environment:

      MacOS 10.8
      Oracle JDK 1.7

      Description

      When trying to run a unit test that just starts up and shutdown the server the following errors occur in System.out

      01:10:59,874 ERROR MetricsUtil:116 - unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram
      01:10:59,874 ERROR MetricsUtil:116 - unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram
      01:10:59,875 ERROR MetricsUtil:116 - unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram
      01:10:59,875 ERROR MetricsUtil:116 - unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram

      1. out.txt
        131 kB
        stack
      2. HBASE-6514-trunk-0.patch
        0.9 kB
        Elliott Clark
      3. HBASE-6514-94-0.patch
        0.9 kB
        Elliott Clark
      4. FrameworkTest.java
        0.6 kB
        Archimedes Trajano
      5. FrameworkTest.java
        0.7 kB
        stack

        Activity

        Archimedes Trajano created issue -
        Hide
        Archimedes Trajano added a comment -

        The test case does pass though.

        Show
        Archimedes Trajano added a comment - The test case does pass though.
        Hide
        Archimedes Trajano added a comment -

        Sample JUnit test I had used.

        Show
        Archimedes Trajano added a comment - Sample JUnit test I had used.
        Archimedes Trajano made changes -
        Field Original Value New Value
        Attachment FrameworkTest.java [ 12539241 ]
        stack made changes -
        Fix Version/s 0.92.2 [ 12319888 ]
        Affects Version/s 0.92.2 [ 12319888 ]
        Priority Major [ 3 ] Blocker [ 1 ]
        Elliott Clark made changes -
        Assignee Elliott Clark [ eclark ]
        Hide
        Elliott Clark added a comment -

        Pretty easy fix for the log spam.

        Show
        Elliott Clark added a comment - Pretty easy fix for the log spam.
        Elliott Clark made changes -
        Attachment HBASE-6514-94-0.patch [ 12542352 ]
        Hide
        Elliott Clark added a comment -

        Trunk version. 0.92 and 0.94 versions are identical.

        Show
        Elliott Clark added a comment - Trunk version. 0.92 and 0.94 versions are identical.
        Elliott Clark made changes -
        Attachment HBASE-6514-trunk-0.patch [ 12542356 ]
        Elliott Clark made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.2 [ 12321884 ]
        Hide
        Lars Hofhansl added a comment -

        +1 on patch

        Show
        Lars Hofhansl added a comment - +1 on patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12542356/HBASE-6514-trunk-0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542356/HBASE-6514-trunk-0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2684//console This message is automatically generated.
        Lars Hofhansl made changes -
        Priority Blocker [ 1 ] Major [ 3 ]
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.92, 0.94, and 0.96.

        Show
        Lars Hofhansl added a comment - Committed to 0.92, 0.94, and 0.96.
        Lars Hofhansl made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #434 (See https://builds.apache.org/job/HBase-0.94/434/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #434 (See https://builds.apache.org/job/HBase-0.94/434/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #532 (See https://builds.apache.org/job/HBase-0.92/532/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377208)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #532 (See https://builds.apache.org/job/HBase-0.92/532/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377208) Result = SUCCESS larsh : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3275 (See https://builds.apache.org/job/HBase-TRUNK/3275/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377210)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3275 (See https://builds.apache.org/job/HBase-TRUNK/3275/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377210) Result = FAILURE larsh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #147 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/147/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377210)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #147 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/147/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377210) Result = FAILURE larsh : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #50 (See https://builds.apache.org/job/HBase-0.94-security/50/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #50 (See https://builds.apache.org/job/HBase-0.94-security/50/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #117 (See https://builds.apache.org/job/HBase-0.92-security/117/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377208)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #117 (See https://builds.apache.org/job/HBase-0.92-security/117/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377208) Result = SUCCESS larsh : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        stack added a comment -

        Elliott, the patch committed is different from what you thought fixed the issue? Remember you thought you'd fixed it but when I ran it w/ Archimedes' little test code, the ERRORs still showed.... later you said you'd fixed it and I'm wondering if this is the code that was committed? Thanks.

        Show
        stack added a comment - Elliott, the patch committed is different from what you thought fixed the issue? Remember you thought you'd fixed it but when I ran it w/ Archimedes' little test code, the ERRORs still showed.... later you said you'd fixed it and I'm wondering if this is the code that was committed? Thanks.
        Hide
        stack added a comment -

        Elliott, the patch committed is different from what you thought fixed the issue? Remember you thought you'd fixed it but when I ran it w/ Archimedes' little test code, the ERRORs still showed.... later you said you'd fixed it and I'm wondering if this is the code that was committed? Thanks.

        Show
        stack added a comment - Elliott, the patch committed is different from what you thought fixed the issue? Remember you thought you'd fixed it but when I ran it w/ Archimedes' little test code, the ERRORs still showed.... later you said you'd fixed it and I'm wondering if this is the code that was committed? Thanks.
        Hide
        Ted Yu added a comment -

        @Elliot:
        Can you answer Stack's questions ?

        Thanks

        Show
        Ted Yu added a comment - @Elliot: Can you answer Stack's questions ? Thanks
        Hide
        Asaf Mesika added a comment -

        Just saw it too in 0.94.0

        Show
        Asaf Mesika added a comment - Just saw it too in 0.94.0
        Hide
        Elliott Clark added a comment -

        Yes the code committed will fix the log spam (https://github.com/apache/hbase/commit/dd2c09a790dd5a1c0236cc9e511523c731325a76).

        The code I was thinking about was in HBASE-6211. That issue was committed earlier that made it so that histograms were actually used and exported through the metrics system. However the log spam remained because base classes were seeing some instances of histograms before the super classes were able to register as being responsible.

        The patch in this issue should make it so that MetricsHistogram's and ExactCounterMetric are correctly taken care of assuming that an org.apache.hadoop.hbase.MetricsMBeanBase is used to export them. For trunk the best thing will be to just finish moving everything to metrics2. It has a better system for creating our own metrics classes.

        Show
        Elliott Clark added a comment - Yes the code committed will fix the log spam ( https://github.com/apache/hbase/commit/dd2c09a790dd5a1c0236cc9e511523c731325a76 ). The code I was thinking about was in HBASE-6211 . That issue was committed earlier that made it so that histograms were actually used and exported through the metrics system. However the log spam remained because base classes were seeing some instances of histograms before the super classes were able to register as being responsible. The patch in this issue should make it so that MetricsHistogram's and ExactCounterMetric are correctly taken care of assuming that an org.apache.hadoop.hbase.MetricsMBeanBase is used to export them. For trunk the best thing will be to just finish moving everything to metrics2. It has a better system for creating our own metrics classes.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/)
        HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/ ) HBASE-6514 unknown metrics type: org.apache.hadoop.hbase.metrics.histogram.MetricsHistogram (Elliot Clark) (Revision 1377207) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
        Hide
        stack added a comment -

        I ran a modified version of Archimedes script (I added a main to it to run all tests – its attached here). Here is output missing the ERROR metrics methods so it seems indeed that this issue is fixed.

        Here is how I compiled it:

        javac -cp `./bin/hbase classpath` ./FrameworkTest.java
        

        I then copied the class file to:

        mv FrameworkTest.class net/trajano/nosql/hbase/test/FrameworkTest.class
        

        Here is how I ran it:

        $ java -classpath .:`./bin/hbase classpath` net.trajano.nosql.hbase.test.FrameworkTest &> /tmp/out.txt
        
        Show
        stack added a comment - I ran a modified version of Archimedes script (I added a main to it to run all tests – its attached here). Here is output missing the ERROR metrics methods so it seems indeed that this issue is fixed. Here is how I compiled it: javac -cp `./bin/hbase classpath` ./FrameworkTest.java I then copied the class file to: mv FrameworkTest.class net/trajano/nosql/hbase/test/FrameworkTest.class Here is how I ran it: $ java -classpath .:`./bin/hbase classpath` net.trajano.nosql.hbase.test.FrameworkTest &> /tmp/out.txt
        stack made changes -
        Attachment out.txt [ 12543813 ]
        Attachment FrameworkTest.java [ 12543814 ]
        Hide
        Elliott Clark added a comment -

        Thanks Stack. Always nice to have a double check.

        Show
        Elliott Clark added a comment - Thanks Stack. Always nice to have a double check.
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.92.2 [ 12319888 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.2 [ 12321884 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.2 [ 12321884 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        Fix Version/s 0.94.2 [ 12321884 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        Hide
        stack added a comment -

        Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

        Show
        stack added a comment - Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)
        stack made changes -
        Fix Version/s 0.94.2 [ 12321884 ]
        Fix Version/s 0.95.0 [ 12324094 ]

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Archimedes Trajano
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development