HBase
  1. HBase
  2. HBASE-6369

HTable is not closed in AggregationClient

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1, 0.94.0
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In AggregationClient, HTable instance is not closed.

      1. HBASE-6369-trunk-2.patch
        10 kB
        binlijin
      2. HBASE-6369-trunk.patch
        2 kB
        binlijin
      3. HBASE-6369-0.94-2.patch
        9 kB
        binlijin
      4. HBASE-6369-0.94.patch
        2 kB
        binlijin
      5. HBASE-6369-0.92-2.patch
        7 kB
        binlijin
      6. HBASE-6369-0.92.patch
        1 kB
        binlijin

        Activity

        Hide
        Ted Yu added a comment -
          public <T extends CoprocessorProtocol, R> Map<byte[],R> coprocessorExec(
              Class<T> protocol, byte[] startKey, byte[] endKey,
              Batch.Call<T,R> callable)
              throws IOException, Throwable {
        

        Should we protect against table.coprocessorExec() throwing exception ?
        Meaning, we should enclose all table.close() calls in finally block.

        Show
        Ted Yu added a comment - public <T extends CoprocessorProtocol, R> Map< byte [],R> coprocessorExec( Class <T> protocol, byte [] startKey, byte [] endKey, Batch.Call<T,R> callable) throws IOException, Throwable { Should we protect against table.coprocessorExec() throwing exception ? Meaning, we should enclose all table.close() calls in finally block.
        Hide
        binlijin added a comment -

        @Ted,
        Thanks for the advice.

        Show
        binlijin added a comment - @Ted, Thanks for the advice.
        Hide
        Ted Yu added a comment -

        ResultScanner.close() doesn't throw exception.
        So the formation in patch v2 is fine.

        +1, pending Hadoop QA results.

        Show
        Ted Yu added a comment - ResultScanner.close() doesn't throw exception. So the formation in patch v2 is fine. +1, pending Hadoop QA results.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12535979/HBASE-6369-trunk-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

        -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535979/HBASE-6369-trunk-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2363//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Hadoop QA actually passed:

        [INFO] HBase ............................................. SUCCESS [1.927s]
        [INFO] HBase - Common .................................... SUCCESS [4.046s]
        [INFO] HBase - Server .................................... SUCCESS [38:32.534s]
        [INFO] HBase - Integration Tests ......................... SUCCESS [1.405s]
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD SUCCESS
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 38:40.251s
        [INFO] Finished at: Wed Jul 11 05:42:45 UTC 2012
        

        Will integrate tomorrow if there is no objection.

        Show
        Ted Yu added a comment - Hadoop QA actually passed: [INFO] HBase ............................................. SUCCESS [1.927s] [INFO] HBase - Common .................................... SUCCESS [4.046s] [INFO] HBase - Server .................................... SUCCESS [38:32.534s] [INFO] HBase - Integration Tests ......................... SUCCESS [1.405s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 38:40.251s [INFO] Finished at: Wed Jul 11 05:42:45 UTC 2012 Will integrate tomorrow if there is no objection.
        Hide
        stack added a comment -

        +1 on patch.

        Show
        stack added a comment - +1 on patch.
        Hide
        Ted Yu added a comment -

        Integrated to trunk.

        Thanks for the patch, binlijin.

        Thanks for the review, Stack.

        Show
        Ted Yu added a comment - Integrated to trunk. Thanks for the patch, binlijin. Thanks for the review, Stack.
        Hide
        Ted Yu added a comment -

        After getting Lars' endorsement, I have integrated to 0.94 branch as well.

        Show
        Ted Yu added a comment - After getting Lars' endorsement, I have integrated to 0.94 branch as well.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #311 (See https://builds.apache.org/job/HBase-0.94/311/)
        HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #311 (See https://builds.apache.org/job/HBase-0.94/311/ ) HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #40 (See https://builds.apache.org/job/HBase-0.94-security/40/)
        HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #40 (See https://builds.apache.org/job/HBase-0.94-security/40/ ) HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342) Result = SUCCESS tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/)
        HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342)

        Result = FAILURE
        tedyu :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/ ) HBASE-6369 HTable is not closed in AggregationClient (binlijin) (Revision 1360342) Result = FAILURE tedyu : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java

          People

          • Assignee:
            binlijin
            Reporter:
            binlijin
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development