HBase
  1. HBase
  2. HBASE-6324

Direct API calls from embedded Thrift server to regionserver

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      When handling Thrift calls in the regionserver we should not go through RPC to talk to the local regionserver.

        Activity

        Hide
        stack added a comment -

        Resolving as no longer valid given running thrift server in regionserver context an abandoned experiment.

        Show
        stack added a comment - Resolving as no longer valid given running thrift server in regionserver context an abandoned experiment.
        Hide
        Sergey Shelukhin added a comment -

        Should this be resolved won't fix then?

        Show
        Sergey Shelukhin added a comment - Should this be resolved won't fix then?
        Hide
        stack added a comment -

        Sergey Shelukhin The 'direct api calls from embedded thrift server to regionserver' seems to have been a failed or abandoned experiment Sergey. See http://search-hadoop.com/m/GAFt6B9CRZ Might not be worth expending effort on.

        Show
        stack added a comment - Sergey Shelukhin The 'direct api calls from embedded thrift server to regionserver' seems to have been a failed or abandoned experiment Sergey. See http://search-hadoop.com/m/GAFt6B9CRZ Might not be worth expending effort on.
        Hide
        Sergey Shelukhin added a comment -

        does it make sense to port this to 0.94? trunk uses protocol buffers so that'd require a brand new patch as far as I see, and with additional layer of indirection, unless protobufs allows some sort of "local" proxy.

        Show
        Sergey Shelukhin added a comment - does it make sense to port this to 0.94? trunk uses protocol buffers so that'd require a brand new patch as far as I see, and with additional layer of indirection, unless protobufs allows some sort of "local" proxy.
        Hide
        Michael Drzal added a comment -

        stack thanks for the explanation. That makes sense.

        Show
        Michael Drzal added a comment - stack thanks for the explanation. That makes sense.
        Hide
        stack added a comment -

        My guess is that we need to forward port this facility from the 89-fb branch Michael.

        Show
        stack added a comment - My guess is that we need to forward port this facility from the 89-fb branch Michael.
        Hide
        Michael Drzal added a comment -

        Looking at the facebook review, it appears that this mostly done. Mikhail Bautin what else needs to get done to close this out here?

        Show
        Michael Drzal added a comment - Looking at the facebook review, it appears that this mostly done. Mikhail Bautin what else needs to get done to close this out here?
        Hide
        Mikhail Bautin added a comment - - edited
        Show
        Mikhail Bautin added a comment - - edited Diff is at https://reviews.facebook.net/D3981 (89-fb)

          People

          • Assignee:
            Mikhail Bautin
            Reporter:
            Mikhail Bautin
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development