HBase
  1. HBase
  2. HBASE-6263

Use default mode for HBase Thrift gateway if not specified

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0, 0.95.2
    • Fix Version/s: 0.94.2
    • Component/s: Thrift
    • Labels:
    • Release Note:
      The Thrift gateway no longer requires specification on the command line of an implementation type when starting. If missing, the default "threadpool" implementation will be selected.

      Description

      The Thrift gateway should start with a default mode if one is not selected. Currently, instead we see:

      Exception in thread "main" java.lang.AssertionError: Exactly one option out of [-hsha, -nonblocking, -threadpool, -threadedselector] has to be specified
      	at org.apache.hadoop.hbase.thrift.ThriftServerRunner$ImplType.setServerImpl(ThriftServerRunner.java:201)
      	at org.apache.hadoop.hbase.thrift.ThriftServer.processOptions(ThriftServer.java:169)
      	at org.apache.hadoop.hbase.thrift.ThriftServer.doMain(ThriftServer.java:85)
      	at org.apache.hadoop.hbase.thrift.ThriftServer.main(ThriftServer.java:192)
      

      See also BIGTOP-648.

      1. HBASE-6263.patch
        1.0 kB
        Andrew Purtell
      2. HBASE-6263-0.94.patch
        0.9 kB
        Andrew Purtell

        Issue Links

          Activity

          Andrew Purtell created issue -
          Andrew Purtell made changes -
          Field Original Value New Value
          Link This issue relates to BIGTOP-648 [ BIGTOP-648 ]
          Andrew Purtell made changes -
          Labels noob
          Andrew Purtell made changes -
          Summary Binscript should pick a default mode for HBase Thrift gateway Use default mode for HBase Thrift gateway if not specified
          Assignee Andrew Purtell [ apurtell ]
          Component/s scripts [ 12312141 ]
          Andrew Purtell made changes -
          Attachment HBASE-6263.patch [ 12533514 ]
          Attachment HBASE-6263-0.94.patch [ 12533515 ]
          Andrew Purtell made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Affects Version/s 0.92.1 [ 12318551 ]
          Andrew Purtell made changes -
          Attachment HBASE-6263-0.94.patch [ 12533515 ]
          Andrew Purtell made changes -
          Attachment HBASE-6263.patch [ 12533514 ]
          Andrew Purtell made changes -
          Attachment HBASE-6263.patch [ 12533516 ]
          Attachment HBASE-6263-0.94.patch [ 12533517 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12533517/HBASE-6263-0.94.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2263//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12533517/HBASE-6263-0.94.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2263//console This message is automatically generated.
          Elliott Clark made changes -
          Link This issue duplicates HBASE-6166 [ HBASE-6166 ]
          Hide
          Jean-Daniel Cryans added a comment -

          Andrew, do you want to commit this? I stopped counting the number of times we messed up a thrift bounce because of this.

          Show
          Jean-Daniel Cryans added a comment - Andrew, do you want to commit this? I stopped counting the number of times we messed up a thrift bounce because of this.
          Hide
          Andrew Purtell added a comment -

          Sorry J-D, forgot about this, committing now.

          Show
          Andrew Purtell added a comment - Sorry J-D, forgot about this, committing now.
          Hide
          Andrew Purtell added a comment -

          Committed to trunk and 0.94 branch.

          Show
          Andrew Purtell added a comment - Committed to trunk and 0.94 branch.
          Andrew Purtell made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Release Note The Thrift gateway no longer requires specification on the command line of an implementation type when starting. If missing, the default "threadpool" implementation will be selected.
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.94.2 [ 12321884 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #3220 (See https://builds.apache.org/job/HBase-TRUNK/3220/)
          HBASE-6263. Use default mode for Thrift gateway if not specified (Revision 1373591)

          Result = SUCCESS
          apurtell :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #3220 (See https://builds.apache.org/job/HBase-TRUNK/3220/ ) HBASE-6263 . Use default mode for Thrift gateway if not specified (Revision 1373591) Result = SUCCESS apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94 #396 (See https://builds.apache.org/job/HBase-0.94/396/)
          HBASE-6263. Use default mode for Thrift gateway if not specified (Revision 1373593)

          Result = SUCCESS
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          Hudson added a comment - Integrated in HBase-0.94 #396 (See https://builds.apache.org/job/HBase-0.94/396/ ) HBASE-6263 . Use default mode for Thrift gateway if not specified (Revision 1373593) Result = SUCCESS apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #131 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/131/)
          HBASE-6263. Use default mode for Thrift gateway if not specified (Revision 1373591)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #131 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/131/ ) HBASE-6263 . Use default mode for Thrift gateway if not specified (Revision 1373591) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security #48 (See https://builds.apache.org/job/HBase-0.94-security/48/)
          HBASE-6263. Use default mode for Thrift gateway if not specified (Revision 1373593)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security #48 (See https://builds.apache.org/job/HBase-0.94-security/48/ ) HBASE-6263 . Use default mode for Thrift gateway if not specified (Revision 1373593) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Hide
          Hudson added a comment -

          Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/)
          HBASE-6263. Use default mode for Thrift gateway if not specified (Revision 1373593)

          Result = FAILURE
          apurtell :
          Files :

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Show
          Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/ ) HBASE-6263 . Use default mode for Thrift gateway if not specified (Revision 1373593) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          Fix Version/s 0.94.2 [ 12321884 ]
          Lars Hofhansl made changes -
          Fix Version/s 0.94.2 [ 12321884 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          Fix Version/s 0.94.2 [ 12321884 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          Hide
          stack added a comment -

          Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

          Show
          stack added a comment - Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)
          stack made changes -
          Fix Version/s 0.94.2 [ 12321884 ]
          Fix Version/s 0.95.0 [ 12324094 ]
          Anatoli Fomenko made changes -
          Link This issue blocks BIGTOP-960 [ BIGTOP-960 ]
          Gavin made changes -
          Link This issue blocks BIGTOP-960 [ BIGTOP-960 ]
          Gavin made changes -
          Link This issue is depended upon by BIGTOP-960 [ BIGTOP-960 ]

            People

            • Assignee:
              Andrew Purtell
              Reporter:
              Andrew Purtell
            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development