HBase
  1. HBase
  2. HBASE-6228

Fixup daughters twice cause daughter region assigned twice

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      First, how fixup daughters twice happen?
      1.we will fixupDaughters at the last of HMaster#finishInitialization
      2.ServerShutdownHandler will fixupDaughters when reassigning region through ServerShutdownHandler#processDeadRegion

      When fixupDaughters, we will added daughters to .META., but it coudn't prevent the above case, because FindDaughterVisitor.

      The detail is as the following:
      Suppose region A is a splitted parent region, and its daughter region B is missing

      1.First, ServerShutdownHander thread fixup daughter, so add daughter region B to .META. with serverName=null, and assign the daughter.

      2.Then, Master's initialization thread will also find the daughter region B is missing and assign it. It is because FindDaughterVisitor consider daughter is missing if its serverName=null

      1. HBASE-6228.patch
        0.8 kB
        chunhui shen
      2. HBASE-6228v2.patch
        1.0 kB
        chunhui shen
      3. HBASE-6228v2.patch
        0.9 kB
        chunhui shen
      4. HBASE-6228v3.patch
        7 kB
        chunhui shen
      5. HBASE-6228v4.patch
        9 kB
        ramkrishna.s.vasudevan

        Issue Links

          Activity

          chunhui shen created issue -
          chunhui shen made changes -
          Field Original Value New Value
          Attachment HBASE-6228.patch [ 12532372 ]
          ramkrishna.s.vasudevan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ted Yu made changes -
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          chunhui shen made changes -
          Attachment HBASE-6228v2.patch [ 12532666 ]
          chunhui shen made changes -
          Attachment HBASE-6228v2.patch [ 12532668 ]
          chunhui shen made changes -
          Attachment HBASE-6228v3.patch [ 12533624 ]
          ramkrishna.s.vasudevan made changes -
          Attachment HBASE-6228v4.patch [ 12533642 ]
          ramkrishna.s.vasudevan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          ramkrishna.s.vasudevan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jimmy Xiang made changes -
          Link This issue relates to HBASE-6381 [ HBASE-6381 ]
          Jimmy Xiang made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Implemented [ 10 ]
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          stack made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              chunhui shen
              Reporter:
              chunhui shen
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development