Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.2
    • Component/s: metrics, monitoring
    • Labels:
      None
    • Environment:

      RegionServerMetrics pushes latency histograms to hadoop metrics, but they are not getting into jmx.

    • Hadoop Flags:
      Reviewed
    1. HBASE-6211-0.patch
      5 kB
      Elliott Clark
    2. HBASE-6211-1.patch
      8 kB
      Elliott Clark
    3. HBASE-6211-2.patch
      12 kB
      Elliott Clark
    4. 6211_092.txt
      11 kB
      stack

      Activity

      Hide
      Elliott Clark added a comment -

      Added the first pass at this. I really should go back and make the strings constants defined in one place.

      Show
      Elliott Clark added a comment - Added the first pass at this. I really should go back and make the strings constants defined in one place.
      Hide
      Elliott Clark added a comment -

      Added constants.

      Show
      Elliott Clark added a comment - Added constants.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12532273/HBASE-6211-1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532273/HBASE-6211-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2173//console This message is automatically generated.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12532267/HBASE-6211-0.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.replication.TestReplication

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532267/HBASE-6211-0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2172//console This message is automatically generated.
      Hide
      Ted Yu added a comment -

      Patch looks good.

      Show
      Ted Yu added a comment - Patch looks good.
      Hide
      stack added a comment -

      +1 on patch. Elliott, can you prove they show up in jmx? Then we'll commit.

      Show
      stack added a comment - +1 on patch. Elliott, can you prove they show up in jmx? Then we'll commit.
      Hide
      Elliott Clark added a comment -

      I've done manual spot checks. I'll try and get a unit test that tries to query jmx or something.

      Show
      Elliott Clark added a comment - I've done manual spot checks. I'll try and get a unit test that tries to query jmx or something.
      Hide
      Elliott Clark added a comment -

      Added mock tests. Anything that was full stack was pretty onerous and I didn't feel a Large test was needed, let me know if you disagree.

      Show
      Elliott Clark added a comment - Added mock tests. Anything that was full stack was pretty onerous and I didn't feel a Large test was needed, let me know if you disagree.
      Hide
      stack added a comment -

      Trying against hudsonqa

      Show
      stack added a comment - Trying against hudsonqa
      Hide
      stack added a comment -

      +1 on v2 w/ test. Will commit after hadoopqa is done

      Show
      stack added a comment - +1 on v2 w/ test. Will commit after hadoopqa is done
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12532435/HBASE-6211-2.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//testReport/
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
      Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12532435/HBASE-6211-2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2186//console This message is automatically generated.
      Hide
      Ted Yu added a comment -

      Integrated to trunk.

      Thanks for the patch Elliot.

      Thanks for the review, Stack.

      Show
      Ted Yu added a comment - Integrated to trunk. Thanks for the patch Elliot. Thanks for the review, Stack.
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #3043 (See https://builds.apache.org/job/HBase-TRUNK/3043/)
      HBASE-6211 Put latencies in jmx (Elliot Clark)

      Submitted by: Elliot Clark
      Reviewed by: Stack, Ted (Revision 1351789)

      Result = FAILURE
      tedyu :
      Files :

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #3043 (See https://builds.apache.org/job/HBase-TRUNK/3043/ ) HBASE-6211 Put latencies in jmx (Elliot Clark) Submitted by: Elliot Clark Reviewed by: Stack, Ted (Revision 1351789) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #60 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/60/)
      HBASE-6211 Put latencies in jmx (Elliot Clark)

      Submitted by: Elliot Clark
      Reviewed by: Stack, Ted (Revision 1351789)

      Result = FAILURE
      tedyu :
      Files :

      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #60 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/60/ ) HBASE-6211 Put latencies in jmx (Elliot Clark) Submitted by: Elliot Clark Reviewed by: Stack, Ted (Revision 1351789) Result = FAILURE tedyu : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      stack added a comment -

      Backport of patch for 0.92.

      Show
      stack added a comment - Backport of patch for 0.92.
      Hide
      stack added a comment -

      I applied this to 0.92 and 0.94 to fix HBASE-6514

      Show
      stack added a comment - I applied this to 0.92 and 0.94 to fix HBASE-6514
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94 #430 (See https://builds.apache.org/job/HBase-0.94/430/)
      HBASE-6211 Put latencies in jmx (Revision 1377107)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-0.94 #430 (See https://builds.apache.org/job/HBase-0.94/430/ ) HBASE-6211 Put latencies in jmx (Revision 1377107) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.92 #531 (See https://builds.apache.org/job/HBase-0.92/531/)
      HBASE-6211 Put latencies in jmx (Revision 1377105)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-0.92 #531 (See https://builds.apache.org/job/HBase-0.92/531/ ) HBASE-6211 Put latencies in jmx (Revision 1377105) Result = FAILURE stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94-security #50 (See https://builds.apache.org/job/HBase-0.94-security/50/)
      HBASE-6211 Put latencies in jmx (Revision 1377107)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-0.94-security #50 (See https://builds.apache.org/job/HBase-0.94-security/50/ ) HBASE-6211 Put latencies in jmx (Revision 1377107) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.92-security #117 (See https://builds.apache.org/job/HBase-0.92-security/117/)
      HBASE-6211 Put latencies in jmx (Revision 1377105)

      Result = SUCCESS
      stack :
      Files :

      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-0.92-security #117 (See https://builds.apache.org/job/HBase-0.92-security/117/ ) HBASE-6211 Put latencies in jmx (Revision 1377105) Result = SUCCESS stack : Files : /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      Gregory Chanan added a comment -

      Added 0.92.2 and 0.94.2 to fix version.

      Show
      Gregory Chanan added a comment - Added 0.92.2 and 0.94.2 to fix version.
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/)
      HBASE-6211 Put latencies in jmx (Revision 1377107)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Show
      Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #7 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/7/ ) HBASE-6211 Put latencies in jmx (Revision 1377107) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/MetricsMBeanBase.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsMBeanBase.java
      Hide
      stack added a comment -

      Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

      Show
      stack added a comment - Fix up after bulk move overwrote some 0.94.2 fix versions w/ 0.95.0 (Noticed by Lars Hofhansl)

        People

        • Assignee:
          Elliott Clark
          Reporter:
          Elliott Clark
        • Votes:
          1 Vote for this issue
          Watchers:
          8 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development