Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-6178

LoadTest tool no longer packaged after the modularization

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      jesse_yates Jesse Yates added a comment -

      Worked out the issue, and also got the fix along with some cleanup to the descriptors. Patch coming soon.

      Show
      jesse_yates Jesse Yates added a comment - Worked out the issue, and also got the fix along with some cleanup to the descriptors. Patch coming soon.
      Hide
      jesse_yates Jesse Yates added a comment -

      Attaching patch - works locally.

      Show
      jesse_yates Jesse Yates added a comment - Attaching patch - works locally.
      Hide
      lhofhansl Lars Hofhansl added a comment -

      Tested compilation locally, verified the server-sests jar is included (which has PE in it).
      +1

      Will commit soon unless there are objections.

      Show
      lhofhansl Lars Hofhansl added a comment - Tested compilation locally, verified the server-sests jar is included (which has PE in it). +1 Will commit soon unless there are objections.
      Hide
      eclark Elliott Clark added a comment -

      Tested it locally and everything works well.
      Should we include the hbase-hadoop-compat and hbase-hadoop

      {1|2}

      -compat test-jar's as well?

      Show
      eclark Elliott Clark added a comment - Tested it locally and everything works well. Should we include the hbase-hadoop-compat and hbase-hadoop {1|2} -compat test-jar's as well?
      Hide
      lhofhansl Lars Hofhansl added a comment -

      Heh... We were just debating that. Currently there is nothing interesting in those.

      Show
      lhofhansl Lars Hofhansl added a comment - Heh... We were just debating that. Currently there is nothing interesting in those.
      Hide
      lhofhansl Lars Hofhansl added a comment -

      In fact, why is PE in the "test" jar anyway? It seems that should be something to be included in the HBase jar proper.

      Show
      lhofhansl Lars Hofhansl added a comment - In fact, why is PE in the "test" jar anyway? It seems that should be something to be included in the HBase jar proper.
      Hide
      jesse_yates Jesse Yates added a comment -

      @Elliott - I don't think its worth adding them right now. We only release the server-tests jar since it has the mini-cluster which is useful for people testing stuff on hbase and need a minicluster. *-compat and -it don't actually have anything useful in them. That will probably change for -it, but lets deal with that when we get there.

      Show
      jesse_yates Jesse Yates added a comment - @Elliott - I don't think its worth adding them right now. We only release the server-tests jar since it has the mini-cluster which is useful for people testing stuff on hbase and need a minicluster. *-compat and -it don't actually have anything useful in them. That will probably change for -it, but lets deal with that when we get there.
      Hide
      eclark Elliott Clark added a comment -

      I'm +1 then as long as we re-visit if a test util ever starts relying on a hadoop compat test-jar.

      Show
      eclark Elliott Clark added a comment - I'm +1 then as long as we re-visit if a test util ever starts relying on a hadoop compat test-jar.
      Hide
      jesse_yates Jesse Yates added a comment -

      @Lars- agree that is probably should just be in the regular jar, but lets do it in another issue

      Show
      jesse_yates Jesse Yates added a comment - @Lars- agree that is probably should just be in the regular jar, but lets do it in another issue
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12544899/hbase-6178-v0.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      -1 javac. The patch appears to cause mvn compile goal to fail.

      -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.client.TestFromClientSide
      org.apache.hadoop.hbase.replication.TestReplication

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2852//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2852//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12544899/hbase-6178-v0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2852//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2852//console This message is automatically generated.
      Hide
      lhofhansl Lars Hofhansl added a comment -

      Test failures must be unrelated.

      Show
      lhofhansl Lars Hofhansl added a comment - Test failures must be unrelated.
      Hide
      lhofhansl Lars Hofhansl added a comment -

      I'll double check the test failures and then commit.

      Show
      lhofhansl Lars Hofhansl added a comment - I'll double check the test failures and then commit.
      Hide
      stack stack added a comment -

      Committed to trunk after review. I tried the failing tests. TestReplication fails w/ or w/o this patch. Thanks Jesse.

      Show
      stack stack added a comment - Committed to trunk after review. I tried the failing tests. TestReplication fails w/ or w/o this patch. Thanks Jesse.
      Hide
      hudson Hudson added a comment -

      Integrated in HBase-TRUNK #3358 (See https://builds.apache.org/job/HBase-TRUNK/3358/)
      HBASE-6178 LoadTest tool no longer packaged after the modularization (Revision 1387860)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/pom.xml
      • /hbase/trunk/src/assembly/components.xml
      • /hbase/trunk/src/assembly/hadoop-one-compat.xml
      • /hbase/trunk/src/assembly/hadoop-two-compat.xml
      Show
      hudson Hudson added a comment - Integrated in HBase-TRUNK #3358 (See https://builds.apache.org/job/HBase-TRUNK/3358/ ) HBASE-6178 LoadTest tool no longer packaged after the modularization (Revision 1387860) Result = FAILURE stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/assembly/components.xml /hbase/trunk/src/assembly/hadoop-one-compat.xml /hbase/trunk/src/assembly/hadoop-two-compat.xml
      Hide
      hudson Hudson added a comment -

      Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #183 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/183/)
      HBASE-6178 LoadTest tool no longer packaged after the modularization (Revision 1387860)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/pom.xml
      • /hbase/trunk/src/assembly/components.xml
      • /hbase/trunk/src/assembly/hadoop-one-compat.xml
      • /hbase/trunk/src/assembly/hadoop-two-compat.xml
      Show
      hudson Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #183 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/183/ ) HBASE-6178 LoadTest tool no longer packaged after the modularization (Revision 1387860) Result = FAILURE stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/assembly/components.xml /hbase/trunk/src/assembly/hadoop-one-compat.xml /hbase/trunk/src/assembly/hadoop-two-compat.xml
      Hide
      stack stack added a comment -

      Marking closed.

      Show
      stack stack added a comment - Marking closed.

        People

        • Assignee:
          jesse_yates Jesse Yates
          Reporter:
          eclark Elliott Clark
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development