HBase
  1. HBase
  2. HBASE-6168

[replication] Add replication zookeeper state documentation to replication.html

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: documentation, Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Add a detailed explanation about the zookeeper state that HBase replication maintains.

      1. HBASE-6168.patch
        8 kB
        Chris Trezzo
      2. HBASE-6168v2.patch
        8 kB
        Chris Trezzo
      3. HBASE-6168v3.patch
        8 kB
        Chris Trezzo

        Activity

        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #47 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/47/)
        HBASE-6168 [replication] Add replication zookeeper state documentation to replication.html (Revision 1347383)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/site/xdoc/replication.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #47 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/47/ ) HBASE-6168 [replication] Add replication zookeeper state documentation to replication.html (Revision 1347383) Result = FAILURE stack : Files : /hbase/trunk/src/site/xdoc/replication.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2997 (See https://builds.apache.org/job/HBase-TRUNK/2997/)
        HBASE-6168 [replication] Add replication zookeeper state documentation to replication.html (Revision 1347383)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/site/xdoc/replication.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2997 (See https://builds.apache.org/job/HBase-TRUNK/2997/ ) HBASE-6168 [replication] Add replication zookeeper state documentation to replication.html (Revision 1347383) Result = FAILURE stack : Files : /hbase/trunk/src/site/xdoc/replication.xml
        Hide
        stack added a comment -

        Applied to trunk. Thanks for the patch Chris.

        Show
        stack added a comment - Applied to trunk. Thanks for the patch Chris.
        Hide
        Chris Trezzo added a comment -

        Thanks Enis for the comment.

        • The peer name does not have to be an integer, you are totally right. I have removed the comment about it being an integer.
        • I left out the failover lock stuff for simplicity of the explanation. I was thinking about doing a section specifically on what happens to zookeeper state in failover scenarios, but I decided to hold off because I think it might change in the near future due to HBASE-2611.

        Attached is another patch.

        Chris

        Show
        Chris Trezzo added a comment - Thanks Enis for the comment. The peer name does not have to be an integer, you are totally right. I have removed the comment about it being an integer. I left out the failover lock stuff for simplicity of the explanation. I was thinking about doing a section specifically on what happens to zookeeper state in failover scenarios, but I decided to hold off because I think it might change in the near future due to HBASE-2611 . Attached is another patch. Chris
        Hide
        Enis Soztutar added a comment -

        Great doc. minor issues:

        • the peer name does not have to be an integer, AFAIK.
        • we can add lock znodes for RS failover.
        Show
        Enis Soztutar added a comment - Great doc. minor issues: the peer name does not have to be an integer, AFAIK. we can add lock znodes for RS failover.
        Hide
        Chris Trezzo added a comment -

        Thanks for the comments stack!

        Here is a new patch:

        • Removed the side note about zookeeper metadata.
        • Mentioned that the znode names used in the examples are default.
        • Added the zookeeper.znode.parent to the znode path config table.

        Chris

        Show
        Chris Trezzo added a comment - Thanks for the comments stack! Here is a new patch: Removed the side note about zookeeper metadata. Mentioned that the znode names used in the examples are default. Added the zookeeper.znode.parent to the znode path config table. Chris
        Hide
        stack added a comment -

        Excellent.

        Stuff like this is really great "...Side note: If you are looking at the values directly in zookeeper, remember that hbase.zookeeper.RecoverableZookeeper adds metadata to znode values." Belongs in more general section on zk.

        Maybe allow somehow that it may not be /hbase/replication on your cluster (because /hbase is actually settable in zk config). Is that important? (Maybe you can just add a little note to your section on 'Configuration Parametters'

        We should fix it so you don't need peer-state, so peers has attribute on whether or not enabled.... but thats not this issue.

        Show
        stack added a comment - Excellent. Stuff like this is really great "...Side note: If you are looking at the values directly in zookeeper, remember that hbase.zookeeper.RecoverableZookeeper adds metadata to znode values." Belongs in more general section on zk. Maybe allow somehow that it may not be /hbase/replication on your cluster (because /hbase is actually settable in zk config). Is that important? (Maybe you can just add a little note to your section on 'Configuration Parametters' We should fix it so you don't need peer-state, so peers has attribute on whether or not enabled.... but thats not this issue.
        Hide
        Chris Trezzo added a comment -

        Here is a first patch for the doc. Any feedback is more than welcome.

        Thanks.
        Chris

        Show
        Chris Trezzo added a comment - Here is a first patch for the doc. Any feedback is more than welcome. Thanks. Chris

          People

          • Assignee:
            Chris Trezzo
            Reporter:
            Chris Trezzo
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development