HBase
  1. HBase
  2. HBASE-6141

InterfaceAudience breaks 0.94 on older versions of hadoop

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HBASE-6141-1.patch
      10 kB
      Elliott Clark
    2. HBASE-6141-0.patch
      7 kB
      Elliott Clark

      Activity

      Hide
      Andrew Purtell added a comment -

      Is Hadoop-annotations self contained so we can just pull it in as a dependency (like one can with Hadoop-auth if they want SPNEGO)?

      Show
      Andrew Purtell added a comment - Is Hadoop-annotations self contained so we can just pull it in as a dependency (like one can with Hadoop-auth if they want SPNEGO)?
      Hide
      Elliott Clark added a comment -

      Yes but there are only a few in the 0.94 branch so I would lean towards just removing them in 0.94. Looks like they slipped in on backports.

      Show
      Elliott Clark added a comment - Yes but there are only a few in the 0.94 branch so I would lean towards just removing them in 0.94. Looks like they slipped in on backports.
      Hide
      Elliott Clark added a comment -

      Remove the lines

      Show
      Elliott Clark added a comment - Remove the lines
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12530443/HBASE-6141-0.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 24 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2078//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530443/HBASE-6141-0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 24 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2078//console This message is automatically generated.
      Hide
      Elliott Clark added a comment -

      My sed-fu is not as strong as I thought.

      Show
      Elliott Clark added a comment - My sed-fu is not as strong as I thought.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12530457/HBASE-6141-1.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 3 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2079//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530457/HBASE-6141-1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2079//console This message is automatically generated.
      Hide
      stack added a comment -

      Committed to 0.94 branch. Thanks Elliott (This commit necessary because it narrows how much of the backing hadoop we depend on; for example, w/o this change, we can't compile hbase 0.94 on the cdh version we have here)

      Show
      stack added a comment - Committed to 0.94 branch. Thanks Elliott (This commit necessary because it narrows how much of the backing hadoop we depend on; for example, w/o this change, we can't compile hbase 0.94 on the cdh version we have here)
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94 #242 (See https://builds.apache.org/job/HBase-0.94/242/)
      HBASE-6141 InterfaceAudience breaks 0.94 on older versions of hadoop (Revision 1344927)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
      Show
      Hudson added a comment - Integrated in HBase-0.94 #242 (See https://builds.apache.org/job/HBase-0.94/242/ ) HBASE-6141 InterfaceAudience breaks 0.94 on older versions of hadoop (Revision 1344927) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/)
      HBASE-6141 InterfaceAudience breaks 0.94 on older versions of hadoop (Revision 1344927)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
      Show
      Hudson added a comment - Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/ ) HBASE-6141 InterfaceAudience breaks 0.94 on older versions of hadoop (Revision 1344927) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/HLogInputFormat.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionMetricsStorage.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/CompressionContext.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Compressor.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/Dictionary.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/LRUDictionary.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java

        People

        • Assignee:
          Elliott Clark
          Reporter:
          Elliott Clark
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development