HBase
  1. HBase
  2. HBASE-6131

Add attribution for code added by HBASE-5533 metrics

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. 6131.txt
      23 kB
      stack
    2. 6131_094.txt
      22 kB
      stack
    3. 6131_092.txt
      22 kB
      stack

      Activity

      Hide
      Hudson added a comment -

      Integrated in HBase-0.92-security #110 (See https://builds.apache.org/job/HBase-0.92-security/110/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1346033)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.92/pom.xml
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Show
      Hudson added a comment - Integrated in HBase-0.92-security #110 (See https://builds.apache.org/job/HBase-0.92-security/110/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1346033) Result = FAILURE stack : Files : /hbase/branches/0.92/pom.xml /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Hide
      Hudson added a comment -

      Integrated in HBase-0.92 #444 (See https://builds.apache.org/job/HBase-0.92/444/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1346033)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.92/pom.xml
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Show
      Hudson added a comment - Integrated in HBase-0.92 #444 (See https://builds.apache.org/job/HBase-0.92/444/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1346033) Result = FAILURE stack : Files : /hbase/branches/0.92/pom.xml /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Hide
      stack added a comment -

      I committed to 0.92. I apologized to Mr. Hale on twitter about a week ago. He was gracious in his response. Let me roll a new 0.92.2RC.

      Show
      stack added a comment - I committed to 0.92. I apologized to Mr. Hale on twitter about a week ago. He was gracious in his response. Let me roll a new 0.92.2RC.
      Hide
      stack added a comment -

      What I applied to 0.92 (Didn't realize the metrics patch had gone into 0.92).

      Show
      stack added a comment - What I applied to 0.92 (Didn't realize the metrics patch had gone into 0.92).
      Hide
      Andrew Purtell added a comment -

      Remove the copied code and pull in Yammer metrics-core for 0.92 too I'd say, with our apologies to Mr. Hale.

      Show
      Andrew Purtell added a comment - Remove the copied code and pull in Yammer metrics-core for 0.92 too I'd say, with our apologies to Mr. Hale.
      Hide
      Andrew Purtell added a comment -

      +1 on blocker for 0.92.

      Show
      Andrew Purtell added a comment - +1 on blocker for 0.92.
      Hide
      Jonathan Hsieh added a comment -

      Since this is in 0.92 as well, we should apply there as well? This is probably a blocker for 0.92.2rc0.

      Show
      Jonathan Hsieh added a comment - Since this is in 0.92 as well, we should apply there as well? This is probably a blocker for 0.92.2rc0.
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344305)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344304)

      Result = FAILURE
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java

      stack :
      Files :

      • /hbase/branches/0.94/pom.xml
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Show
      Hudson added a comment - Integrated in HBase-0.94-security #33 (See https://builds.apache.org/job/HBase-0.94-security/33/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344305) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344304) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java stack : Files : /hbase/branches/0.94/pom.xml /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344299)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/hbase-server/pom.xml
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      • /hbase/trunk/pom.xml
      Show
      Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344299) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java /hbase/trunk/pom.xml
      Hide
      Hudson added a comment -

      Integrated in HBase-0.94 #231 (See https://builds.apache.org/job/HBase-0.94/231/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344305)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344304)

      Result = SUCCESS
      stack :
      Files :

      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java

      stack :
      Files :

      • /hbase/branches/0.94/pom.xml
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Show
      Hudson added a comment - Integrated in HBase-0.94 #231 (See https://builds.apache.org/job/HBase-0.94/231/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344305) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344304) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java stack : Files : /hbase/branches/0.94/pom.xml /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #2953 (See https://builds.apache.org/job/HBase-TRUNK/2953/)
      HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344299)

      Result = FAILURE
      stack :
      Files :

      • /hbase/trunk/hbase-server/pom.xml
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java
      • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java
      • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java
      • /hbase/trunk/pom.xml
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #2953 (See https://builds.apache.org/job/HBase-TRUNK/2953/ ) HBASE-6131 Add attribution for code added by HBASE-5533 metrics (Revision 1344299) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/pom.xml /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/ExponentiallyDecayingSample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/MetricsHistogram.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Sample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/Snapshot.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/metrics/histogram/UniformSample.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/RegionServerMetrics.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java /hbase/trunk/pom.xml
      Hide
      stack added a comment -

      Committed to 0.94 and to trunk. Thanks Jeff and Ted for finding this copying.

      Show
      stack added a comment - Committed to 0.94 and to trunk. Thanks Jeff and Ted for finding this copying.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12530216/6131_094.txt
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2053//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530216/6131_094.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2053//console This message is automatically generated.
      Hide
      stack added a comment -

      Here is what I applied to 0.94 branch.

      Show
      stack added a comment - Here is what I applied to 0.94 branch.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12530161/6131.txt
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 6 new or modified tests.

      +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests:
      org.apache.hadoop.hbase.replication.TestReplication

      Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2049//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2049//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530161/6131.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2049//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2049//console This message is automatically generated.
      Hide
      stack added a comment -

      Add metrics-core to pom as Jeff suggests. Remove files copied from yammer metrics project.

      Show
      stack added a comment - Add metrics-core to pom as Jeff suggests. Remove files copied from yammer metrics project.
      Hide
      stack added a comment -

      That sounds better @Jeff. It looks to be up in maven: http://mvnrepository.com/artifact/com.yammer.metrics/metrics-core

      Show
      stack added a comment - That sounds better @Jeff. It looks to be up in maven: http://mvnrepository.com/artifact/com.yammer.metrics/metrics-core
      Hide
      Jeff Hodges added a comment -

      Consider just depending on metrics-core.

      Show
      Jeff Hodges added a comment - Consider just depending on metrics-core.

        People

        • Assignee:
          stack
          Reporter:
          stack
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development