HBase
  1. HBase
  2. HBASE-6120

Few logging improvements around enabling tables

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.95.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      assignment manager

      Description

      • Few log statements between Enable/Disable/Create table handler event classes have a typo with word "Attempting" (its misspelled "Attemping").
      • Even upon an enable operation's failure, the tailing message is a mere INFO with a state of 'false'. This isn't as visible as I'd like it to be when diagnosing logs for issues. I've put it in a proper if-else for this case.

        Activity

        Hide
        Harsh J added a comment -

        Patch that fixes both of those issues described in description.

        Show
        Harsh J added a comment - Patch that fixes both of those issues described in description.
        Hide
        stack added a comment -

        +1 on patch

        Show
        stack added a comment - +1 on patch
        Hide
        Harsh J added a comment -

        Fixed error in description: s/WARN/INFO

        Show
        Harsh J added a comment - Fixed error in description: s/WARN/INFO
        Hide
        stack added a comment -

        Applied to trunk. Thanks for the patch Harsh.

        Show
        stack added a comment - Applied to trunk. Thanks for the patch Harsh.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2958 (See https://builds.apache.org/job/HBase-TRUNK/2958/)
        HBASE-6120 Few logging improvements around enabling tables (Revision 1344476)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2958 (See https://builds.apache.org/job/HBase-TRUNK/2958/ ) HBASE-6120 Few logging improvements around enabling tables (Revision 1344476) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/)
        HBASE-6120 Few logging improvements around enabling tables (Revision 1344476)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #33 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/33/ ) HBASE-6120 Few logging improvements around enabling tables (Revision 1344476) Result = FAILURE stack : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/DisableTableHandler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development