[HBASE-6045] copytable: change --peer.adr to --peer.addr - ASF JIRA

Details

Type: Improvement
Status: Resolved
Priority: Trivial
Resolution: Won't Fix
Affects Version/s: None
Fix Version/s: None
Component/s: mapreduce
Labels:
None

Description

In discussion of ~~HBASE-6013~~ it was suggested that we change --peer.adr to the more english centric --peer.addr. We would keep the old value present in 0.90/0.92/0.94 and remove from 0.96/trunk.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

hbase-6045.patch

21/Aug/12 21:46

6 kB

stack
hbase-6045.patch

31/May/12 06:43

6 kB

stack
hbase-6045.patch

31/May/12 06:22

6 kB

stack
hbase-6045-94.patch

18/May/12 03:34

6 kB

Jonathan Hsieh
hbase-6045.patch

18/May/12 03:34

6 kB

Jonathan Hsieh

Activity

Descending order - Click to sort in ascending order

Andrew Purtell made changes - 08/Jun/14 22:34

Status	Open [ 1 ]	Resolved [ 5 ]
Assignee	Jonathan Hsieh [ jmhsieh ]
Resolution		Won't Fix [ 2 ]

Hide

Permalink

Andrew Purtell added a comment - 08/Jun/14 22:34

Stale issue. Reopen if still relevant.

Show

Andrew Purtell added a comment - 08/Jun/14 22:34 Stale issue. Reopen if still relevant.

Nick Dimiduk made changes - 02/Apr/13 23:28

Component/s

mapreduce [ 12313047 ]

stack made changes - 21/Aug/12 21:46

Attachment

hbase-6045.patch [ 12541812 ]

Hide

Permalink

stack added a comment - 21/Aug/12 21:46

Retry

Show

stack added a comment - 21/Aug/12 21:46 Retry

stack made changes - 21/Aug/12 21:45

Status

Patch Available [ 10002 ]

Open [ 1 ]

Hide

Permalink

Hadoop QA added a comment - 31/May/12 07:33

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530334/hbase-6045.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.master.TestSplitLogManager
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//console

This message is automatically generated.

Show

Hadoop QA added a comment - 31/May/12 07:33 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530334/hbase-6045.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.TestFullLogReconstruction org.apache.hadoop.hbase.master.TestSplitLogManager org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//console This message is automatically generated.

stack made changes - 31/May/12 06:43

Status

Open [ 1 ]

Patch Available [ 10002 ]

stack made changes - 31/May/12 06:43

Status

Patch Available [ 10002 ]

Open [ 1 ]

stack made changes - 31/May/12 06:43

Attachment

hbase-6045.patch [ 12530334 ]

Hide

Permalink

stack added a comment - 31/May/12 06:43

Update to work against modularized trunk

Show

stack added a comment - 31/May/12 06:43 Update to work against modularized trunk

Hide

Permalink

Hadoop QA added a comment - 31/May/12 06:32

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530332/hbase-6045.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 patch. The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2072//console

This message is automatically generated.

Show

Hadoop QA added a comment - 31/May/12 06:32 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530332/hbase-6045.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2072//console This message is automatically generated.

stack made changes - 31/May/12 06:22

Status

Open [ 1 ]

Patch Available [ 10002 ]

stack made changes - 31/May/12 06:22

Attachment

hbase-6045.patch [ 12530332 ]

Hide

Permalink

stack added a comment - 31/May/12 06:22

Try against hadoopqa

Show

stack added a comment - 31/May/12 06:22 Try against hadoopqa

Hide

Permalink

stack added a comment - 31/May/12 06:21

Show

stack added a comment - 31/May/12 06:21 +1

Jonathan Hsieh made changes - 18/May/12 03:34

Attachment		hbase-6045.patch [ 12527985 ]
Attachment		hbase-6045-94.patch [ 12527986 ]

Hide

Permalink

Jonathan Hsieh added a comment - 18/May/12 03:34 - edited

trunk versions removes --peer.adr and replaces with --dest.addr, 0.94 reversion emits deprecation warning.

Show

Jonathan Hsieh added a comment - 18/May/12 03:34 - edited trunk versions removes --peer.adr and replaces with --dest.addr, 0.94 reversion emits deprecation warning.

Hide

Permalink

Jonathan Hsieh added a comment - 18/May/12 03:05

Actually, while we are at it I think this should be changed to --dest.addr since it points to zk quorum of the destination ccluster where writes are go.

Show

Jonathan Hsieh added a comment - 18/May/12 03:05 Actually, while we are at it I think this should be changed to --dest.addr since it points to zk quorum of the destination ccluster where writes are go.

Jonathan Hsieh made changes - 18/May/12 02:58

Field	Original Value	New Value
Description	Is discussion of ~~HBASE-6013~~ it was suggested that we change --peer.adr to the more english centric --peer.addr. We would keep the old value present in 0.90/0.92/0.94 and remove from 0.96/trunk.	In discussion of ~~HBASE-6013~~ it was suggested that we change --peer.adr to the more english centric --peer.addr. We would keep the old value present in 0.90/0.92/0.94 and remove from 0.96/trunk.

Jonathan Hsieh created issue - 18/May/12 01:11

People

Assignee:

Unassigned

Reporter:

Jonathan Hsieh

Votes:

0 Vote for this issue

Watchers:

5 Start watching this issue

Dates

Created:

18/May/12 01:11

Updated:

08/Jun/14 22:34

Resolved:

08/Jun/14 22:34

Development

Agile

View on Board