HBase
  1. HBase
  2. HBASE-6045

copytable: change --peer.adr to --peer.addr

        Details

        • Type: Improvement Improvement
        • Status: Resolved
        • Priority: Trivial Trivial
        • Resolution: Won't Fix
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: mapreduce
        • Labels:
          None

          Description

          In discussion of HBASE-6013 it was suggested that we change --peer.adr to the more english centric --peer.addr. We would keep the old value present in 0.90/0.92/0.94 and remove from 0.96/trunk.

          1. Text File
            hbase-6045.patch
            6 kB
            stack
          2. Text File
            hbase-6045.patch
            6 kB
            stack
          3. Text File
            hbase-6045.patch
            6 kB
            stack
          4. Text File
            hbase-6045.patch
            6 kB
            Jonathan Hsieh
          5. Text File
            hbase-6045-94.patch
            6 kB
            Jonathan Hsieh

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Jonathan Hsieh added a comment -

            Actually, while we are at it I think this should be changed to --dest.addr since it points to zk quorum of the destination ccluster where writes are go.

            Show
            Jonathan Hsieh added a comment - Actually, while we are at it I think this should be changed to --dest.addr since it points to zk quorum of the destination ccluster where writes are go.
            Hide
            Permalink
            Jonathan Hsieh added a comment - - edited

            trunk versions removes --peer.adr and replaces with --dest.addr, 0.94 reversion emits deprecation warning.

            Show
            Jonathan Hsieh added a comment - - edited trunk versions removes --peer.adr and replaces with --dest.addr, 0.94 reversion emits deprecation warning.
            Hide
            Permalink
            stack added a comment -

            +1

            Show
            stack added a comment - +1
            Hide
            Permalink
            stack added a comment -

            Try against hadoopqa

            Show
            stack added a comment - Try against hadoopqa
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12530332/hbase-6045.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            -1 patch. The patch command could not apply the patch.

            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2072//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530332/hbase-6045.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2072//console This message is automatically generated.
            Hide
            Permalink
            stack added a comment -

            Update to work against modularized trunk

            Show
            stack added a comment - Update to work against modularized trunk
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12530334/hbase-6045.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these unit tests:
            org.apache.hadoop.hbase.coprocessor.TestMasterObserver
            org.apache.hadoop.hbase.TestFullLogReconstruction
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks

            Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12530334/hbase-6045.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.TestFullLogReconstruction org.apache.hadoop.hbase.master.TestSplitLogManager org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2073//console This message is automatically generated.
            Hide
            Permalink
            stack added a comment -

            Retry

            Show
            stack added a comment - Retry
            Hide
            Permalink
            Andrew Purtell added a comment -

            Stale issue. Reopen if still relevant.

            Show
            Andrew Purtell added a comment - Stale issue. Reopen if still relevant.

              People

              • Assignee:
                Unassigned
                Reporter:
                Jonathan Hsieh
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development