Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The version of SLF4J we bundle is now targeted to that required by the Hadoop version HBase has been compiled against.

      Description

      We need to upgrade slf4j to 1.6.1 since other hadoop components use 1.6.1 now.

        Activity

        Hide
        Andrew Purtell added a comment -

        I guess we need per build profile SLF4J version properties. If there are multiple versions of the SLF4J jar on the classpath, it looks bad, the shell dumps a warning about multiple bindings after the first command.

        Show
        Andrew Purtell added a comment - I guess we need per build profile SLF4J version properties. If there are multiple versions of the SLF4J jar on the classpath, it looks bad, the shell dumps a warning about multiple bindings after the first command.
        Hide
        Jimmy Xiang added a comment -

        Hadoop 1.0.2 uses 1.4.3 slf4j. Others use 1.6.1.

        Show
        Jimmy Xiang added a comment - Hadoop 1.0.2 uses 1.4.3 slf4j. Others use 1.6.1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12527521/hbase-6001.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestClassLoading
        org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527521/hbase-6001.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1878//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -

        @Andrew, is the patch good to you? I tried mvn -DskipTest clean package with different hadoop profile and got right slf4j jar used.
        Unit tests seem to be fine for different profile too (I tried 1.0.2 the default, and 0.23).

        Show
        Jimmy Xiang added a comment - @Andrew, is the patch good to you? I tried mvn -DskipTest clean package with different hadoop profile and got right slf4j jar used. Unit tests seem to be fine for different profile too (I tried 1.0.2 the default, and 0.23).
        Hide
        Andrew Purtell added a comment -

        +1 Jimmy, thanks.

        Show
        Andrew Purtell added a comment - +1 Jimmy, thanks.
        Hide
        Jonathan Hsieh added a comment -

        +1. Andrew, do you want to commit or shall I? (I'd plan on doing 0.92/0.94/trunk.)

        Show
        Jonathan Hsieh added a comment - +1. Andrew, do you want to commit or shall I? (I'd plan on doing 0.92/0.94/trunk.)
        Hide
        Andrew Purtell added a comment -

        I'll take care of this tomorrow morning if you haven't gotten to it first.

        Show
        Andrew Purtell added a comment - I'll take care of this tomorrow morning if you haven't gotten to it first.
        Hide
        Andrew Purtell added a comment -

        Committed to trunk, 0.94, and 0.92 branches. Thanks Jimmy!

        Show
        Andrew Purtell added a comment - Committed to trunk, 0.94, and 0.92 branches. Thanks Jimmy!
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2892 (See https://builds.apache.org/job/HBase-TRUNK/2892/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339788)

        Result = SUCCESS
        apurtell :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2892 (See https://builds.apache.org/job/HBase-TRUNK/2892/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339788) Result = SUCCESS apurtell : Files : /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #194 (See https://builds.apache.org/job/HBase-0.94/194/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339790)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.94/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94 #194 (See https://builds.apache.org/job/HBase-0.94/194/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339790) Result = FAILURE apurtell : Files : /hbase/branches/0.94/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #408 (See https://builds.apache.org/job/HBase-0.92/408/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (update CHANGES.txt) (Revision 1339797)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339793)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.92/CHANGES.txt

        apurtell :
        Files :

        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92 #408 (See https://builds.apache.org/job/HBase-0.92/408/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (update CHANGES.txt) (Revision 1339797) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339793) Result = FAILURE apurtell : Files : /hbase/branches/0.92/CHANGES.txt apurtell : Files : /hbase/branches/0.92/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339788)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339788) Result = FAILURE apurtell : Files : /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #107 (See https://builds.apache.org/job/HBase-0.92-security/107/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (update CHANGES.txt) (Revision 1339797)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339793)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.92/CHANGES.txt

        apurtell :
        Files :

        • /hbase/branches/0.92/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #107 (See https://builds.apache.org/job/HBase-0.92-security/107/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (update CHANGES.txt) (Revision 1339797) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339793) Result = FAILURE apurtell : Files : /hbase/branches/0.92/CHANGES.txt apurtell : Files : /hbase/branches/0.92/pom.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #27 (See https://builds.apache.org/job/HBase-0.94-security/27/)
        HBASE-6001. Upgrade slf4j to 1.6.1 (Revision 1339790)

        Result = SUCCESS
        apurtell :
        Files :

        • /hbase/branches/0.94/pom.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #27 (See https://builds.apache.org/job/HBase-0.94-security/27/ ) HBASE-6001 . Upgrade slf4j to 1.6.1 (Revision 1339790) Result = SUCCESS apurtell : Files : /hbase/branches/0.94/pom.xml
        Hide
        rajeshbabu added a comment -

        Sorry,unknowingly assignee changed. assigned back to Jimmy.

        Show
        rajeshbabu added a comment - Sorry,unknowingly assignee changed. assigned back to Jimmy.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development