Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: Client, test
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      Running org.apache.hadoop.hbase.client.TestHCM
      Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.742 sec <<< FAILURE!

      Failed tests: testRegionCaching(org.apache.hadoop.hbase.client.TestHCM)

      1. hbase-5990.patch
        0.8 kB
        Jimmy Xiang
      2. hbase_5990_v2.patch
        1 kB
        Jimmy Xiang

        Activity

        Hide
        Jimmy Xiang added a comment -

        It is more than a test issue actually. The region cache is really affected.

        Show
        Jimmy Xiang added a comment - It is more than a test issue actually. The region cache is really affected.
        Hide
        stack added a comment -

        @Jimmy How is the '\n' getting inserted? I see we create RegionMovedException like this:

        throw new RegionMovedException(sn.getHostname(), sn.getPort());

        Is the servername parse bad or something such that its prepending a '\n'?

        Show
        stack added a comment - @Jimmy How is the '\n' getting inserted? I see we create RegionMovedException like this: throw new RegionMovedException(sn.getHostname(), sn.getPort()); Is the servername parse bad or something such that its prepending a '\n'?
        Hide
        Jimmy Xiang added a comment -

        Hadoop RemoteException is changed. It used to pass in the first line of the error message. Now it passes in
        the whole page of detailed error message. That's why we need the newline there. It is not related to servername parsing.

        Show
        Jimmy Xiang added a comment - Hadoop RemoteException is changed. It used to pass in the first line of the error message. Now it passes in the whole page of detailed error message. That's why we need the newline there. It is not related to servername parsing.
        Hide
        Jimmy Xiang added a comment -

        The exception is stringfied over RPC. In the client side, new RegionMovedException(String) is used.
        The issue is related to the string passed in.

        Show
        Jimmy Xiang added a comment - The exception is stringfied over RPC. In the client side, new RegionMovedException(String) is used. The issue is related to the string passed in.
        Hide
        stack added a comment -

        Should we have a regex in there instead? One that is fine w/ a space or '\n' or whatever else kinda whitespace we are thrown?

        Show
        stack added a comment - Should we have a regex in there instead? One that is fine w/ a space or '\n' or whatever else kinda whitespace we are thrown?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526562/hbase-5990.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.TestDrainingServer

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526562/hbase-5990.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestDrainingServer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1850//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -

        I think '\n' is fine. Basically, the parsing should match the string returned as getMessage() call.
        We don't return a space at the end.

        Show
        Jimmy Xiang added a comment - I think '\n' is fine. Basically, the parsing should match the string returned as getMessage() call. We don't return a space at the end.
        Hide
        Jimmy Xiang added a comment -

        The issue with '\n' is that I haven't tried it on windows. What do you think? Go with regex?

        Show
        Jimmy Xiang added a comment - The issue with '\n' is that I haven't tried it on windows. What do you think? Go with regex?
        Hide
        stack added a comment -

        Regex would be less likely to break later on whether different hadoops or platforms? What you think?

        Show
        stack added a comment - Regex would be less likely to break later on whether different hadoops or platforms? What you think?
        Hide
        Jimmy Xiang added a comment -

        How about patch 2? I added a "." to the end of the message. So we are sure how to parse it no matter how hadoop/platform changes.

        Show
        Jimmy Xiang added a comment - How about patch 2? I added a "." to the end of the message. So we are sure how to parse it no matter how hadoop/platform changes.
        Hide
        Jimmy Xiang added a comment -

        It is not backward compatible. Fortunately, 0.96 is a singularity.

        Show
        Jimmy Xiang added a comment - It is not backward compatible. Fortunately, 0.96 is a singularity.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526645/hbase_5990_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestSplitLogManager

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526645/hbase_5990_v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1862//console This message is automatically generated.
        Hide
        stack added a comment -

        Lets try it. Applied to TRUNK. Thanks for the patch Jimmy

        Show
        stack added a comment - Lets try it. Applied to TRUNK. Thanks for the patch Jimmy
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2882 (See https://builds.apache.org/job/HBase-TRUNK/2882/)
        HBASE-5990 TestHCM failed with Hadoop 2.0.0 (Revision 1337695)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/RegionMovedException.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2882 (See https://builds.apache.org/job/HBase-TRUNK/2882/ ) HBASE-5990 TestHCM failed with Hadoop 2.0.0 (Revision 1337695) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/RegionMovedException.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #3 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/3/)
        HBASE-5990 TestHCM failed with Hadoop 2.0.0 (Revision 1337695)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/RegionMovedException.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #3 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/3/ ) HBASE-5990 TestHCM failed with Hadoop 2.0.0 (Revision 1337695) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/RegionMovedException.java
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development