HBase
  1. HBase
  2. HBASE-5957

Mismatch with config param name in xml and code

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In hbase-default.xml there listed one param "io.storefile.bloom.cacheonwrite"

      <property>
        <name>io.storefile.bloom.cacheonwrite</name>
        <value>false</value>
        <description>
      	  Enables cache-on-write for inline blocks of a compound Bloom filter.
        </description>
      </property>
      

      No place in the code this config is getting used.
      Instead in CacheConfig there is a config param name

      /**
         * Configuration key to cache compound bloom filter blocks on write.
         */
        public static final String CACHE_BLOOM_BLOCKS_ON_WRITE_KEY =
            "hfile.block.bloom.cacheonwrite";
      

      Seems issue with entry in the xml file.
      We can correct the xml with the config name as hfile.block.bloom.cacheonwrite ?

      1. HBASE-5957.patch
        0.5 kB
        Anoop Sam John

        Activity

        Hide
        Ted Yu added a comment -

        +1 on correcting entry in xml.

        Show
        Ted Yu added a comment - +1 on correcting entry in xml.
        Hide
        Anoop Sam John added a comment -

        Patch for trunk.

        Show
        Anoop Sam John added a comment - Patch for trunk.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526009/HBASE-5957.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.wal.TestHLog

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526009/HBASE-5957.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestHLog Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1798//console This message is automatically generated.
        Hide
        Anoop Sam John added a comment -

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        Change is wrt correcting the xml entry in the hbase-default.xml

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.wal.TestHLog

        Patch has nothing to do with HLog. Failure is not related to this patch I think. Run tests in TestHLog locally and all passed

        Show
        Anoop Sam John added a comment - -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. Change is wrt correcting the xml entry in the hbase-default.xml -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestHLog Patch has nothing to do with HLog. Failure is not related to this patch I think. Run tests in TestHLog locally and all passed
        Hide
        ramkrishna.s.vasudevan added a comment -

        +1 on patch. Will commit it today.

        Show
        ramkrishna.s.vasudevan added a comment - +1 on patch. Will commit it today.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk.
        Thanks for the patch Anoop and for the review Stack.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk. Thanks for the patch Anoop and for the review Stack.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #4 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/4/)
        HBASE-5957 Mismatch with config param name in xml and code (Anoop) (Revision 1338307)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/trunk/src/main/resources/hbase-default.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #4 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/4/ ) HBASE-5957 Mismatch with config param name in xml and code (Anoop) (Revision 1338307) Result = FAILURE ramkrishna : Files : /hbase/trunk/src/main/resources/hbase-default.xml

          People

          • Assignee:
            Anoop Sam John
            Reporter:
            Anoop Sam John
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development