HBase
  1. HBase
  2. HBASE-5952

Sync hardcoded default flush size and max file size with hbase-default.xml

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.92.2
    • Fix Version/s: 0.92.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since the hardcoded default flush size is 64MB, but the default in hbase-default.xml is 128MB, if the client does set it to 64MB,
      the actual flush size will be 128MB instead, due to the way HRegion get the flush size. We can change how HRegion get the flush size,
      but it is clean and simple to sync up the defaults.

        Activity

        Hide
        Jimmy Xiang added a comment -

        @Stack, thanks for review and commit it.

        Show
        Jimmy Xiang added a comment - @Stack, thanks for review and commit it.
        Hide
        Jimmy Xiang added a comment -

        @Ted, this patch is just for 0.92. Trunk and 0.94 don't have this problem.
        This patch applies well for me on my 0.92 branch. Probably git is out of sync with svn again.

        Show
        Jimmy Xiang added a comment - @Ted, this patch is just for 0.92. Trunk and 0.94 don't have this problem. This patch applies well for me on my 0.92 branch. Probably git is out of sync with svn again.
        Hide
        stack added a comment -

        Committed to 0.92 branch. Thanks for the patch Jimmy.

        Show
        stack added a comment - Committed to 0.92 branch. Thanks for the patch Jimmy.
        Hide
        Ted Yu added a comment -

        Patch makes sense.

        There was a conflict in HTableDescriptor.java:

        ***************
        *** 164,170 ****
             * Constant that denotes the maximum default size of the memstore after which
             * the contents are flushed to the store files
             */
        -   public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*64L;
        
            private volatile Boolean meta = null;
            private volatile Boolean root = null;
        --- 164,170 ----
             * Constant that denotes the maximum default size of the memstore after which
             * the contents are flushed to the store files
             */
        +   public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*128L;
        
            private volatile Boolean meta = null;
            private volatile Boolean root = null;
        
        Show
        Ted Yu added a comment - Patch makes sense. There was a conflict in HTableDescriptor.java: *************** *** 164,170 **** * Constant that denotes the maximum default size of the memstore after which * the contents are flushed to the store files */ - public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*64L; private volatile Boolean meta = null ; private volatile Boolean root = null ; --- 164,170 ---- * Constant that denotes the maximum default size of the memstore after which * the contents are flushed to the store files */ + public static final long DEFAULT_MEMSTORE_FLUSH_SIZE = 1024*1024*128L; private volatile Boolean meta = null ; private volatile Boolean root = null ;
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525920/hbase-5952.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1792//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525920/hbase-5952.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1792//console This message is automatically generated.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development