Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5945

Reduce buffer copies in IPC server response path

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.95.2
    • 0.98.0, 0.96.1
    • IPC/RPC
    • None
    • Reviewed

    Description

      The new PB code is sloppy with buffers and makes several needless copies. This increases GC time a lot. A few simple changes can cut this back down.

      Attachments

        1. 5945-in-progress.2.1.patch
          136 kB
          Devaraj Das
        2. 5945-in-progress.2.patch
          144 kB
          Devaraj Das
        3. 5945-in-progress.patch
          101 kB
          Devaraj Das
        4. 5945v2.txt
          23 kB
          Michael Stack
        5. 5945v4.txt
          27 kB
          Michael Stack
        6. 5945v4.txt
          27 kB
          Michael Stack
        7. 5945v5.txt
          45 kB
          Michael Stack
        8. buffer-copies.txt
          2 kB
          Todd Lipcon
        9. even-fewer-copies.txt
          17 kB
          Todd Lipcon
        10. hbase-5495.txt
          24 kB
          Todd Lipcon
        11. with_patch.png
          386 kB
          Michael Stack
        12. without_patch.png
          384 kB
          Michael Stack

        Issue Links

          is related to

          Umbrella - An overarching type made of sub-tasks HBASE-10002 Improve buffer copies in write path continued

          • Major - Major loss of function.
          • Closed

          Activity

            People

              stack Michael Stack
              tlipcon Todd Lipcon
              Votes:
              0 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: