HBase
  1. HBase
  2. HBASE-5942

HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.92.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HConnnectionManager.getRegionServerWithRetries:

                return callable.call();
              } catch (Throwable t) {
                callable.shouldRetry(t);
      

      shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().

      1. hbase-5942.patch
        1 kB
        ramkrishna.s.vasudevan

        Activity

        Lars Francke made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ted Yu made changes -
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.92.2 [ 12319888 ]
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee ramkrishna.s.vasudevan [ ram_krish ]
        ramkrishna.s.vasudevan made changes -
        Field Original Value New Value
        Attachment hbase-5942.patch [ 12525951 ]
        Ted Yu created issue -

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development