Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5942

HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.92.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HConnnectionManager.getRegionServerWithRetries:

                return callable.call();
              } catch (Throwable t) {
                callable.shouldRetry(t);
      

      shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().

        Attachments

        1. hbase-5942.patch
          1 kB
          ramkrishna.s.vasudevan

          Activity

            People

            • Assignee:
              ram_krish ramkrishna.s.vasudevan
              Reporter:
              zhihyu@ebaysf.com Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: