HBase
  1. HBase
  2. HBASE-5942

HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.92.2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HConnnectionManager.getRegionServerWithRetries:

                return callable.call();
              } catch (Throwable t) {
                callable.shouldRetry(t);
      

      shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().

      1. hbase-5942.patch
        1 kB
        ramkrishna.s.vasudevan

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #107 (See https://builds.apache.org/job/HBase-0.92-security/107/)
        HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #107 (See https://builds.apache.org/job/HBase-0.92-security/107/ ) HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #402 (See https://builds.apache.org/job/HBase-0.92/402/)
        HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #402 (See https://builds.apache.org/job/HBase-0.92/402/ ) HBASE-5942 HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly (Revision 1335734) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        Hide
        stack added a comment -

        Committed to 0.92 (thanks for pointer Ted). Thanks for patch Ram.

        Show
        stack added a comment - Committed to 0.92 (thanks for pointer Ted). Thanks for patch Ram.
        Hide
        Ted Yu added a comment -

        This issue is for 0.92 branch only.

        Show
        Ted Yu added a comment - This issue is for 0.92 branch only.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525951/hbase-5942.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1800//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525951/hbase-5942.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1800//console This message is automatically generated.
        Hide
        stack added a comment -

        lgtm

        Trying against hadoopqa

        Show
        stack added a comment - lgtm Trying against hadoopqa
        Hide
        ramkrishna.s.vasudevan added a comment - - edited

        The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.

        {edit}
        Please review. Applies to 0.92.{edit}
        Show
        ramkrishna.s.vasudevan added a comment - - edited The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now. {edit} Please review. Applies to 0.92.{edit}

          People

          • Assignee:
            ramkrishna.s.vasudevan
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development