[HBASE-5942] HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.92.1
• Fix Version/s: 0.92.2
• Hadoop Flags: Reviewed
• Assignee: ramkrishna.s.vasudevan
• Reporter: Ted Yu
• Created: 04/May/12 20:25
• Updated: 20/Nov/15 11:55
• Resolved: 08/May/12 20:10

Description

HConnnectionManager.getRegionServerWithRetries:

          return callable.call();
        } catch (Throwable t) {
          callable.shouldRetry(t);

shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().