HBase
  1. HBase
  2. HBASE-5935

Add Region-level PB-based calls to HMasterInterface

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: IPC/RPC, master, migration
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).

      This is for converting the region-level calls, i.e.:
      moveRegion
      assignRegion
      unassignRegion

      1. HBASE-5935-v3.patch
        158 kB
        Gregory Chanan
      2. HBASE-5935-v2.patch
        158 kB
        Gregory Chanan
      3. HBASE-5935-v2.patch
        158 kB
        Gregory Chanan

        Issue Links

          Activity

          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #7 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/7/)
          HBASE-5935 Add Region-level PB-based calls to HMasterInterface (Revision 1339488)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
          • /hbase/trunk/src/main/protobuf/RegionServerStatus.proto
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #7 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/7/ ) HBASE-5935 Add Region-level PB-based calls to HMasterInterface (Revision 1339488) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java /hbase/trunk/src/main/protobuf/RegionServerStatus.proto /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2889 (See https://builds.apache.org/job/HBase-TRUNK/2889/)
          HBASE-5935 Add Region-level PB-based calls to HMasterInterface (Revision 1339488)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
          • /hbase/trunk/src/main/protobuf/RegionServerStatus.proto
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2889 (See https://builds.apache.org/job/HBase-TRUNK/2889/ ) HBASE-5935 Add Region-level PB-based calls to HMasterInterface (Revision 1339488) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java /hbase/trunk/src/main/protobuf/RegionServerStatus.proto /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
          Hide
          stack added a comment -

          Committed to TRUNK. Thanks for the patch Gregory.

          Show
          stack added a comment - Committed to TRUNK. Thanks for the patch Gregory.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12527495/HBASE-5935-v3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527495/HBASE-5935-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1875//console This message is automatically generated.
          Hide
          Gregory Chanan added a comment -

          Patch for latest version of trunk.

          Show
          Gregory Chanan added a comment - Patch for latest version of trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526792/HBASE-5935-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1866//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526792/HBASE-5935-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1866//console This message is automatically generated.
          Hide
          Gregory Chanan added a comment -

          Posting patch again to make sure it still passes unit tests.

          Show
          Gregory Chanan added a comment - Posting patch again to make sure it still passes unit tests.
          Hide
          Gregory Chanan added a comment -

          @Stack: Patch that matches reviewboard was posted and passed Haddop QA.

          Show
          Gregory Chanan added a comment - @Stack: Patch that matches reviewboard was posted and passed Haddop QA.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/#review7709
          -----------------------------------------------------------

          Ship it!

          +1 Put the patch up in JIRA so we can run it by hadoopqa. Good stuff G.

          • Michael

          On 2012-05-08 22:49:04, Gregory Chanan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5060/

          -----------------------------------------------------------

          (Updated 2012-05-08 22:49:04)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary

          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.

          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119

          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1

          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

          src/main/protobuf/Master.proto PRE-CREATION

          src/main/protobuf/RegionServerStatus.proto 9d7728f

          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing

          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/#review7709 ----------------------------------------------------------- Ship it! +1 Put the patch up in JIRA so we can run it by hadoopqa. Good stuff G. Michael On 2012-05-08 22:49:04, Gregory Chanan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 22:49:04) Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs ----- src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java, line 285

          > <https://reviews.apache.org/r/5060/diff/2/?file=107650#file107650line285>

          >

          > It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface.

          >

          > HMasterInterface is going to go away?

          Gregory Chanan wrote:

          I'm not sure what you mean by "having to hoist all these pb classes up in here AND into HMasterInterface." – this is HMasterInterface?

          Also, I don't think PB will be nice and generated usable javadoc for you, so I'm not sure how to provide javadoc comments without redeclaring the functions? I admit to being completely ignorant about this area.

          Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?

          I was just saying that we have generated pb pollution in both the Interface and in the Implementation, but its unavoidable really.

          You can't have pb do javadoc (is my understanding) so don't worry about it (Not sure what I suggested but it doesn't seem important now)

          Lets do what Jimmy did, make a new class and kill the old.

          • Michael

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/#review7667
          -----------------------------------------------------------

          On 2012-05-08 22:49:04, Gregory Chanan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5060/

          -----------------------------------------------------------

          (Updated 2012-05-08 22:49:04)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary

          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.

          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119

          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1

          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

          src/main/protobuf/Master.proto PRE-CREATION

          src/main/protobuf/RegionServerStatus.proto 9d7728f

          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing

          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java, line 285 > < https://reviews.apache.org/r/5060/diff/2/?file=107650#file107650line285 > > > It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface. > > HMasterInterface is going to go away? Gregory Chanan wrote: I'm not sure what you mean by "having to hoist all these pb classes up in here AND into HMasterInterface." – this is HMasterInterface? Also, I don't think PB will be nice and generated usable javadoc for you, so I'm not sure how to provide javadoc comments without redeclaring the functions? I admit to being completely ignorant about this area. Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference? I was just saying that we have generated pb pollution in both the Interface and in the Implementation, but its unavoidable really. You can't have pb do javadoc (is my understanding) so don't worry about it (Not sure what I suggested but it doesn't seem important now) Lets do what Jimmy did, make a new class and kill the old. Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/#review7667 ----------------------------------------------------------- On 2012-05-08 22:49:04, Gregory Chanan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 22:49:04) Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs ----- src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12526063/HBASE-5935-v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526063/HBASE-5935-v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1803//console This message is automatically generated.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/
          -----------------------------------------------------------

          (Updated 2012-05-08 22:49:04.533210)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Changes
          -------

          Updated for Jimmy's and stack's comments.

          Summary
          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.
          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f
          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547
          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119
          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1
          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION
          src/main/protobuf/Master.proto PRE-CREATION
          src/main/protobuf/RegionServerStatus.proto 9d7728f
          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing
          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 22:49:04.533210) Review request for hbase, Michael Stack and Jimmy Xiang. Changes ------- Updated for Jimmy's and stack's comments. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs (updated) src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > Looks good. Some small potatoes below. On this, "I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?" ... when will HMasterInterface go away? What else all is to be done? Sure on bump the version number. Pretty soon they'll be ignored so no harm using up a few. Good stuff G.

          Cool, I'll bump the version number for now.

          I believe I've answered all your questions below. Let me know if I missed anything.

          Thanks for the review.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1213

          > <https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1213>

          >

          > FYI, spaces between if and open paren... and usually around operators. Just FYI.

          Thanks, will do.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line 1394

          > <https://reviews.apache.org/r/5060/diff/2/?file=107649#file107649line1394>

          >

          > Is it right catching this here? You seem to handle it at a higher level up in the move invocation? Won't this clause catch all the possible SEs?

          >

          > Or I'm suffering myopia and there is more going on than just this call invocation?

          Good point, I can catch at a higher level.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1219

          > <https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1219>

          >

          > This needs paren (though its in the original)

          Will do.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/protobuf/Master.proto, line 71

          > <https://reviews.apache.org/r/5060/diff/2/?file=107654#file107654line71>

          >

          > Great. Is this all that is in the master interface?

          No, the rest of the functions in HMasterInterface need to be converted. This is the region-level stuff, I still have column-level, table-level and miscellaneous stuff to do. I've filed a JIRA for the column-level stuff; I'll file JIRAs for the others once I figure out how I'm going to break down the work.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1253

          > <https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1253>

          >

          > All IOEs now need to get converted to a SE? I added an HBaseException recently. Its a checked exception. Should we have an HBaseServiceExceptoin? SE is pb?

          ServiceException is coming from pb, that's right. So when we either get rid of HMasterInterface or repurpose it, the interface will define that we throw ServiceExceptions.

          On 2012-05-08 04:55:21, Michael Stack wrote:

          > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java, line 285

          > <https://reviews.apache.org/r/5060/diff/2/?file=107650#file107650line285>

          >

          > It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface.

          >

          > HMasterInterface is going to go away?

          I'm not sure what you mean by "having to hoist all these pb classes up in here AND into HMasterInterface." – this is HMasterInterface?

          Also, I don't think PB will be nice and generated usable javadoc for you, so I'm not sure how to provide javadoc comments without redeclaring the functions? I admit to being completely ignorant about this area.

          Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference?

          • Gregory

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/#review7667
          -----------------------------------------------------------

          On 2012-05-08 01:34:20, Gregory Chanan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5060/

          -----------------------------------------------------------

          (Updated 2012-05-08 01:34:20)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary

          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.

          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f

          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1

          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

          src/main/protobuf/Master.proto PRE-CREATION

          src/main/protobuf/RegionServerStatus.proto 9d7728f

          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing

          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-05-08 04:55:21, Michael Stack wrote: > Looks good. Some small potatoes below. On this, "I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?" ... when will HMasterInterface go away? What else all is to be done? Sure on bump the version number. Pretty soon they'll be ignored so no harm using up a few. Good stuff G. Cool, I'll bump the version number for now. I believe I've answered all your questions below. Let me know if I missed anything. Thanks for the review. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1213 > < https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1213 > > > FYI, spaces between if and open paren... and usually around operators. Just FYI. Thanks, will do. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java, line 1394 > < https://reviews.apache.org/r/5060/diff/2/?file=107649#file107649line1394 > > > Is it right catching this here? You seem to handle it at a higher level up in the move invocation? Won't this clause catch all the possible SEs? > > Or I'm suffering myopia and there is more going on than just this call invocation? Good point, I can catch at a higher level. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1219 > < https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1219 > > > This needs paren (though its in the original) Will do. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/protobuf/Master.proto, line 71 > < https://reviews.apache.org/r/5060/diff/2/?file=107654#file107654line71 > > > Great. Is this all that is in the master interface? No, the rest of the functions in HMasterInterface need to be converted. This is the region-level stuff, I still have column-level, table-level and miscellaneous stuff to do. I've filed a JIRA for the column-level stuff; I'll file JIRAs for the others once I figure out how I'm going to break down the work. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/master/HMaster.java, line 1253 > < https://reviews.apache.org/r/5060/diff/2/?file=107651#file107651line1253 > > > All IOEs now need to get converted to a SE? I added an HBaseException recently. Its a checked exception. Should we have an HBaseServiceExceptoin? SE is pb? ServiceException is coming from pb, that's right. So when we either get rid of HMasterInterface or repurpose it, the interface will define that we throw ServiceExceptions. On 2012-05-08 04:55:21, Michael Stack wrote: > src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java, line 285 > < https://reviews.apache.org/r/5060/diff/2/?file=107650#file107650line285 > > > It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface. > > HMasterInterface is going to go away? I'm not sure what you mean by "having to hoist all these pb classes up in here AND into HMasterInterface." – this is HMasterInterface? Also, I don't think PB will be nice and generated usable javadoc for you, so I'm not sure how to provide javadoc comments without redeclaring the functions? I admit to being completely ignorant about this area. Once everything in HMasterInterface is converted to use PB, we can either declare a new class for the representation (similar to RegionServerStatusProtocol) or just re-purpose HMasterInterface for that. What is your preference? Gregory ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/#review7667 ----------------------------------------------------------- On 2012-05-08 01:34:20, Gregory Chanan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 01:34:20) Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs ----- src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/#review7667
          -----------------------------------------------------------

          Looks good. Some small potatoes below. On this, "I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?" ... when will HMasterInterface go away? What else all is to be done? Sure on bump the version number. Pretty soon they'll be ignored so no harm using up a few. Good stuff G.

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
          <https://reviews.apache.org/r/5060/#comment16879>

          Is it right catching this here? You seem to handle it at a higher level up in the move invocation? Won't this clause catch all the possible SEs?

          Or I'm suffering myopia and there is more going on than just this call invocation?

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          <https://reviews.apache.org/r/5060/#comment16885>

          OK. Not even deprecated. Just removed. Like Jimmy's remove of HRegionInterface and we can do this because these are internal APIs

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
          <https://reviews.apache.org/r/5060/#comment16880>

          It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface.

          HMasterInterface is going to go away?

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          <https://reviews.apache.org/r/5060/#comment16883>

          This seems like a big improvement, having an actual return.

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          <https://reviews.apache.org/r/5060/#comment16881>

          FYI, spaces between if and open paren... and usually around operators. Just FYI.

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          <https://reviews.apache.org/r/5060/#comment16882>

          This needs paren (though its in the original)

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java
          <https://reviews.apache.org/r/5060/#comment16884>

          All IOEs now need to get converted to a SE? I added an HBaseException recently. Its a checked exception. Should we have an HBaseServiceExceptoin? SE is pb?

          src/main/protobuf/Master.proto
          <https://reviews.apache.org/r/5060/#comment16886>

          Great. Is this all that is in the master interface?

          src/main/protobuf/RegionServerStatus.proto
          <https://reviews.apache.org/r/5060/#comment16887>

          Good

          • Michael

          On 2012-05-08 01:34:20, Gregory Chanan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5060/

          -----------------------------------------------------------

          (Updated 2012-05-08 01:34:20)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary

          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.

          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f

          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1

          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

          src/main/protobuf/Master.proto PRE-CREATION

          src/main/protobuf/RegionServerStatus.proto 9d7728f

          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing

          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/#review7667 ----------------------------------------------------------- Looks good. Some small potatoes below. On this, "I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?" ... when will HMasterInterface go away? What else all is to be done? Sure on bump the version number. Pretty soon they'll be ignored so no harm using up a few. Good stuff G. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java < https://reviews.apache.org/r/5060/#comment16879 > Is it right catching this here? You seem to handle it at a higher level up in the move invocation? Won't this clause catch all the possible SEs? Or I'm suffering myopia and there is more going on than just this call invocation? src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java < https://reviews.apache.org/r/5060/#comment16885 > OK. Not even deprecated. Just removed. Like Jimmy's remove of HRegionInterface and we can do this because these are internal APIs src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java < https://reviews.apache.org/r/5060/#comment16880 > It does seem a little messy having to hoist all these pb classes up in here AND into HMasterInterface. HMasterInterface is going to go away? src/main/java/org/apache/hadoop/hbase/master/HMaster.java < https://reviews.apache.org/r/5060/#comment16883 > This seems like a big improvement, having an actual return. src/main/java/org/apache/hadoop/hbase/master/HMaster.java < https://reviews.apache.org/r/5060/#comment16881 > FYI, spaces between if and open paren... and usually around operators. Just FYI. src/main/java/org/apache/hadoop/hbase/master/HMaster.java < https://reviews.apache.org/r/5060/#comment16882 > This needs paren (though its in the original) src/main/java/org/apache/hadoop/hbase/master/HMaster.java < https://reviews.apache.org/r/5060/#comment16884 > All IOEs now need to get converted to a SE? I added an HBaseException recently. Its a checked exception. Should we have an HBaseServiceExceptoin? SE is pb? src/main/protobuf/Master.proto < https://reviews.apache.org/r/5060/#comment16886 > Great. Is this all that is in the master interface? src/main/protobuf/RegionServerStatus.proto < https://reviews.apache.org/r/5060/#comment16887 > Good Michael On 2012-05-08 01:34:20, Gregory Chanan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 01:34:20) Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs ----- src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/#review7664
          -----------------------------------------------------------

          Looks good to me.

          src/main/protobuf/Master.proto
          <https://reviews.apache.org/r/5060/#comment16877>

          Probably we don't need to specify default = false here, right?

          • Jimmy

          On 2012-05-08 01:34:20, Gregory Chanan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5060/

          -----------------------------------------------------------

          (Updated 2012-05-08 01:34:20)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary

          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.

          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547

          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119

          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f

          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1

          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION

          src/main/protobuf/Master.proto PRE-CREATION

          src/main/protobuf/RegionServerStatus.proto 9d7728f

          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing

          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/#review7664 ----------------------------------------------------------- Looks good to me. src/main/protobuf/Master.proto < https://reviews.apache.org/r/5060/#comment16877 > Probably we don't need to specify default = false here, right? Jimmy On 2012-05-08 01:34:20, Gregory Chanan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 01:34:20) Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs ----- src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/
          -----------------------------------------------------------

          (Updated 2012-05-08 01:34:20.873632)

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Changes
          -------

          Update against newest trunk and added some additional error checking.

          Summary
          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.
          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547
          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119
          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f
          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1
          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION
          src/main/protobuf/Master.proto PRE-CREATION
          src/main/protobuf/RegionServerStatus.proto 9d7728f
          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc

          Diff: https://reviews.apache.org/r/5060/diff

          Testing
          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- (Updated 2012-05-08 01:34:20.873632) Review request for hbase, Michael Stack and Jimmy Xiang. Changes ------- Update against newest trunk and added some additional error checking. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs (updated) src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 5d4be3f src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java a5e03e1 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java e5de603 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 83297cc Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5060/
          -----------------------------------------------------------

          Review request for hbase, Michael Stack and Jimmy Xiang.

          Summary
          -------

          Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign).

          I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number?

          This addresses bug HBASE-5935.
          https://issues.apache.org/jira/browse/HBASE-5935

          Diffs


          src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java e3912c2
          src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547
          src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119
          src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java d1e0993
          src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION
          src/main/protobuf/Master.proto PRE-CREATION
          src/main/protobuf/RegionServerStatus.proto 9d7728f
          src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java a1992c3
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java bdec3ee

          Diff: https://reviews.apache.org/r/5060/diff

          Testing
          -------

          Thanks,

          Gregory

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5060/ ----------------------------------------------------------- Review request for hbase, Michael Stack and Jimmy Xiang. Summary ------- Converted all the region-level calls in HMasterInterface to use Protobufs (move, assign, unassign). I've put the new generated calls in HMasterInterface rather than a new class, because it is easier to have one class for now, until I convert everything. This will only be temporary, but let me know how you want to handle. Bump the version number? This addresses bug HBASE-5935 . https://issues.apache.org/jira/browse/HBASE-5935 Diffs src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java e3912c2 src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java ce81547 src/main/java/org/apache/hadoop/hbase/master/HMaster.java ccc7119 src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java d1e0993 src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java PRE-CREATION src/main/protobuf/Master.proto PRE-CREATION src/main/protobuf/RegionServerStatus.proto 9d7728f src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java a1992c3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java bdec3ee Diff: https://reviews.apache.org/r/5060/diff Testing ------- Thanks, Gregory

            People

            • Assignee:
              Gregory Chanan
              Reporter:
              Gregory Chanan
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development