HBase
  1. HBase
  2. HBASE-5919

Add fixes for Ted's review comments from HBASE-5869

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I missed addressing a few of Ted's comments on the end of my navigating HBASE-5869 commit. Fix here. Make it a blocker.

      1. 5919-v4.txt
        2 kB
        Ted Yu
      2. 5919-v2.txt
        2 kB
        Ted Yu
      3. 5919.txt
        2 kB
        stack

        Activity

        Ted Yu made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        stack made changes -
        Assignee Ted Yu [ yuzhihong@gmail.com ]
        Ted Yu made changes -
        Comment [ -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12525375/5919-v3.txt
          against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
                                Please justify why no new tests are needed for this patch.
                                Also please list what manual steps were performed to verify this patch.

            +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

             -1 core tests. The patch failed these unit tests:
             

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1735//console

        This message is automatically generated. ]
        Ted Yu made changes -
        Summary Add missing Ted review fixes for HBASE-5869 Add fixes for Ted's review comments from HBASE-5869
        Hadoop Flags Reviewed [ 10343 ]
        Ted Yu made changes -
        Attachment 5919-v3.txt [ 12525375 ]
        Ted Yu made changes -
        Attachment 5919-v4.txt [ 12525382 ]
        Ted Yu made changes -
        Attachment 5919-v3.txt [ 12525375 ]
        Ted Yu made changes -
        Attachment 5919-v2.txt [ 12525361 ]
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        stack made changes -
        Field Original Value New Value
        Attachment 5919.txt [ 12525356 ]
        stack created issue -

          People

          • Assignee:
            Ted Yu
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development