Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the master, we will do the full scan of META in some situations
      for example,
      1.master start up
      2.CatalogJanitor do the full scan per 5 mins
      3.ServerShutdownHandler, getServerUserRegions for dead server.

      For the online applications, we should try the best to reduce the process time of ServerShutdownHandler in the situation 3.
      However, we found MetaReader#getServerUserRegions take 14mins for 10w regions in our production environment.
      And it is caused by two reasons:
      The first, we don't use cache and get one row per next() when fully scan .META.
      The second, "hbase.ipc.client.tcpnodelay" is false as default, and in our environment it take 40ms for per next() (It is related to the length of row in the .META. , if someone also found, could try to set it true)

      For this issue, I think we could set the caching when do the full scan of META

      1. HBASE-5913.patch
        0.8 kB
        chunhui shen
      2. 5913-v2.txt
        0.8 kB
        Ted Yu

        Activity

        Hide
        Ted Yu added a comment -

        Patch looks good.

        Minor comment: can refer to HConstants.HBASE_META_SCANNER_CACHING

        Show
        Ted Yu added a comment - Patch looks good. Minor comment: can refer to HConstants.HBASE_META_SCANNER_CACHING
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525259/HBASE-5913.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525259/HBASE-5913.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1722//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Patch v2 plugs in HConstants.HBASE_META_SCANNER_CACHING

        Show
        Ted Yu added a comment - Patch v2 plugs in HConstants.HBASE_META_SCANNER_CACHING
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525310/5913-v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestClassLoading

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525310/5913-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestClassLoading Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1725//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        I looped TestClassLoading 5 times using patch v2 and they passed.

        Show
        Ted Yu added a comment - I looped TestClassLoading 5 times using patch v2 and they passed.
        Hide
        Ted Yu added a comment -

        I will integrate this tonight if there are no further review comments.

        Show
        Ted Yu added a comment - I will integrate this tonight if there are no further review comments.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525353/5913-v2.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525353/5913-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1729//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Integrated to trunk.

        Thanks for the patch, Chunhui.

        Show
        Ted Yu added a comment - Integrated to trunk. Thanks for the patch, Chunhui.
        Hide
        Lars Hofhansl added a comment -

        I'd like this in 0.94 as well.

        Show
        Lars Hofhansl added a comment - I'd like this in 0.94 as well.
        Hide
        Lars Hofhansl added a comment -

        Will commit to 0.94 tonight if there are no objections.

        Show
        Lars Hofhansl added a comment - Will commit to 0.94 tonight if there are no objections.
        Hide
        stack added a comment -

        +1 on patch

        Show
        stack added a comment - +1 on patch
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2840 (See https://builds.apache.org/job/HBase-TRUNK/2840/)
        HBASE-5913 Speed up the full scan of META (Chunhui) (Revision 1333283)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2840 (See https://builds.apache.org/job/HBase-TRUNK/2840/ ) HBASE-5913 Speed up the full scan of META (Chunhui) (Revision 1333283) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #190 (See https://builds.apache.org/job/HBase-TRUNK-security/190/)
        HBASE-5913 Speed up the full scan of META (Chunhui) (Revision 1333283)

        Result = SUCCESS
        tedyu :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #190 (See https://builds.apache.org/job/HBase-TRUNK-security/190/ ) HBASE-5913 Speed up the full scan of META (Chunhui) (Revision 1333283) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 as well.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 as well.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #174 (See https://builds.apache.org/job/HBase-0.94/174/)
        HBASE-5913 Speed up the full scan of META (Revision 1333315)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #174 (See https://builds.apache.org/job/HBase-0.94/174/ ) HBASE-5913 Speed up the full scan of META (Revision 1333315) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #26 (See https://builds.apache.org/job/HBase-0.94-security/26/)
        HBASE-5913 Speed up the full scan of META (Revision 1333315)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #26 (See https://builds.apache.org/job/HBase-0.94-security/26/ ) HBASE-5913 Speed up the full scan of META (Revision 1333315) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java

          People

          • Assignee:
            chunhui shen
            Reporter:
            chunhui shen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development