HBase
  1. HBase
  2. HBASE-5911

hbck need an option -help to printout usage

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.90.7
    • Fix Version/s: 0.90.7
    • Component/s: hbck
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hbck doesn't have an option to print out usage although we have this function. It is better to have it so that we don't need to remember them all, especially the list is keeping growing.

        Activity

        Hide
        stack added a comment -

        Applied to 0.90. Thanks for the patch Jimmy

        Show
        stack added a comment - Applied to 0.90. Thanks for the patch Jimmy
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525517/hbase_5911.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1752//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525517/hbase_5911.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1752//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -

        Copied the help option from trunk.

        Show
        Jimmy Xiang added a comment - Copied the help option from trunk.
        Hide
        Jimmy Xiang added a comment -

        You are right. I changed the affected version to 0.90.7

        Show
        Jimmy Xiang added a comment - You are right. I changed the affected version to 0.90.7
        Hide
        stack added a comment -

        We have this in trunk Jimmy...

            // Process command-line args.
            for (int i = 0; i < args.length; i++) {
              String cmd = args[i];
              if (cmd.equals("-help") || cmd.equals("-h")) {
                printUsageAndExit();
        ...
        
        Show
        stack added a comment - We have this in trunk Jimmy... // Process command-line args. for ( int i = 0; i < args.length; i++) { String cmd = args[i]; if (cmd.equals( "-help" ) || cmd.equals( "-h" )) { printUsageAndExit(); ...

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development