HBase
  1. HBase
  2. HBASE-5909

SlabStats should be a daemon thread

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None

      Description

      I had a hanging JVM on shutdown caused by:

      "Slab Statistics #0" prio=5 tid=7fc0238bc800 nid=0x10dadf000 waiting on condition [10dade000]
         java.lang.Thread.State: TIMED_WAITING (parking)
      
      1. 5909.txt
        0.9 kB
        Lars Hofhansl

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/)
        HBASE-5909 SlabStats should be a daemon thread (Revision 1357974)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security-on-Hadoop-23 #6 (See https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/6/ ) HBASE-5909 SlabStats should be a daemon thread (Revision 1357974) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #39 (See https://builds.apache.org/job/HBase-0.94-security/39/)
        HBASE-5909 SlabStats should be a daemon thread (Revision 1357974)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #39 (See https://builds.apache.org/job/HBase-0.94-security/39/ ) HBASE-5909 SlabStats should be a daemon thread (Revision 1357974) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #301 (See https://builds.apache.org/job/HBase-0.94/301/)
        HBASE-5909 SlabStats should be a daemon thread (Revision 1357974)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #301 (See https://builds.apache.org/job/HBase-0.94/301/ ) HBASE-5909 SlabStats should be a daemon thread (Revision 1357974) Result = FAILURE larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.94 and 0.96.

        Show
        Lars Hofhansl added a comment - Committed to 0.94 and 0.96.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Lars Hofhansl added a comment -

        Looks like this should not happen as long as the cache is itself is shut down appropriately (shutdown here also shuts down the thread pool).

        Anyway, this one-liner makes sure the statistics thread will be a daemon.

        Show
        Lars Hofhansl added a comment - Looks like this should not happen as long as the cache is itself is shut down appropriately (shutdown here also shuts down the thread pool). Anyway, this one-liner makes sure the statistics thread will be a daemon.

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development