HBase
  1. HBase
  2. HBASE-5908

TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: test, wal
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses fails against a version of hadoop with https://issues.apache.org/jira/browse/HADOOP-8230

      The failure:
      "java.io.IOException: Append is not supported. Please see the dfs.support.append configuration parameter."

      Instead of using append, we can probably just:

      • copy over the contents to a new file
      • append the garbage to the new file
      • copy back to the old file

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332493)

        Result = SUCCESS
        todd :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332493) Result = SUCCESS todd : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #25 (See https://builds.apache.org/job/HBase-0.94-security/25/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332494)

        Result = SUCCESS
        todd :
        Files :

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #25 (See https://builds.apache.org/job/HBase-0.94-security/25/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332494) Result = SUCCESS todd : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #188 (See https://builds.apache.org/job/HBase-TRUNK-security/188/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332495)

        Result = FAILURE
        todd :
        Files :

        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #188 (See https://builds.apache.org/job/HBase-TRUNK-security/188/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332495) Result = FAILURE todd : Files : /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #394 (See https://builds.apache.org/job/HBase-0.92/394/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332493)

        Result = SUCCESS
        todd :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #394 (See https://builds.apache.org/job/HBase-0.92/394/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332493) Result = SUCCESS todd : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #164 (See https://builds.apache.org/job/HBase-0.94/164/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332494)

        Result = FAILURE
        todd :
        Files :

        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #164 (See https://builds.apache.org/job/HBase-0.94/164/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332494) Result = FAILURE todd : Files : /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2830 (See https://builds.apache.org/job/HBase-TRUNK/2830/)
        HBASE-5908. TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332495)

        Result = FAILURE
        todd :
        Files :

        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2830 (See https://builds.apache.org/job/HBase-TRUNK/2830/ ) HBASE-5908 . TestHLogSplit.testTralingGarbageCorruptionFileSkipErrorsPasses should not use append to corrupt the HLog. Contributed by Gregory Chanan. (Revision 1332495) Result = FAILURE todd : Files : /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java
        Hide
        Todd Lipcon added a comment -

        I'll commit this momentarily to 0.90, 0.92, 0.94, and trunk (whew)

        Show
        Todd Lipcon added a comment - I'll commit this momentarily to 0.90, 0.92, 0.94, and trunk (whew)
        Hide
        Gregory Chanan added a comment -

        Those tests fail for me locally even without patch applied.

        Show
        Gregory Chanan added a comment - Those tests fail for me locally even without patch applied.
        Hide
        Gregory Chanan added a comment -

        @Ted:
        Good idea, I'll do that from now on.

        Show
        Gregory Chanan added a comment - @Ted: Good idea, I'll do that from now on.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525130/HBASE-5908-trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.client.TestShell
        org.apache.hadoop.hbase.master.TestAssignmentManager

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525130/HBASE-5908-trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestShell org.apache.hadoop.hbase.master.TestAssignmentManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1698//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        @Gregory:
        I would suggest referencing other JIRAs by their names only, such as HADOOP-8230.

        This way we would easily see whether the JIRA has been resolved.

        Show
        Ted Yu added a comment - @Gregory: I would suggest referencing other JIRAs by their names only, such as HADOOP-8230 . This way we would easily see whether the JIRA has been resolved.
        Hide
        Todd Lipcon added a comment -

        +1 pending Jenkins

        Show
        Todd Lipcon added a comment - +1 pending Jenkins

          People

          • Assignee:
            Gregory Chanan
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development