HBase
  1. HBase
  2. HBASE-5893

Allow spaces in coprocessor conf (aka trim() className)

    Details

    • Hadoop Flags:
      Reviewed

      Description

      This is annoying especially for coprocessors where you've long class name.
      but maybe is a bug of Configuration.getStrings() that doesn't trim each string.

      When you've comma separated values like in the coprocessors case, you've to pack together your values without spaces ("v1,v2,v3,...") otherwise the coprocessor is not loaded because the class name with spaces is not found.

      <property>
         <name>hbase.coprocessor.master.classes</name>
         <value>
          org.apache.hadoop.hbase.security.token.TokenProvider,
          org.apache.hadoop.hbase.security.access.AccessController
         </value>
      </property>
      
      1. HBASE-5893-v0.patch
        1 kB
        Matteo Bertozzi

        Activity

        Matteo Bertozzi created issue -
        Matteo Bertozzi made changes -
        Field Original Value New Value
        Attachment HBASE-5893-v0.patch [ 12524934 ]
        Matteo Bertozzi made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524934/HBASE-5893-v0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524934/HBASE-5893-v0.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1674//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to 0.92, 0.94, and trunk (Usability). Thanks for the patch Matteo.

        Show
        stack added a comment - Committed to 0.92, 0.94, and trunk (Usability). Thanks for the patch Matteo.
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.92.2 [ 12319888 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #153 (See https://builds.apache.org/job/HBase-0.94/153/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331639)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #153 (See https://builds.apache.org/job/HBase-0.94/153/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331639) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2823 (See https://builds.apache.org/job/HBase-TRUNK/2823/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331638)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2823 (See https://builds.apache.org/job/HBase-TRUNK/2823/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331638) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #187 (See https://builds.apache.org/job/HBase-TRUNK-security/187/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331638)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #187 (See https://builds.apache.org/job/HBase-TRUNK-security/187/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331638) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #392 (See https://builds.apache.org/job/HBase-0.92/392/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331641)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #392 (See https://builds.apache.org/job/HBase-0.92/392/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331641) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #24 (See https://builds.apache.org/job/HBase-0.94-security/24/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331639)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #24 (See https://builds.apache.org/job/HBase-0.94-security/24/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331639) Result = FAILURE stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/)
        HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331641)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/ ) HBASE-5893 Allow spaces in coprocessor conf (aka trim() className) (Revision 1331641) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Matteo Bertozzi
            Reporter:
            Matteo Bertozzi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development