HBase
  1. HBase
  2. HBASE-5879

Enable JMX metrics collection for the Thrift proxy

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None

      Description

      We need to enable JMX on the Thrift proxy on a separate port different from the JMX port used by regionserver. This is necessary for metrics collection.

      1. ASF.LICENSE.NOT.GRANTED--D2955.1.patch
        0.8 kB
        Phabricator
      2. 5879_trunk.txt
        0.7 kB
        stack

        Activity

        Mikhail Bautin created issue -
        Hide
        Phabricator added a comment -

        mbautin requested code review of "[jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy".
        Reviewers: Kannan, Liyin, sc, tedyu, JIRA

        We need to enable JMX on the Thrift proxy on a separate port different from the JMX port used by regionserver. This is necessary for metrics collection.

        TEST PLAN

        • Deploy to dev cluster.
        • Verify that it is possible to collect metrics through JMX from the Thrift proxy.

        REVISION DETAIL
        https://reviews.facebook.net/D2955

        AFFECTED FILES
        bin/hbase-config.sh

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/6735/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - mbautin requested code review of " [jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy". Reviewers: Kannan, Liyin, sc, tedyu, JIRA We need to enable JMX on the Thrift proxy on a separate port different from the JMX port used by regionserver. This is necessary for metrics collection. TEST PLAN Deploy to dev cluster. Verify that it is possible to collect metrics through JMX from the Thrift proxy. REVISION DETAIL https://reviews.facebook.net/D2955 AFFECTED FILES bin/hbase-config.sh MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/6735/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Phabricator made changes -
        Field Original Value New Value
        Attachment D2955.1.patch [ 12524477 ]
        Hide
        Phabricator added a comment -

        Kannan has accepted the revision "[jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy".

        REVISION DETAIL
        https://reviews.facebook.net/D2955

        BRANCH
        enable_jmx_metrics_collection_for_the_thrift_HBASE-5879

        Show
        Phabricator added a comment - Kannan has accepted the revision " [jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy". REVISION DETAIL https://reviews.facebook.net/D2955 BRANCH enable_jmx_metrics_collection_for_the_thrift_ HBASE-5879
        Hide
        Phabricator added a comment -

        stack has commented on the revision "[jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy".

        Mikhail, I should just apply this to trunk? It looks like it'd go in easy.

        REVISION DETAIL
        https://reviews.facebook.net/D2955

        BRANCH
        enable_jmx_metrics_collection_for_the_thrift_HBASE-5879

        Show
        Phabricator added a comment - stack has commented on the revision " [jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy". Mikhail, I should just apply this to trunk? It looks like it'd go in easy. REVISION DETAIL https://reviews.facebook.net/D2955 BRANCH enable_jmx_metrics_collection_for_the_thrift_ HBASE-5879
        Hide
        Phabricator added a comment -

        mbautin has commented on the revision "[jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy".

        Stack: please do, if you have time! Otherwise, I will port it later. Thanks!

        REVISION DETAIL
        https://reviews.facebook.net/D2955

        BRANCH
        enable_jmx_metrics_collection_for_the_thrift_HBASE-5879

        Show
        Phabricator added a comment - mbautin has commented on the revision " [jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy". Stack: please do, if you have time! Otherwise, I will port it later. Thanks! REVISION DETAIL https://reviews.facebook.net/D2955 BRANCH enable_jmx_metrics_collection_for_the_thrift_ HBASE-5879
        Hide
        stack added a comment -

        What I applied to trunk.

        Show
        stack added a comment - What I applied to trunk.
        stack made changes -
        Attachment 5879_trunk.txt [ 12525124 ]
        stack made changes -
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.89-fb [ 12320178 ]
        Hide
        stack added a comment -

        Removing 0.89fb as fix since it doesn't seem like its been applied there yet, only to apache trunk.

        Show
        stack added a comment - Removing 0.89fb as fix since it doesn't seem like its been applied there yet, only to apache trunk.
        stack made changes -
        Fix Version/s 0.89-fb [ 12320178 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2829 (See https://builds.apache.org/job/HBase-TRUNK/2829/)
        HBASE-5879 Enable JMX metrics collection for the Thrift proxy (Revision 1332450)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/bin/hbase-config.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2829 (See https://builds.apache.org/job/HBase-TRUNK/2829/ ) HBASE-5879 Enable JMX metrics collection for the Thrift proxy (Revision 1332450) Result = FAILURE stack : Files : /hbase/trunk/bin/hbase-config.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #188 (See https://builds.apache.org/job/HBase-TRUNK-security/188/)
        HBASE-5879 Enable JMX metrics collection for the Thrift proxy (Revision 1332450)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/bin/hbase-config.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #188 (See https://builds.apache.org/job/HBase-TRUNK-security/188/ ) HBASE-5879 Enable JMX metrics collection for the Thrift proxy (Revision 1332450) Result = FAILURE stack : Files : /hbase/trunk/bin/hbase-config.sh
        Hide
        Phabricator added a comment -

        mbautin has committed the revision "[jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy".

        REVISION DETAIL
        https://reviews.facebook.net/D2955

        COMMIT
        https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1333194

        Show
        Phabricator added a comment - mbautin has committed the revision " [jira] HBASE-5879 [89-fb] Enable JMX metrics collection for the Thrift proxy". REVISION DETAIL https://reviews.facebook.net/D2955 COMMIT https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1333194
        Mikhail Bautin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Mikhail Bautin [ mikhail ]
        Resolution Fixed [ 1 ]
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Fix Version/s 0.98.0 [ 12323143 ]
        stack made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        6d 21h 58m 1 Mikhail Bautin 02/May/12 22:39
        Resolved Resolved Closed Closed
        508d 21h 5m 1 stack 23/Sep/13 19:45

          People

          • Assignee:
            Mikhail Bautin
            Reporter:
            Mikhail Bautin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development