HBase
  1. HBase
  2. HBASE-5863

Improve the graceful_stop.sh CLI help (especially about reloads)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.92.2, 0.94.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Right now, graceful_stop.sh prints:

      Usage: graceful_stop.sh [--config <conf-dir>] [--restart] [--reload] [--thrift] [--rest] <hostname>
       thrift      If we should stop/start thrift before/after the hbase stop/start
       rest        If we should stop/start rest before/after the hbase stop/start
       restart     If we should restart after graceful stop
       reload      Move offloaded regions back on to the stopped server
       debug       Move offloaded regions back on to the stopped server
       hostname    Hostname of server we are to stop
      

      This does not help us specify that "reload" is actually a sub/additive-option to "restart".

      Also, the "debug" line seems to still have an old copy/paste mistake.

      I've updated these two in the patch here.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523940/HBASE-5863.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523940/HBASE-5863.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1625//console This message is automatically generated.
        Hide
        Sho Shimauchi added a comment -

        This patch changes only help messages in a shell script.
        New tests aren't needed for this patch.

        Show
        Sho Shimauchi added a comment - This patch changes only help messages in a shell script. New tests aren't needed for this patch.
        Hide
        stack added a comment -

        Committed to 0.92, 0.94 and trunk. Thanks for the patch Harsh.

        Show
        stack added a comment - Committed to 0.92, 0.94 and trunk. Thanks for the patch Harsh.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2806 (See https://builds.apache.org/job/HBase-TRUNK/2806/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329793)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2806 (See https://builds.apache.org/job/HBase-TRUNK/2806/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329793) Result = SUCCESS stack : Files : /hbase/trunk/bin/graceful_stop.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #143 (See https://builds.apache.org/job/HBase-0.94/143/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329794)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.94/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-0.94 #143 (See https://builds.apache.org/job/HBase-0.94/143/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329794) Result = FAILURE stack : Files : /hbase/branches/0.94/bin/graceful_stop.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #389 (See https://builds.apache.org/job/HBase-0.92/389/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329795)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-0.92 #389 (See https://builds.apache.org/job/HBase-0.92/389/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329795) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/bin/graceful_stop.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #20 (See https://builds.apache.org/job/HBase-0.94-security/20/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329794)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #20 (See https://builds.apache.org/job/HBase-0.94-security/20/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329794) Result = SUCCESS stack : Files : /hbase/branches/0.94/bin/graceful_stop.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #183 (See https://builds.apache.org/job/HBase-TRUNK-security/183/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329793)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #183 (See https://builds.apache.org/job/HBase-TRUNK-security/183/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329793) Result = FAILURE stack : Files : /hbase/trunk/bin/graceful_stop.sh
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/)
        HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329795)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/bin/graceful_stop.sh
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #106 (See https://builds.apache.org/job/HBase-0.92-security/106/ ) HBASE-5863 Improve the graceful_stop.sh CLI help (especially about reloads) (Revision 1329795) Result = SUCCESS stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/bin/graceful_stop.sh

          People

          • Assignee:
            Harsh J
            Reporter:
            Harsh J
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development