Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: hbck
    • Labels:
      None

      Description

      In the reviews for HBASE-5654, Jon said he'd take on fixing the hbck findbugs warnings.

        Activity

        Jonathan Hsieh created issue -
        Alex Newman made changes -
        Field Original Value New Value
        Summary [findbugs] Fix hbck findubugs warnings [findbugs] Fix hbck findbugs warnings
        Hide
        Alex Newman added a comment -

        I have a series of nit fixes around HbaseFsck.java can they go here?

        Show
        Alex Newman added a comment - I have a series of nit fixes around HbaseFsck.java can they go here?
        Hide
        Alex Newman added a comment -

        Well I guess it can't hurt to pass them back.

        Show
        Alex Newman added a comment - Well I guess it can't hurt to pass them back.
        Alex Newman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Alex Newman made changes -
        Attachment HBASE-5854-v1.patch [ 12656685 ]
        Hide
        Ted Yu added a comment -
            * Constructor
            *
        -   * @param conf
        -   *          Configuration object
        -   * @throws MasterNotRunningException
        -   *           if the master is not running
        -   * @throws ZooKeeperConnectionException
        -   *           if unable to connect to ZooKeeper
        +   * @param conf Configuration object
            */
        -  public HBaseFsck(Configuration conf, ExecutorService exec) throws MasterNotRunningException,
        -      ZooKeeperConnectionException, IOException, ClassNotFoundException {
        +  public HBaseFsck(Configuration conf, ExecutorService exec) {
        

        Where is the javadoc for exec parameter ?

        Show
        Ted Yu added a comment - * Constructor * - * @param conf - * Configuration object - * @ throws MasterNotRunningException - * if the master is not running - * @ throws ZooKeeperConnectionException - * if unable to connect to ZooKeeper + * @param conf Configuration object */ - public HBaseFsck(Configuration conf, ExecutorService exec) throws MasterNotRunningException, - ZooKeeperConnectionException, IOException, ClassNotFoundException { + public HBaseFsck(Configuration conf, ExecutorService exec) { Where is the javadoc for exec parameter ?
        Hide
        Alex Newman added a comment -

        Great catch Ted Yu ! It wasn't in the original but I didn't change. I agree, it would be clearer if it had one. I am curious if I am even cleaning the right file? Also, I am not sure whether or not it is proper to just jump on a jira like this. I don't wanna step on any toes, but I figure it has been around forever and I wanted to clean it up. I am not sure if I am even cleaning the correct file.

        Show
        Alex Newman added a comment - Great catch Ted Yu ! It wasn't in the original but I didn't change. I agree, it would be clearer if it had one. I am curious if I am even cleaning the right file? Also, I am not sure whether or not it is proper to just jump on a jira like this. I don't wanna step on any toes, but I figure it has been around forever and I wanted to clean it up. I am not sure if I am even cleaning the correct file.
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Jonathan Hsieh [ jmhsieh ]
        Resolution Not A Problem [ 8 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development