Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not A Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: hbck
    • Labels:
      None

      Description

      In the reviews for HBASE-5654, Jon said he'd take on fixing the hbck findbugs warnings.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        816d 16h 17m 1 Alex Newman 19/Jul/14 01:52
        Patch Available Patch Available Resolved Resolved
        266d 30m 1 Andrew Purtell 11/Apr/15 02:22
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Jonathan Hsieh [ jmhsieh ]
        Resolution Not A Problem [ 8 ]
        Hide
        Alex Newman added a comment -

        Great catch Ted Yu ! It wasn't in the original but I didn't change. I agree, it would be clearer if it had one. I am curious if I am even cleaning the right file? Also, I am not sure whether or not it is proper to just jump on a jira like this. I don't wanna step on any toes, but I figure it has been around forever and I wanted to clean it up. I am not sure if I am even cleaning the correct file.

        Show
        Alex Newman added a comment - Great catch Ted Yu ! It wasn't in the original but I didn't change. I agree, it would be clearer if it had one. I am curious if I am even cleaning the right file? Also, I am not sure whether or not it is proper to just jump on a jira like this. I don't wanna step on any toes, but I figure it has been around forever and I wanted to clean it up. I am not sure if I am even cleaning the correct file.
        Hide
        Ted Yu added a comment -
            * Constructor
            *
        -   * @param conf
        -   *          Configuration object
        -   * @throws MasterNotRunningException
        -   *           if the master is not running
        -   * @throws ZooKeeperConnectionException
        -   *           if unable to connect to ZooKeeper
        +   * @param conf Configuration object
            */
        -  public HBaseFsck(Configuration conf, ExecutorService exec) throws MasterNotRunningException,
        -      ZooKeeperConnectionException, IOException, ClassNotFoundException {
        +  public HBaseFsck(Configuration conf, ExecutorService exec) {
        

        Where is the javadoc for exec parameter ?

        Show
        Ted Yu added a comment - * Constructor * - * @param conf - * Configuration object - * @ throws MasterNotRunningException - * if the master is not running - * @ throws ZooKeeperConnectionException - * if unable to connect to ZooKeeper + * @param conf Configuration object */ - public HBaseFsck(Configuration conf, ExecutorService exec) throws MasterNotRunningException, - ZooKeeperConnectionException, IOException, ClassNotFoundException { + public HBaseFsck(Configuration conf, ExecutorService exec) { Where is the javadoc for exec parameter ?
        Alex Newman made changes -
        Attachment HBASE-5854-v1.patch [ 12656685 ]
        Alex Newman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Alex Newman added a comment -

        Well I guess it can't hurt to pass them back.

        Show
        Alex Newman added a comment - Well I guess it can't hurt to pass them back.
        Hide
        Alex Newman added a comment -

        I have a series of nit fixes around HbaseFsck.java can they go here?

        Show
        Alex Newman added a comment - I have a series of nit fixes around HbaseFsck.java can they go here?
        Alex Newman made changes -
        Field Original Value New Value
        Summary [findbugs] Fix hbck findubugs warnings [findbugs] Fix hbck findbugs warnings
        Jonathan Hsieh created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Jonathan Hsieh
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development