HBase
  1. HBase
  2. HBASE-5850

Refuse operations from Admin before master is initialized - fix for all branches.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.7, 0.92.2, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This issue is needed in 0.90 0.92 also.
      And update the hbase-5454 patch that add the checkInitialized() into HMaster#createTable().

      1. No_patch_90_surefire-report.html
        200 kB
        xufeng
      2. backport-5454-to-92.patch
        4 kB
        xufeng
      3. backport-5454-to-92_surefire-report.html
        279 kB
        xufeng
      4. backport-5454-to-90-surefire-report.html
        200 kB
        xufeng
      5. backport-5454-to-90.patch
        4 kB
        xufeng
      6. backport-5454(createTable)-to-trunk.patch
        0.5 kB
        xufeng
      7. backport-5454(createTable)-to-trunk_surefire-report.html
        287 kB
        xufeng
      8. backport-5454(createTable)-to-94.patch
        0.5 kB
        xufeng
      9. backport-5454(createTable)-to-94_surefire-report.html
        279 kB
        xufeng
      10. 5850-trunk.txt
        0.5 kB
        Ted Yu

        Activity

        xufeng created issue -
        Hide
        xufeng added a comment -

        @stack
        All patch have been verified in real cluster.

        The error of unit test in trunk be verified I think it is no relation whit the patch.

        I did not submit the 90 test result,because I meeted this problem:
        $

        Running org.apache.hadoop.hbase.master.TestMasterFailover
        killed.
        $

        This problem also exist if there is no the patch.

        Show
        xufeng added a comment - @stack All patch have been verified in real cluster. The error of unit test in trunk be verified I think it is no relation whit the patch. I did not submit the 90 test result,because I meeted this problem: $ Running org.apache.hadoop.hbase.master.TestMasterFailover killed. $ This problem also exist if there is no the patch.
        xufeng made changes -
        Field Original Value New Value
        Attachment backport-5454(createTable)-to-trunk.patch [ 12523616 ]
        Attachment backport-5454(createTable)-to-trunk_surefire-report.html [ 12523617 ]
        Attachment backport-5454(createTable)-to-94.patch [ 12523618 ]
        Attachment backport-5454(createTable)-to-94_surefire-report.html [ 12523619 ]
        Attachment backport-5454-to-92.patch [ 12523620 ]
        Attachment backport-5454-to-92_surefire-report.html [ 12523621 ]
        Attachment backport-5454-to-90.patch [ 12523622 ]
        xufeng made changes -
        Fix Version/s 0.90.7 [ 12319481 ]
        Fix Version/s 0.92.2 [ 12319888 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        Hide
        Lars Hofhansl added a comment -

        HBASE-5454 is in 0.94 already.

        Show
        Lars Hofhansl added a comment - HBASE-5454 is in 0.94 already.
        Lars Hofhansl made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        Hide
        xufeng added a comment -

        @Lars
        I think we should add checkInitialized() to HMaster#createTable() in trunk and 0.94.
        So I created the patch for trunk and 0.94.

        Show
        xufeng added a comment - @Lars I think we should add checkInitialized() to HMaster#createTable() in trunk and 0.94. So I created the patch for trunk and 0.94.
        Hide
        Lars Hofhansl added a comment -

        I see. Thanks xufeng. I assume this does not sink the RC, so I am targetting this for 0.94.1.

        Show
        Lars Hofhansl added a comment - I see. Thanks xufeng. I assume this does not sink the RC, so I am targetting this for 0.94.1.
        Lars Hofhansl made changes -
        Fix Version/s 0.94.1 [ 12320257 ]
        Ted Yu made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags Reviewed [ 10343 ]
        Hide
        Ted Yu added a comment -

        @Xufeng:
        Can you attach test suite result for 0.90 ?

        Thanks

        Show
        Ted Yu added a comment - @Xufeng: Can you attach test suite result for 0.90 ? Thanks
        Ted Yu made changes -
        Comment [ -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12523622/backport-5454-to-90.patch
          against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
                                Please justify why no new tests are needed for this patch.
                                Also please list what manual steps were performed to verify this patch.

            -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1601//console

        This message is automatically generated. ]
        Hide
        Ted Yu added a comment -

        Re-attaching patch for trunk.

        Show
        Ted Yu added a comment - Re-attaching patch for trunk.
        Ted Yu made changes -
        Attachment 5850-trunk.txt [ 12523736 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1602//console This message is automatically generated.
        Hide
        xufeng added a comment -

        @Ted
        I get the 90 version at revision 1329041 from http://svn.apache.org/repos/asf/hbase/branches/0.90.
        But this error also exist.
        $

        -------------------------------------------------------
         T E S T S
        -------------------------------------------------------
        Running org.apache.hadoop.hbase.master.TestMasterFailover
        killed.
        $

        Does this error also exist in your test env?

        Show
        xufeng added a comment - @Ted I get the 90 version at revision 1329041 from http://svn.apache.org/repos/asf/hbase/branches/0.90 . But this error also exist. $ ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.master.TestMasterFailover killed. $ Does this error also exist in your test env?
        Ted Yu made changes -
        Comment [ @Ted ]
        Hide
        Ted Yu added a comment -

        Stack provided a patch to fix this test in HBASE-5833
        Can you try his patch ?

        Thanks

        Show
        Ted Yu added a comment - Stack provided a patch to fix this test in HBASE-5833 Can you try his patch ? Thanks
        Hide
        xufeng added a comment -

        I try to merge the HBASE-5833 patch to 0.90 version,but failed.
        Many compile errors happend.

        So I delete the TestMasterFailover java file and test again.

        There are some error but also exist if no patch.

        I also check the TestMasterFailover file and I think it is no relation with the patch.

        Show
        xufeng added a comment - I try to merge the HBASE-5833 patch to 0.90 version,but failed. Many compile errors happend. So I delete the TestMasterFailover java file and test again. There are some error but also exist if no patch. I also check the TestMasterFailover file and I think it is no relation with the patch.
        xufeng made changes -
        Attachment No_patch_90_surefire-report.html [ 12523781 ]
        Attachment backport-5454-to-90-surefire-report.html [ 12523782 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.util.TestProcessBasedCluster

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523736/5850-trunk.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.util.TestProcessBasedCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1606//console This message is automatically generated.
        Hide
        Lars Hofhansl added a comment -

        Pulling back to 0.94.0, as RC2 was sunk.

        Show
        Lars Hofhansl added a comment - Pulling back to 0.94.0, as RC2 was sunk.
        Lars Hofhansl made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        Hide
        Lars Hofhansl added a comment -

        The patches look good to me. Anybody opposed if I committed them to all branches?

        Show
        Lars Hofhansl added a comment - The patches look good to me. Anybody opposed if I committed them to all branches?
        Hide
        Lars Hofhansl added a comment -

        Or phrased differently:
        +1 on patches. Anybody else +1?

        Show
        Lars Hofhansl added a comment - Or phrased differently: +1 on patches. Anybody else +1?
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Lars Hofhansl added a comment -

        Changed title

        Show
        Lars Hofhansl added a comment - Changed title
        Lars Hofhansl made changes -
        Summary Backport HBASE-5454 to 90 and 92 Refuse operations from Admin before master is initialized Refuse operations from Admin before master is initialized - fix for all branches.
        Hide
        Lars Hofhansl added a comment -

        Committed to 0.90, 0.92, 0.94, and 0.96
        (just noticed that I did forget the jira number in the commit messages, sorry)

        Show
        Lars Hofhansl added a comment - Committed to 0.90, 0.92, 0.94, and 0.96 (just noticed that I did forget the jira number in the commit messages, sorry)
        Lars Hofhansl made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        xufeng added a comment -

        @stack @Ted @Lars
        Thanks for your help,Thanks.

        Show
        xufeng added a comment - @stack @Ted @Lars Thanks for your help,Thanks.
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            xufeng
            Reporter:
            xufeng
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development