HBase
  1. HBase
  2. HBASE-5847

Support createTable(splitKeys) in Thrift

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++.

        Activity

        Hide
        stack added a comment -

        Does the thrift2 package support this Nicolas?

        Show
        stack added a comment - Does the thrift2 package support this Nicolas?
        Hide
        Nicolas Spiegelberg added a comment -

        @stack: I assume you're talking about HBASE-1744? thrift2 does not have this API either. I take it I should put the new API in thrift/Hbase.thrift?

        Show
        Nicolas Spiegelberg added a comment - @stack: I assume you're talking about HBASE-1744 ? thrift2 does not have this API either. I take it I should put the new API in thrift/Hbase.thrift?
        Hide
        stack added a comment -

        @Nicolas Up to you. Not necessary. Just thought if it was there already, you could take it from thrift2.

        One day we'll have to reconcile the two and go for one or the other. Until then, they will both get the fly-by-treatment w/ fellas adding what they need just now.

        Show
        stack added a comment - @Nicolas Up to you. Not necessary. Just thought if it was there already, you could take it from thrift2. One day we'll have to reconcile the two and go for one or the other. Until then, they will both get the fly-by-treatment w/ fellas adding what they need just now.
        Hide
        Phabricator added a comment -

        nspiegelberg requested code review of "[jira] HBASE-5847 Support createTable(splitKeys) in Thrift".
        Reviewers: mbautin, Karthik, stack, JIRA

        The Thrift API does not allow a user to create a table with
        multiple split keys. This is needed for a handful of new internal
        projects that are written in PHP/C++.

        TEST PLAN

        • mvn test -Dtest=TestThriftServer

        REVISION DETAIL
        https://reviews.facebook.net/D3039

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
        src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
        src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift

        Show
        Phabricator added a comment - nspiegelberg requested code review of " [jira] HBASE-5847 Support createTable(splitKeys) in Thrift". Reviewers: mbautin, Karthik, stack, JIRA The Thrift API does not allow a user to create a table with multiple split keys. This is needed for a handful of new internal projects that are written in PHP/C++. TEST PLAN mvn test -Dtest=TestThriftServer REVISION DETAIL https://reviews.facebook.net/D3039 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
        Hide
        Phabricator added a comment -

        tedyu has accepted the revision "[jira] HBASE-5847 Support createTable(splitKeys) in Thrift".

        REVISION DETAIL
        https://reviews.facebook.net/D3039

        BRANCH
        5847

        Show
        Phabricator added a comment - tedyu has accepted the revision " [jira] HBASE-5847 Support createTable(splitKeys) in Thrift". REVISION DETAIL https://reviews.facebook.net/D3039 BRANCH 5847
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525648/D3039.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1768//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525648/D3039.1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1768//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Looks like src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java needs to be generated again.

        Show
        Ted Yu added a comment - Looks like src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java needs to be generated again.
        Hide
        Andrew Purtell added a comment -

        Stale issue. Reopen if still relevant.

        Show
        Andrew Purtell added a comment - Stale issue. Reopen if still relevant.

          People

          • Assignee:
            Unassigned
            Reporter:
            Nicolas Spiegelberg
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development