HBase
  1. HBase
  2. HBASE-5840

Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: regionserver
    • Labels:
      None

      Description

      TaskMonitor Status will not be cleared in case Regions FAILED_OPEN. This will keeps showing old status.

      This will miss leads the user.

      1. HBASE-5840.patch
        13 kB
        rajeshbabu
      2. HBASE-5840_v2.patch
        4 kB
        rajeshbabu
      3. HBASE-5840_trunk.patch
        4 kB
        rajeshbabu
      4. HBASE-5840_0.94.patch
        4 kB
        ramkrishna.s.vasudevan

        Activity

        Hide
        rajeshbabu added a comment -

        Attached patch.Please review and provide your comments/suggestions.

        Show
        rajeshbabu added a comment - Attached patch.Please review and provide your comments/suggestions.
        Hide
        ramkrishna.s.vasudevan added a comment -

        +1..Test case looks good.
        Lets wait for other's comments.

        Show
        ramkrishna.s.vasudevan added a comment - +1..Test case looks good. Lets wait for other's comments.
        Hide
        stack added a comment -

        Patch looks good. Is it just moving all of this (too long) method into a try block and then adding a finally that sets status.abort on the end (FYI, needs spacing around the operators in the status.abort line so its same code style as rest of file). Do you have to convert the Exception to an IOE? WHy is that? What does this method let out? IOEs only? If so, why we catch Exception? In case its a non-checked exception? On the test, it looks good too but in the finally you might want to use the new HRegion.closeHRegion(region) to clean up the wal log that gets made by the constructor.

        Show
        stack added a comment - Patch looks good. Is it just moving all of this (too long) method into a try block and then adding a finally that sets status.abort on the end (FYI, needs spacing around the operators in the status.abort line so its same code style as rest of file). Do you have to convert the Exception to an IOE? WHy is that? What does this method let out? IOEs only? If so, why we catch Exception? In case its a non-checked exception? On the test, it looks good too but in the finally you might want to use the new HRegion.closeHRegion(region) to clean up the wal log that gets made by the constructor.
        Hide
        rajeshbabu added a comment -

        @Stack
        Thanks for your review.

        Do you have to convert the Exception to an IOE? WHy is that? What does this method let out? IOEs only? If so, why we catch Exception? In case its a non-checked exception?

        Refactored the code in such a way setting status to abort without handling any exceptions from initialize.

        it looks good too but in the finally you might want to use the new HRegion.closeHRegion(region) to clean up the wal log

        region = HRegion.newHRegion(path, null, fs, conf, info, htd, null);
        

        As am passing null for WAL the close region does not try to do any operation related to wal closing. But i have added it as per your suggestion as it does no harm.

        Show
        rajeshbabu added a comment - @Stack Thanks for your review. Do you have to convert the Exception to an IOE? WHy is that? What does this method let out? IOEs only? If so, why we catch Exception? In case its a non-checked exception? Refactored the code in such a way setting status to abort without handling any exceptions from initialize. it looks good too but in the finally you might want to use the new HRegion.closeHRegion(region) to clean up the wal log region = HRegion.newHRegion(path, null , fs, conf, info, htd, null ); As am passing null for WAL the close region does not try to do any operation related to wal closing. But i have added it as per your suggestion as it does no harm.
        Hide
        stack added a comment -

        @Rajeshbabu I think you are right on the latter wal==null issue for newHRegion case. +1 on patch. Running by hadoopqa.

        Show
        stack added a comment - @Rajeshbabu I think you are right on the latter wal==null issue for newHRegion case. +1 on patch. Running by hadoopqa.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12524288/HBASE-5840_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524288/HBASE-5840_v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1676//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Thanks for the review Stack. I will commit it today.

        Show
        ramkrishna.s.vasudevan added a comment - Thanks for the review Stack. I will commit it today.
        Hide
        rajeshbabu added a comment -

        Latest patch for trunk.

        Show
        rajeshbabu added a comment - Latest patch for trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12525040/HBASE-5840_trunk.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12525040/HBASE-5840_trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1686//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Lars
        You want this in 0.94? If not i will commit in trunk alone?

        Show
        ramkrishna.s.vasudevan added a comment - @Lars You want this in 0.94? If not i will commit in trunk alone?
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Lars
        Can i commit this to both versions? 0.94 and trunk?

        Show
        ramkrishna.s.vasudevan added a comment - @Lars Can i commit this to both versions? 0.94 and trunk?
        Hide
        stack added a comment -

        As Ram discovered, I committed this to trunk as part of HBASE-5548 commit by mistake. I'm going to just leave it unless someone screams.

        To close, we should commit to 0.94 when Lars says ok.

        Show
        stack added a comment - As Ram discovered, I committed this to trunk as part of HBASE-5548 commit by mistake. I'm going to just leave it unless someone screams. To close, we should commit to 0.94 when Lars says ok.
        Hide
        stack added a comment -

        Changed my mind. Backed out the miscommit of this trunk patch that went in w/ the commit of hbase-5548 by mistake.

        So, this patch is still to be committed on trunk and branch. Sorry for my mess.

        Show
        stack added a comment - Changed my mind. Backed out the miscommit of this trunk patch that went in w/ the commit of hbase-5548 by mistake. So, this patch is still to be committed on trunk and branch. Sorry for my mess.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Thanks Stack. Committed to trunk. Waiting for Lars to confirm on 0.94. Then will commit there.

        Show
        ramkrishna.s.vasudevan added a comment - Thanks Stack. Committed to trunk. Waiting for Lars to confirm on 0.94. Then will commit there.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2837 (See https://builds.apache.org/job/HBase-TRUNK/2837/)
        HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (RajeshBabu) (Revision 1333124)
        HBASE-5548 Add ability to get a table in the shell; BACKING OUT MISTAKEN CO-COMMIT OF HBASE-5840 (Revision 1333123)

        Result = SUCCESS
        ramkrishna :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2837 (See https://builds.apache.org/job/HBase-TRUNK/2837/ ) HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (RajeshBabu) (Revision 1333124) HBASE-5548 Add ability to get a table in the shell; BACKING OUT MISTAKEN CO-COMMIT OF HBASE-5840 (Revision 1333123) Result = SUCCESS ramkrishna : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #190 (See https://builds.apache.org/job/HBase-TRUNK-security/190/)
        HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (RajeshBabu) (Revision 1333124)
        HBASE-5548 Add ability to get a table in the shell; BACKING OUT MISTAKEN CO-COMMIT OF HBASE-5840 (Revision 1333123)

        Result = SUCCESS
        ramkrishna :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #190 (See https://builds.apache.org/job/HBase-TRUNK-security/190/ ) HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (RajeshBabu) (Revision 1333124) HBASE-5548 Add ability to get a table in the shell; BACKING OUT MISTAKEN CO-COMMIT OF HBASE-5840 (Revision 1333123) Result = SUCCESS ramkrishna : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        ramkrishna.s.vasudevan added a comment -

        I will commit this to 0.94.1 today.

        Show
        ramkrishna.s.vasudevan added a comment - I will commit this to 0.94.1 today.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Patch for 0.94. Earlier this was committed to trunk. Will commit tomorrow so that Lars can see it.

        Show
        ramkrishna.s.vasudevan added a comment - Patch for 0.94. Earlier this was committed to trunk. Will commit tomorrow so that Lars can see it.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12528121/HBASE-5840_0.94.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1936//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528121/HBASE-5840_0.94.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1936//console This message is automatically generated.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to 0.94.1. Hence resolving this.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to 0.94.1. Hence resolving this.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #204 (See https://builds.apache.org/job/HBase-0.94/204/)
        HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (Rajesh) (Revision 1340396)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #204 (See https://builds.apache.org/job/HBase-0.94/204/ ) HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (Rajesh) (Revision 1340396) Result = FAILURE ramkrishna : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #28 (See https://builds.apache.org/job/HBase-0.94-security/28/)
        HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (Rajesh) (Revision 1340396)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #28 (See https://builds.apache.org/job/HBase-0.94-security/28/ ) HBASE-5840 Open Region FAILED_OPEN doesn't clear the TaskMonitor Status, keeps showing the old status (Rajesh) (Revision 1340396) Result = FAILURE ramkrishna : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

          People

          • Assignee:
            rajeshbabu
            Reporter:
            Gopinathan A
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development