HBase
  1. HBase
  2. HBASE-5838

Add an LZ4 compression option to HFile

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.92.2, 0.94.1, 0.95.2
    • Fix Version/s: 0.94.1, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Tags:
      0.96notable

      Description

      HADOOP-7657 adds support for LZ4 compression to Hadoop core. As with Snappy, we should add reflection based support for this alternative to HFile.Compression.

      1. 5838.patch
        2 kB
        Andrew Purtell

        Activity

        Andrew Purtell created issue -
        Hide
        Andrew Purtell added a comment -

        Trivial patch.

        LZ4 is only available in Hadoop 0.23+ so beyond adding a case to TestHFile#testCompressionOrdinance (and added a missing one there for Snappy) I've not added any tests.

        Show
        Andrew Purtell added a comment - Trivial patch. LZ4 is only available in Hadoop 0.23+ so beyond adding a case to TestHFile#testCompressionOrdinance (and added a missing one there for Snappy) I've not added any tests.
        Andrew Purtell made changes -
        Field Original Value New Value
        Attachment 5838.patch [ 12531078 ]
        Andrew Purtell made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.92.2 [ 12319888 ]
        Affects Version/s 0.96.0 [ 12320040 ]
        Affects Version/s 0.94.1 [ 12320257 ]
        Assignee Andrew Purtell [ apurtell ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12531078/5838.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12531078/5838.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2114//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        Committed to trunk and 0.94 branch. Additional case to TestHFile passes locally.

        Show
        Andrew Purtell added a comment - Committed to trunk and 0.94 branch. Additional case to TestHFile passes locally.
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3033 (See https://builds.apache.org/job/HBase-TRUNK/3033/)
        HBASE-5838. Add an LZ4 compression option to HFile (Revision 1350844)

        Result = SUCCESS
        apurtell :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3033 (See https://builds.apache.org/job/HBase-TRUNK/3033/ ) HBASE-5838 . Add an LZ4 compression option to HFile (Revision 1350844) Result = SUCCESS apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #258 (See https://builds.apache.org/job/HBase-0.94/258/)
        HBASE-5838. Add an LZ4 compression option to HFile (Revision 1350845)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #258 (See https://builds.apache.org/job/HBase-0.94/258/ ) HBASE-5838 . Add an LZ4 compression option to HFile (Revision 1350845) Result = FAILURE apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #56 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/56/)
        HBASE-5838. Add an LZ4 compression option to HFile (Revision 1350844)

        Result = FAILURE
        apurtell :
        Files :

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #56 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/56/ ) HBASE-5838 . Add an LZ4 compression option to HFile (Revision 1350844) Result = FAILURE apurtell : Files : /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #37 (See https://builds.apache.org/job/HBase-0.94-security/37/)
        HBASE-5838. Add an LZ4 compression option to HFile (Revision 1350845)

        Result = SUCCESS
        apurtell :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #37 (See https://builds.apache.org/job/HBase-0.94-security/37/ ) HBASE-5838 . Add an LZ4 compression option to HFile (Revision 1350845) Result = SUCCESS apurtell : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/io/hfile/Compression.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Andy
        I think this also needs a change in HColumnDescriptor.setCompressionType and setCompactionCompressionType?

        Show
        ramkrishna.s.vasudevan added a comment - @Andy I think this also needs a change in HColumnDescriptor.setCompressionType and setCompactionCompressionType?
        Hide
        Andrew Purtell added a comment -

        Follow up work in HBASE-6303

        Show
        Andrew Purtell added a comment - Follow up work in HBASE-6303
        Lars Hofhansl made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        stack made changes -
        Fix Version/s 0.95.0 [ 12324094 ]
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.1 [ 12320257 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.94.1 [ 12320257 ]
        stack made changes -
        Tags 0.96notable

          People

          • Assignee:
            Andrew Purtell
            Reporter:
            Andrew Purtell
          • Votes:
            1 Vote for this issue
            Watchers:
            11 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development