Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      HBASE-5782 solved the correctness issue for the sync of HLog edits.
      Todd provided a patch that would achieve higher throughput.

      This JIRA is a continuation of Todd's work submitted there.

      1. 5826.txt
        14 kB
        Ted Yu
      2. 5826-v2.txt
        14 kB
        Ted Yu
      3. 5826-v3.txt
        15 kB
        Ted Yu
      4. 5826-v4.txt
        15 kB
        Ted Yu
      5. 5826-v5.txt
        15 kB
        Ted Yu

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          I'm happy to work on this, if folks would like. But, I probably won't be able to commit a lot of time - so if people are antsy to get this sooner rather than later, feel free to steal it from me

          Show
          Todd Lipcon added a comment - I'm happy to work on this, if folks would like. But, I probably won't be able to commit a lot of time - so if people are antsy to get this sooner rather than later, feel free to steal it from me
          Hide
          Ted Yu added a comment -

          Todd's patch, for trunk.

          Show
          Ted Yu added a comment - Todd's patch, for trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12523827/5826.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.TestDrainingServer

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523827/5826.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestDrainingServer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1610//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12524921/5826.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12524921/5826.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1673//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          Patch rebased on trunk.

          Show
          Ted Yu added a comment - Patch rebased on trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12527695/5826-v2.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527695/5826-v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1895//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12527713/5826-v3.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestAdmin

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527713/5826-v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestAdmin Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1896//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          TestAdmin#testCloseRegionThatFetchesTheHRIFromMeta failure wasn't related to the patch.

          Locally it passed for me.

          Are there further review comments about Todd's patch ?

          Show
          Ted Yu added a comment - TestAdmin#testCloseRegionThatFetchesTheHRIFromMeta failure wasn't related to the patch. Locally it passed for me. Are there further review comments about Todd's patch ?
          Hide
          Ted Yu added a comment -

          Will integrate this morning (PST) if there is no objection.

          Show
          Ted Yu added a comment - Will integrate this morning (PST) if there is no objection.
          Hide
          Todd Lipcon added a comment -

          I'm not sure the error handling paths are write. What happens if the syncing thread hits an error - the other threads might end up stuck in "wait()" forever.

          Show
          Todd Lipcon added a comment - I'm not sure the error handling paths are write. What happens if the syncing thread hits an error - the other threads might end up stuck in "wait()" forever.
          Hide
          Ted Yu added a comment -

          Integrated to trunk.

          Thanks for the patch, Todd.

          Show
          Ted Yu added a comment - Integrated to trunk. Thanks for the patch, Todd.
          Hide
          Ted Yu added a comment -

          Just saw Todd's comment.

          Patch reverted.

          Show
          Ted Yu added a comment - Just saw Todd's comment. Patch reverted.
          Hide
          Ted Yu added a comment -

          @Todd:
          Were you referring to the following code ?

          +    synchronized void waitForSync(long txid) throws InterruptedException {
          +      while (syncedTillHere < txid) {
          +        wait();
          +      }
          +    }
          

          It turns out that the above method is never referenced.

          See patch v4 where it is removed.

          Show
          Ted Yu added a comment - @Todd: Were you referring to the following code ? + synchronized void waitForSync( long txid) throws InterruptedException { + while (syncedTillHere < txid) { + wait(); + } + } It turns out that the above method is never referenced. See patch v4 where it is removed.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2890 (See https://builds.apache.org/job/HBase-TRUNK/2890/)
          HBASE-5826 Improve sync of HLog edits (Todd) (Revision 1339671)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2890 (See https://builds.apache.org/job/HBase-TRUNK/2890/ ) HBASE-5826 Improve sync of HLog edits (Todd) (Revision 1339671) Result = FAILURE tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12527851/5826-v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop23. The patch compiles against the hadoop 0.23.x profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestMasterObserver

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527851/5826-v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1911//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2891 (See https://builds.apache.org/job/HBase-TRUNK/2891/)
          HBASE-5826 Revert, Todd has review comments pending. (Revision 1339673)

          Result = SUCCESS
          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2891 (See https://builds.apache.org/job/HBase-TRUNK/2891/ ) HBASE-5826 Revert, Todd has review comments pending. (Revision 1339673) Result = SUCCESS tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/)
          HBASE-5826 Revert, Todd has review comments pending. (Revision 1339673)
          HBASE-5826 Improve sync of HLog edits (Todd) (Revision 1339671)

          Result = FAILURE
          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java

          tedyu :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/ ) HBASE-5826 Revert, Todd has review comments pending. (Revision 1339673) HBASE-5826 Improve sync of HLog edits (Todd) (Revision 1339671) Result = FAILURE tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java tedyu : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceFileLogWriter.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          Hide
          Ted Yu added a comment -

          @Todd:
          Do you have further comments ?

          Show
          Ted Yu added a comment - @Todd: Do you have further comments ?
          Hide
          Ted Yu added a comment -

          Rebased against trunk.

          Show
          Ted Yu added a comment - Rebased against trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12542625/5826-v5.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          -1 javadoc. The javadoc tool appears to have generated 94 warning messages.

          -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

          -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed
          org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
          org.apache.hadoop.hbase.regionserver.wal.TestWALReplay

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542625/5826-v5.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. -1 javadoc. The javadoc tool appears to have generated 94 warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 13 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor org.apache.hadoop.hbase.regionserver.wal.TestWALReplay Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2702//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          Shall we keep this as critical for 0.95 or downgrade?

          Show
          Enis Soztutar added a comment - Shall we keep this as critical for 0.95 or downgrade?
          Hide
          Matteo Bertozzi added a comment -

          I've played a bit with it days ago but I don't see improvements
          the only advantage of this patch is removing one atomic operation "unflushedEntries" by using the "logSeqNum" that we've already.

          By running HLogPerformanceEvaluation this patch results slower than the current version
          https://github.com/matteobertozzi/hbase/commit/5a608a8eee3c1d5a88149132cc782d64f8b6441a

          and by reverting back the synchronize (this) to the current status, the performance seems more or less the same
          https://github.com/matteobertozzi/hbase/commit/cb5cc2034bd10ad990a22589dc2a80a93180e358

          I don't think that this should stay as critical

          Show
          Matteo Bertozzi added a comment - I've played a bit with it days ago but I don't see improvements the only advantage of this patch is removing one atomic operation "unflushedEntries" by using the "logSeqNum" that we've already. By running HLogPerformanceEvaluation this patch results slower than the current version https://github.com/matteobertozzi/hbase/commit/5a608a8eee3c1d5a88149132cc782d64f8b6441a and by reverting back the synchronize (this) to the current status, the performance seems more or less the same https://github.com/matteobertozzi/hbase/commit/cb5cc2034bd10ad990a22589dc2a80a93180e358 I don't think that this should stay as critical
          Hide
          stack added a comment -

          Undid the critical pegging. Thanks Matteo for taking a look. Thanks Enis for prompting.

          Show
          stack added a comment - Undid the critical pegging. Thanks Matteo for taking a look. Thanks Enis for prompting.
          Hide
          stack added a comment -

          Moving out of 0.95. Not being worked on. Later.

          Show
          stack added a comment - Moving out of 0.95. Not being worked on. Later.

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Ted Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:

                Development