HBase
  1. HBase
  2. HBASE-5810

HBASE-5620 Convert the client protocol of HRegionInterface to PB addendum

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Apply an addendum that Jimmy made here rather than over in hbase-5620, a week or so after it went in.

        Activity

        Hide
        stack added a comment -

        Copied over from hbase-5620

        Show
        stack added a comment - Copied over from hbase-5620
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522990/hbase-5620-sec.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522990/hbase-5620-sec.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1554//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to trunk. Thanks for the patch Jimmy.

        Show
        stack added a comment - Committed to trunk. Thanks for the patch Jimmy.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2781 (See https://builds.apache.org/job/HBase-TRUNK/2781/)
        HBASE-5810 HBASE-5620 Convert the client protocol of HRegionInterface to PB addendum (Revision 1327629)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2781 (See https://builds.apache.org/job/HBase-TRUNK/2781/ ) HBASE-5810 HBASE-5620 Convert the client protocol of HRegionInterface to PB addendum (Revision 1327629) Result = FAILURE stack : Files : /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #175 (See https://builds.apache.org/job/HBase-TRUNK-security/175/)
        HBASE-5810 HBASE-5620 Convert the client protocol of HRegionInterface to PB addendum (Revision 1327629)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #175 (See https://builds.apache.org/job/HBase-TRUNK-security/175/ ) HBASE-5810 HBASE-5620 Convert the client protocol of HRegionInterface to PB addendum (Revision 1327629) Result = FAILURE stack : Files : /hbase/trunk/security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development