HBase
  1. HBase
  2. HBASE-5809

Avoid move api to take the destination server same as the source server.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.92.1
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.

      1. 5809.addendum
        1 kB
        Ted Yu
      2. HBASE-5809.patch
        3 kB
        ramkrishna.s.vasudevan
      3. HBASE-5809.patch
        3 kB
        rajeshbabu

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #178 (See https://builds.apache.org/job/HBase-TRUNK-security/178/)
        HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #178 (See https://builds.apache.org/job/HBase-TRUNK-security/178/ ) HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594) Result = FAILURE ramkrishna : Files : /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2793 (See https://builds.apache.org/job/HBase-TRUNK/2793/)
        HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2793 (See https://builds.apache.org/job/HBase-TRUNK/2793/ ) HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594) Result = FAILURE ramkrishna : Files : /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk.
        Hide
        ramkrishna.s.vasudevan added a comment -

        +1 on addendum Ted. Thanks for the patch. I will commit it.

        Show
        ramkrishna.s.vasudevan added a comment - +1 on addendum Ted. Thanks for the patch. I will commit it.
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Ted
        Thanks for your follow up. But the same had passed in
        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/.
        The QA build that ran on this patch. I will check it up and commit the addendum.

        Show
        ramkrishna.s.vasudevan added a comment - @Ted Thanks for your follow up. But the same had passed in Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/ . The QA build that ran on this patch. I will check it up and commit the addendum.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #177 (See https://builds.apache.org/job/HBase-TRUNK-security/177/)
        HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #177 (See https://builds.apache.org/job/HBase-TRUNK-security/177/ ) HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458) Result = FAILURE ramkrishna : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        Hide
        Ted Yu added a comment -

        The addendum fixes the incorrect comparison between server names.

        Show
        Ted Yu added a comment - The addendum fixes the incorrect comparison between server names.
        Show
        Ted Yu added a comment - The test failure was visible on Hadoop QA as well: https://builds.apache.org/job/PreCommit-HBASE-Build/1594//testReport/org.apache.hadoop.hbase.coprocessor/TestMasterObserver/testRegionTransitionOperations/
        Hide
        Ted Yu added a comment -

        I looped the test using:

        ~/runtest.sh 4 TestMasterObserver#testRegionTransitionOperations
        

        and got the following:

        Failed tests:   testRegionTransitionOperations(org.apache.hadoop.hbase.coprocessor.TestMasterObserver): Coprocessor should have been called on region move
        ...
        TestMasterObserver#testRegionTransitionOperations failed, iteration: 2
        
        Show
        Ted Yu added a comment - I looped the test using: ~/runtest.sh 4 TestMasterObserver#testRegionTransitionOperations and got the following: Failed tests: testRegionTransitionOperations(org.apache.hadoop.hbase.coprocessor.TestMasterObserver): Coprocessor should have been called on region move ... TestMasterObserver#testRegionTransitionOperations failed, iteration: 2
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2791 (See https://builds.apache.org/job/HBase-TRUNK/2791/)
        HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458)

        Result = FAILURE
        ramkrishna :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2791 (See https://builds.apache.org/job/HBase-TRUNK/2791/ ) HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458) Result = FAILURE ramkrishna : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
        Hide
        ramkrishna.s.vasudevan added a comment -

        This is what i finally committed. Small formatting change and corrected typo error.

        Show
        ramkrishna.s.vasudevan added a comment - This is what i finally committed. Small formatting change and corrected typo error.
        Hide
        ramkrishna.s.vasudevan added a comment -

        Committed to trunk. Made it as an improvement.
        Thanks for the patch Rajesh.
        Thanks for the review Ted and Uma.

        Show
        ramkrishna.s.vasudevan added a comment - Committed to trunk. Made it as an improvement. Thanks for the patch Rajesh. Thanks for the review Ted and Uma.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Ram.

        Show
        Uma Maheswara Rao G added a comment - Thanks Ram.
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Uma
        I will change this while commit. Thanks.

        Show
        ramkrishna.s.vasudevan added a comment - @Uma I will change this while commit. Thanks.
        Hide
        Uma Maheswara Rao G added a comment -

        small nit:

        +            + " beacuse region already assigned to the same server " + dest + '.');
        

        typo: beacuse -> because

        Show
        Uma Maheswara Rao G added a comment - small nit: + + " beacuse region already assigned to the same server " + dest + '.'); typo: beacuse -> because
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12523374/HBASE-5809.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12523374/HBASE-5809.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        You meant 'unless objection', I assume

        Show
        Ted Yu added a comment - You meant 'unless objection', I assume
        Hide
        ramkrishna.s.vasudevan added a comment -

        Will commit tomorrow unless no objection.

        Show
        ramkrishna.s.vasudevan added a comment - Will commit tomorrow unless no objection.
        Hide
        ramkrishna.s.vasudevan added a comment -

        +1

        Show
        ramkrishna.s.vasudevan added a comment - +1
        Hide
        Ted Yu added a comment -

        +1 on patch.

        Show
        Ted Yu added a comment - +1 on patch.
        Hide
        rajeshbabu added a comment -

        Attached patch.Please review and provide your comments/suggestions.

        Show
        rajeshbabu added a comment - Attached patch.Please review and provide your comments/suggestions.

          People

          • Assignee:
            rajeshbabu
            Reporter:
            ramkrishna.s.vasudevan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development