HBase
  1. HBase
  2. HBASE-5802

Change the default metrics class to NullContextWithUpdateThread

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      Since lots more metrics are being placed into the Dynamic metrics bucket changing the default class to NullContextWithUpdateThread seems like it might be worth it.

      1. HBASE-5802-0.patch
        2 kB
        Elliott Clark
      2. HBASE-5802-1.patch
        2 kB
        Elliott Clark
      3. HBASE-5802-2.patch
        3 kB
        Elliott Clark

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #27 (See https://builds.apache.org/job/HBase-0.94-security/27/)
        HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/conf/hadoop-metrics.properties
        • /hbase/branches/0.94/src/site/xdoc/metrics.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #27 (See https://builds.apache.org/job/HBase-0.94-security/27/ ) HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832) Result = SUCCESS stack : Files : /hbase/branches/0.94/conf/hadoop-metrics.properties /hbase/branches/0.94/src/site/xdoc/metrics.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/)
        HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/conf/hadoop-metrics.properties
        • /hbase/trunk/src/site/xdoc/metrics.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/8/ ) HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831) Result = FAILURE stack : Files : /hbase/trunk/conf/hadoop-metrics.properties /hbase/trunk/src/site/xdoc/metrics.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #195 (See https://builds.apache.org/job/HBase-0.94/195/)
        HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/conf/hadoop-metrics.properties
        • /hbase/branches/0.94/src/site/xdoc/metrics.xml
        Show
        Hudson added a comment - Integrated in HBase-0.94 #195 (See https://builds.apache.org/job/HBase-0.94/195/ ) HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339832) Result = SUCCESS stack : Files : /hbase/branches/0.94/conf/hadoop-metrics.properties /hbase/branches/0.94/src/site/xdoc/metrics.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2893 (See https://builds.apache.org/job/HBase-TRUNK/2893/)
        HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/conf/hadoop-metrics.properties
        • /hbase/trunk/src/site/xdoc/metrics.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2893 (See https://builds.apache.org/job/HBase-TRUNK/2893/ ) HBASE-5802 Change the default metrics class to NullContextWithUpdateThread (Revision 1339831) Result = SUCCESS stack : Files : /hbase/trunk/conf/hadoop-metrics.properties /hbase/trunk/src/site/xdoc/metrics.xml
        Hide
        stack added a comment -

        I marked it as incompatible change though innocuous. Thanks for the patch Elliott. Applied to 0.94 branch and to trunk.

        Show
        stack added a comment - I marked it as incompatible change though innocuous. Thanks for the patch Elliott. Applied to 0.94 branch and to trunk.
        Hide
        Elliott Clark added a comment -

        Patch with some comments and a change to the site.

        Show
        Elliott Clark added a comment - Patch with some comments and a change to the site.
        Hide
        Elliott Clark added a comment -

        Yep working on this right now so that 0.94.1 can get this.

        Show
        Elliott Clark added a comment - Yep working on this right now so that 0.94.1 can get this.
        Hide
        stack added a comment -

        Elliott: You going to add comments? We should backport to 0.94 especially if we are going to update 0.94 to hadoop 1.0.3, etc, and make /jmx work.

        Show
        stack added a comment - Elliott: You going to add comments? We should backport to 0.94 especially if we are going to update 0.94 to hadoop 1.0.3, etc, and make /jmx work.
        Hide
        stack added a comment -

        So, enable jmx emissions? Would suggest that your patch include comment explaining what the exotic-sounding NullContextWithUpdateThread does. Maybe copy the class comment into your patch somewhere:

         * A null context which has a thread calling
         * periodically when monitoring is started. This keeps the data sampled
         * correctly.
         * In all other respects, this is like the NULL context: No data is emitted.
         * This is suitable for Monitoring systems like JMX which reads the metrics
         *  when someone reads the data from JMX.
         *
         * The default impl of start and stop monitoring:
         *  is the AbstractMetricsContext is good enough.
        

        Maybe update the reference guide too especially if you are changing default.

        Good stuff E.

        Show
        stack added a comment - So, enable jmx emissions? Would suggest that your patch include comment explaining what the exotic-sounding NullContextWithUpdateThread does. Maybe copy the class comment into your patch somewhere: * A null context which has a thread calling * periodically when monitoring is started. This keeps the data sampled * correctly. * In all other respects, this is like the NULL context: No data is emitted. * This is suitable for Monitoring systems like JMX which reads the metrics * when someone reads the data from JMX. * * The default impl of start and stop monitoring: * is the AbstractMetricsContext is good enough. Maybe update the reference guide too especially if you are changing default. Good stuff E.
        Hide
        Elliott Clark added a comment -

        Trivial patch just to get discussion started.

        Show
        Elliott Clark added a comment - Trivial patch just to get discussion started.

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Elliott Clark
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development