Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-5775

ZKUtil doesn't handle deleteRecurisively cleanly

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ZKUtil.deleteNodeRecursively()'s contract says that it handles deletion of the node and all its children. However, nothing is mentioned as to what happens if the node you are attempting to delete doesn't actually exist. Turns out, it throws a null pointer exception. I
      'm proposing that we change the code s.t. it handles the case where the parent is already gone and exits cleanly, rather than failing horribly.

        Activity

        Hide
        jesse_yates Jesse Yates added a comment -

        patch coming momentarily.

        Show
        jesse_yates Jesse Yates added a comment - patch coming momentarily.
        Hide
        jesse_yates Jesse Yates added a comment -

        Attaching patch. Simple one line fix and updating associated test.

        Show
        jesse_yates Jesse Yates added a comment - Attaching patch. Simple one line fix and updating associated test.
        Hide
        stack stack added a comment -

        +1 on patch

        Show
        stack stack added a comment - +1 on patch
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Will commit when HadoopQA is done.

        Show
        lhofhansl Lars Hofhansl added a comment - Will commit when HadoopQA is done.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522467/java_HBASE-5775.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522467/java_HBASE-5775.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1499//console This message is automatically generated.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Committed to 0.94 and 0.96.

        Show
        lhofhansl Lars Hofhansl added a comment - Committed to 0.94 and 0.96.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Thanks for the patch.

        Show
        lhofhansl Lars Hofhansl added a comment - Thanks for the patch.
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #2748 (See https://builds.apache.org/job/HBase-TRUNK/2748/)
        HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325540)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #2748 (See https://builds.apache.org/job/HBase-TRUNK/2748/ ) HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325540) Result = SUCCESS larsh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.94 #108 (See https://builds.apache.org/job/HBase-0.94/108/)
        HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325541)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Show
        hudson Hudson added a comment - Integrated in HBase-0.94 #108 (See https://builds.apache.org/job/HBase-0.94/108/ ) HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325541) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/)
        HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325540)

        Result = FAILURE
        larsh :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/ ) HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325540) Result = FAILURE larsh : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
        HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325541)

        Result = SUCCESS
        larsh :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        Show
        hudson Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5775 ZKUtil doesn't handle deleteRecurisively cleanly (Jesse Yates) (Revision 1325541) Result = SUCCESS larsh : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java

          People

          • Assignee:
            jesse_yates Jesse Yates
            Reporter:
            jesse_yates Jesse Yates
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development