HBase
  1. HBase
  2. HBASE-5773

HtablePool constructor not reading config files in certain cases

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.6, 0.92.1, 0.94.1
    • Fix Version/s: 0.94.0, 0.95.0
    • Component/s: Client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Creating a HtablePool can issue two behaviour depanding on the constructor called.

      Case 1: loads the configs from hbase-site
      public HTablePool()

      { this(HBaseConfiguration.create(), Integer.MAX_VALUE); }

      Calling this with null values for Configuration:
      public HTablePool(final Configuration config, final int maxSize)

      { this(config, maxSize, null, null); }

      will issue:

      public HTablePool(final Configuration config, final int maxSize,
      final HTableInterfaceFactory tableFactory, PoolType poolType) {
      // Make a new configuration instance so I can safely cleanup when
      // done with the pool.
      this.config = config == null ? new Configuration() : config;

      which does not read the hbase-site config files as HBaseConfiguration.create() does.

      I've tracked this problem to all versions of hbase.

      1. different-config-behaviour.90.patch
        0.7 kB
        stack
      2. different-config-behaviour.90.patch
        0.7 kB
        stack
      3. different-config-behaviour.patch
        0.7 kB
        Ioan Eugen Stan

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325383)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-0.92-security #105 (See https://builds.apache.org/job/HBase-0.92-security/105/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325383) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325381)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325381) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        stack added a comment -

        Committed to 0.90 branch too.

        Show
        stack added a comment - Committed to 0.90 branch too.
        Hide
        stack added a comment -

        hmmm... this version actually compiles. This is what I committed.

        Show
        stack added a comment - hmmm... this version actually compiles. This is what I committed.
        Hide
        stack added a comment -

        Version I applied to 0.90 branch.

        Show
        stack added a comment - Version I applied to 0.90 branch.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325380)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325380) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Ioan Eugen Stan added a comment -

        Hi Stack,

        0.90 [1] branch has the same type of constructors. Am I looking in the wrong place?

        https://svn.apache.org/repos/asf/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java

        Show
        Ioan Eugen Stan added a comment - Hi Stack, 0.90 [1] branch has the same type of constructors. Am I looking in the wrong place? https://svn.apache.org/repos/asf/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #368 (See https://builds.apache.org/job/HBase-0.92/368/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325383)

        Result = FAILURE
        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #368 (See https://builds.apache.org/job/HBase-0.92/368/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325383) Result = FAILURE stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #105 (See https://builds.apache.org/job/HBase-0.94/105/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325381)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #105 (See https://builds.apache.org/job/HBase-0.94/105/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325381) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2745 (See https://builds.apache.org/job/HBase-TRUNK/2745/)
        HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325380)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2745 (See https://builds.apache.org/job/HBase-TRUNK/2745/ ) HBASE-5773 HtablePool constructor not reading config files in certain cases (Revision 1325380) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTablePool.java
        Hide
        stack added a comment -

        It doesn't apply to 0.90 branch.

        Show
        stack added a comment - It doesn't apply to 0.90 branch.
        Hide
        stack added a comment -

        Committed to trunk, 0.92, and 0.94 branches. Thanks for the patch Ioan.

        Show
        stack added a comment - Committed to trunk, 0.92, and 0.94 branches. Thanks for the patch Ioan.
        Hide
        Ted Yu added a comment -

        Patch makes sense.

        Show
        Ted Yu added a comment - Patch makes sense.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522403/different-config-behaviour.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522403/different-config-behaviour.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1495//console This message is automatically generated.

          People

          • Assignee:
            Ioan Eugen Stan
            Reporter:
            Ioan Eugen Stan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development