HBase
  1. HBase
  2. HBASE-5770

Add a clock skew warning threshold

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: master, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There's currently an exception thrown by the master when a region server attempts to start up with clock skew greater than some configured amount (defaulting to 30 seconds). However, it'd be nice to get some warnings logged at a value that isn't severe enough to warrant killing the RS, but still represents significant skew that could affect correctness. Will attach a simple patch to add this as a setting.

        Activity

        Hide
        Ian Varley added a comment -

        Patch to add warnings on skew not big enough to warrant killing the RS.

        Show
        Ian Varley added a comment - Patch to add warnings on skew not big enough to warrant killing the RS.
        Hide
        stack added a comment -

        +1 on patch (minor text issue that I can correct on commit). Passing by hadoopqa.

        Show
        stack added a comment - +1 on patch (minor text issue that I can correct on commit). Passing by hadoopqa.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522360/HBASE_5770_v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522360/HBASE_5770_v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1494//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to 0.94 and to trunk. Hang (seems to be around test thrift cmd line...) seems unrelated. Thanks for the patch Ian.

        Show
        stack added a comment - Committed to 0.94 and to trunk. Hang (seems to be around test thrift cmd line...) seems unrelated. Thanks for the patch Ian.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2746 (See https://builds.apache.org/job/HBase-TRUNK/2746/)
        HBASE-5770 Add a clock skew warning threshold (Revision 1325389)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2746 (See https://builds.apache.org/job/HBase-TRUNK/2746/ ) HBASE-5770 Add a clock skew warning threshold (Revision 1325389) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94 #106 (See https://builds.apache.org/job/HBase-0.94/106/)
        HBASE-5770 Add a clock skew warning threshold (Revision 1325388)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Show
        Hudson added a comment - Integrated in HBase-0.94 #106 (See https://builds.apache.org/job/HBase-0.94/106/ ) HBASE-5770 Add a clock skew warning threshold (Revision 1325388) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/)
        HBASE-5770 Add a clock skew warning threshold (Revision 1325389)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #169 (See https://builds.apache.org/job/HBase-TRUNK-security/169/ ) HBASE-5770 Add a clock skew warning threshold (Revision 1325389) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/)
        HBASE-5770 Add a clock skew warning threshold (Revision 1325388)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
        • /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java
        Show
        Hudson added a comment - Integrated in HBase-0.94-security #9 (See https://builds.apache.org/job/HBase-0.94-security/9/ ) HBASE-5770 Add a clock skew warning threshold (Revision 1325388) Result = SUCCESS stack : Files : /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestClockSkewDetection.java

          People

          • Assignee:
            Ian Varley
            Reporter:
            Ian Varley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development