HBase
  1. HBase
  2. HBASE-5759

HBaseClient throws NullPointerException when EOFException should be used.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.

      We need to check if the response is null before trying to access it.

      1. hbase-5759.patch
        1.0 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/)
          HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/ ) HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2738 (See https://builds.apache.org/job/HBase-TRUNK/2738/)
          HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2738 (See https://builds.apache.org/job/HBase-TRUNK/2738/ ) HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
          Hide
          stack added a comment -

          Thanks for the patch Jimmy

          Show
          stack added a comment - Thanks for the patch Jimmy
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522127/hbase-5759.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522127/hbase-5759.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//console This message is automatically generated.
          Hide
          Ted Yu added a comment -

          Patch makes sense.

          Show
          Ted Yu added a comment - Patch makes sense.
          Hide
          Jimmy Xiang added a comment -

          There is a trailing space. Please remove it before commit it. Thanks.

          Show
          Jimmy Xiang added a comment - There is a trailing space. Please remove it before commit it. Thanks.

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development