HBase
  1. HBase
  2. HBASE-5755

Region sever looking for master forever with cached stale data.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When the master address tracker doesn't have the master address ZK data, or the cached data is wrong, region server should not use the cached data.
      It should pull the data from ZK directly again.

        Activity

        Hide
        Jimmy Xiang added a comment -

        The other solution is to update ZookeeperNodeTracker.getData to pull data from ZK anyway when this.data is null or empty, which means the contract is different though.

        Show
        Jimmy Xiang added a comment - The other solution is to update ZookeeperNodeTracker.getData to pull data from ZK anyway when this.data is null or empty, which means the contract is different though.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12522043/hbase-5755.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522043/hbase-5755.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1459//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Patch makes sense.

        Show
        Ted Yu added a comment - Patch makes sense.
        Hide
        stack added a comment -

        Applied to trunk. Could do with something similar on other branches.

        Show
        stack added a comment - Applied to trunk. Could do with something similar on other branches.
        Hide
        stack added a comment -

        But the other branches look different...

        Show
        stack added a comment - But the other branches look different...
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2738 (See https://builds.apache.org/job/HBase-TRUNK/2738/)
        HBASE-5755 Region sever looking for master forever with cached stale data (Revision 1311910)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2738 (See https://builds.apache.org/job/HBase-TRUNK/2738/ ) HBASE-5755 Region sever looking for master forever with cached stale data (Revision 1311910) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        Hide
        Lars Hofhansl added a comment -

        Looks like MasterAddressTracker.java was moved from /hbase/trunk/src/main/java/org/apache/hadoop/hbase to /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper in 0.96

        Show
        Lars Hofhansl added a comment - Looks like MasterAddressTracker.java was moved from /hbase/trunk/src/main/java/org/apache/hadoop/hbase to /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper in 0.96
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/)
        HBASE-5755 Region sever looking for master forever with cached stale data (Revision 1311910)

        Result = SUCCESS
        stack :
        Files :

        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/ ) HBASE-5755 Region sever looking for master forever with cached stale data (Revision 1311910) Result = SUCCESS stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java
        Hide
        stack added a comment -

        Marking closed.

        Show
        stack added a comment - Marking closed.

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development