HBase
  1. HBase
  2. HBASE-5747

Forward port "hbase-5708 [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test"

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.95.0
    • Component/s: None
    • Labels:
      None

      Description

      Forward port as much as we can of Mikhail's hard-won test cleanups over on 0.89 branch Will improve our being able to run unit tests in //. He also found a few bugs.

      1. 5474.txt
        35 kB
        stack
      2. 5474v2.txt
        40 kB
        stack
      3. 5474v3.txt
        46 kB
        stack
      4. 5474v3 (1).txt
        46 kB
        stack
      5. 5708v4.txt
        43 kB
        stack
      6. 5708v4.txt
        43 kB
        stack

        Issue Links

          Activity

          Hide
          stack added a comment -

          Here is a first cut at forward port. I need to go over it a few times. We had a bunch of this stuff already done because of nkeywal work. Need to make sure I don't squash his work this.

          Show
          stack added a comment - Here is a first cut at forward port. I need to go over it a few times. We had a bunch of this stuff already done because of nkeywal work. Need to make sure I don't squash his work this.
          Hide
          stack added a comment -

          Trying hadoopqa for kicks.

          Show
          stack added a comment - Trying hadoopqa for kicks.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522178/5474.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 55 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522178/5474.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 55 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1471//console This message is automatically generated.
          Hide
          stack added a comment -

          Fix for failure. Should be good to go. Forward port of Mikhails fixups for tests.

          Show
          stack added a comment - Fix for failure. Should be good to go. Forward port of Mikhails fixups for tests.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522211/5474v2.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 58 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestClassLoading
          org.apache.hadoop.hbase.regionserver.wal.TestHLog
          org.apache.hadoop.hbase.TestHBaseTestingUtility
          org.apache.hadoop.hbase.TestFullLogReconstruction

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522211/5474v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 58 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestClassLoading org.apache.hadoop.hbase.regionserver.wal.TestHLog org.apache.hadoop.hbase.TestHBaseTestingUtility org.apache.hadoop.hbase.TestFullLogReconstruction Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1473//console This message is automatically generated.
          Hide
          stack added a comment -

          A few of the faillures were legit. This patch includes fixes.

          Show
          stack added a comment - A few of the faillures were legit. This patch includes fixes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522340/5474v3.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 61 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522340/5474v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 61 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1488//console This message is automatically generated.
          Hide
          stack added a comment -

          Retry

          Show
          stack added a comment - Retry
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522357/5474v3+%281%29.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 61 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522357/5474v3+%281%29.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 61 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1490//console This message is automatically generated.
          Hide
          stack added a comment -

          Not sure why tests are not completing. Running on a mac I see problem in this test:

          Running org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager
          Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.415 sec <<< FAILURE!
          
          Results :
          
          Failed tests:   testLeaderSelection(org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager): New leader should exist
          
          Show
          stack added a comment - Not sure why tests are not completing. Running on a mac I see problem in this test: Running org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.415 sec <<< FAILURE! Results : Failed tests: testLeaderSelection(org.apache.hadoop.hbase.zookeeper.TestZKLeaderManager): New leader should exist
          Hide
          stack added a comment -

          Fix the failing zk test.

          Show
          stack added a comment - Fix the failing zk test.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522532/5708v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 64 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.replication.TestReplication
          org.apache.hadoop.hbase.mapreduce.TestWALPlayer
          org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
          org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit
          org.apache.hadoop.hbase.replication.TestMasterReplication
          org.apache.hadoop.hbase.regionserver.wal.TestHLog

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522532/5708v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 64 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapreduce.TestWALPlayer org.apache.hadoop.hbase.replication.TestMultiSlaveReplication org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit org.apache.hadoop.hbase.replication.TestMasterReplication org.apache.hadoop.hbase.regionserver.wal.TestHLog Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1509//console This message is automatically generated.
          Hide
          stack added a comment -

          Retry after revert of wal compression patch

          Show
          stack added a comment - Retry after revert of wal compression patch
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522578/5708v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 64 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.replication.TestReplication
          org.apache.hadoop.hbase.mapreduce.TestWALPlayer

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522578/5708v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 64 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplication org.apache.hadoop.hbase.mapreduce.TestWALPlayer Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1512//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12522578/5708v4.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 64 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.mapreduce.TestWALPlayer
          org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12522578/5708v4.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 64 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestWALPlayer org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1518//console This message is automatically generated.
          Hide
          stack added a comment -

          TestWALPlayer is not because of this test and TestServerCustomProtocol passes locally. Going to commit this v4.

          Show
          stack added a comment - TestWALPlayer is not because of this test and TestServerCustomProtocol passes locally. Going to commit this v4.
          Hide
          stack added a comment -

          Committed to TRUNK (Thanks for the fixups Mikhail)

          Show
          stack added a comment - Committed to TRUNK (Thanks for the fixups Mikhail)
          Hide
          Mikhail Bautin added a comment -

          @Stack: thanks a lot for taking care of this forward-port! (I know we should normally port our 89-fb changes to trunk ourselves.)

          Show
          Mikhail Bautin added a comment - @Stack: thanks a lot for taking care of this forward-port! (I know we should normally port our 89-fb changes to trunk ourselves.)
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2757 (See https://builds.apache.org/job/HBase-TRUNK/2757/)
          HBASE-5747 Forward port "hbase-5708 [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test" (Revision 1326000)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestFullLogReconstruction.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestFixedFileTrailer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
          • /hbase/trunk/src/test/resources/hbase-site.xml
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2757 (See https://builds.apache.org/job/HBase-TRUNK/2757/ ) HBASE-5747 Forward port "hbase-5708 [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test" (Revision 1326000) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestFullLogReconstruction.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestFixedFileTrailer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java /hbase/trunk/src/test/resources/hbase-site.xml
          Hide
          stack added a comment -

          @Mikhail I think it fair in cases like this where a bunch of the code base is touched that us frontier folk more familiar w/ trunk pitch in. We probably know more whats portable and what to drop.

          Show
          stack added a comment - @Mikhail I think it fair in cases like this where a bunch of the code base is touched that us frontier folk more familiar w/ trunk pitch in. We probably know more whats portable and what to drop.
          Hide
          Ted Yu added a comment -

          Trunk builds #2757 to #2760 all failed due to some hanging test.

          Show
          Ted Yu added a comment - Trunk builds #2757 to #2760 all failed due to some hanging test.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #171 (See https://builds.apache.org/job/HBase-TRUNK-security/171/)
          HBASE-5747 Forward port "hbase-5708 [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test" (Revision 1326000)

          Result = FAILURE
          stack :
          Files :

          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestFullLogReconstruction.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestFixedFileTrailer.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java
          • /hbase/trunk/src/test/resources/hbase-site.xml
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #171 (See https://builds.apache.org/job/HBase-TRUNK-security/171/ ) HBASE-5747 Forward port "hbase-5708 [89-fb] Make MiniMapRedCluster directory a subdirectory of target/test" (Revision 1326000) Result = FAILURE stack : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestFullLogReconstruction.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestFixedFileTrailer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileDataBlockEncoder.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileSeek.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMiniClusterLoadSequential.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZKLeaderManager.java /hbase/trunk/src/test/resources/hbase-site.xml
          Hide
          Jonathan Hsieh added a comment -

          Just did a git bisect and this patch seems to make TestHBaseFsck hang. Investigating.

          Show
          Jonathan Hsieh added a comment - Just did a git bisect and this patch seems to make TestHBaseFsck hang. Investigating.
          Hide
          Jonathan Hsieh added a comment -

          filed follow on issue HBASE-5793.

          Show
          Jonathan Hsieh added a comment - filed follow on issue HBASE-5793 .
          Hide
          Jonathan Hsieh added a comment -

          I've verified that the failure is due to hbase-site.xml's change. The test expects a scan timeout (previously 10 retries) but likely fails out due to mvn timeout with 100 retries.

          diff --git a/src/test/resources/hbase-site.xml b/src/test/resources/hbase-site.xml
          index 84b5612..e7b7112 100644
          --- a/src/test/resources/hbase-site.xml
          +++ b/src/test/resources/hbase-site.xml
          @@ -142,4 +142,11 @@
               version is X.X.X-SNAPSHOT"
               </description>
             </property>
          +   <property>
          +     <name>hbase.client.retries.number</name>
          +     <value>100</value>
          +     <description>
          +     Use a lot of retries in unit tests.
          +     </description>
          +   </property>
           </configuration>
          

          Is this really necessary?

          Regardless of the outcome here, I'm going to modify the test in HBASE-5793 so that it checks the same thing but doesn't rely on retries.

          Show
          Jonathan Hsieh added a comment - I've verified that the failure is due to hbase-site.xml's change. The test expects a scan timeout (previously 10 retries) but likely fails out due to mvn timeout with 100 retries. diff --git a/src/test/resources/hbase-site.xml b/src/test/resources/hbase-site.xml index 84b5612..e7b7112 100644 --- a/src/test/resources/hbase-site.xml +++ b/src/test/resources/hbase-site.xml @@ -142,4 +142,11 @@ version is X.X.X-SNAPSHOT" </description> </property> + <property> + <name>hbase.client.retries.number</name> + <value>100</value> + <description> + Use a lot of retries in unit tests. + </description> + </property> </configuration> Is this really necessary? Regardless of the outcome here, I'm going to modify the test in HBASE-5793 so that it checks the same thing but doesn't rely on retries.
          Hide
          Ted Yu added a comment -

          In build 2757, TestSchemaMetrics hung:

          Running org.apache.hadoop.hbase.regionserver.metrics.TestSchemaMetrics
          Running org.apache.hadoop.hbase.regionserver.TestParallelPut
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.674 sec
          Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.674 sec
          
          Show
          Ted Yu added a comment - In build 2757, TestSchemaMetrics hung: Running org.apache.hadoop.hbase.regionserver.metrics.TestSchemaMetrics Running org.apache.hadoop.hbase.regionserver.TestParallelPut Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.674 sec Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.674 sec
          Hide
          stack added a comment -

          @Jon I can put it back. I pulled in that from original patch. Let me try setting it back. See if that helps w/ test hangs.

          I ran TestSchemaMetrics locally and it runs fine. It also does not seem to be responsible for the test 'timeouts' that are subsequent to 2757.

          Show
          stack added a comment - @Jon I can put it back. I pulled in that from original patch. Let me try setting it back. See if that helps w/ test hangs. I ran TestSchemaMetrics locally and it runs fine. It also does not seem to be responsible for the test 'timeouts' that are subsequent to 2757.
          Hide
          Jonathan Hsieh added a comment -

          @stack Does removing the retries cause more errors to show up does it remain the same?

          Show
          Jonathan Hsieh added a comment - @stack Does removing the retries cause more errors to show up does it remain the same?
          Hide
          Ted Yu added a comment -

          Trunk build passes twice.

          Show
          Ted Yu added a comment - Trunk build passes twice.
          Hide
          stack added a comment -

          But I didn't change anything! Does that mean Jon fixed it w/ his hbck commit?

          @Jon Let me ask @Mikhail why he went to 100 retries...

          Show
          stack added a comment - But I didn't change anything! Does that mean Jon fixed it w/ his hbck commit? @Jon Let me ask @Mikhail why he went to 100 retries...
          Hide
          Ted Yu added a comment -

          Recent Hadoop QA results, https://builds.apache.org/job/PreCommit-HBASE-Build/1538/console as an example, show the following:

               -1 core tests.  The patch failed these unit tests:
          

          I tried to use my script to find the hanging test but wasn't able to.

          Show
          Ted Yu added a comment - Recent Hadoop QA results, https://builds.apache.org/job/PreCommit-HBASE-Build/1538/console as an example, show the following: -1 core tests. The patch failed these unit tests: I tried to use my script to find the hanging test but wasn't able to.
          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.

            People

            • Assignee:
              stack
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development