Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.95.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hadoop has upgraded to this new version of Guava. We should, too, so we don't have compatibility issues running on Hadoop 2.0+

      1. hbase-5739.txt
        3 kB
        Todd Lipcon

        Issue Links

          Activity

          Todd Lipcon created issue -
          Hide
          Todd Lipcon added a comment -

          Attached patch updates the version, and changes the construction of the map in the slab cache, since the old MapMaker has been removed from guava >11

          Show
          Todd Lipcon added a comment - Attached patch updates the version, and changes the construction of the map in the slab cache, since the old MapMaker has been removed from guava >11
          Todd Lipcon made changes -
          Field Original Value New Value
          Attachment hbase-5739.txt [ 12521652 ]
          Hide
          stack added a comment -

          +1 on patch.

          Show
          stack added a comment - +1 on patch.
          Ted Yu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12521652/hbase-5739.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521652/hbase-5739.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1429//console This message is automatically generated.
          Hide
          stack added a comment -

          Committed to trunk. Thanks for patch Todd

          Show
          stack added a comment - Committed to trunk. Thanks for patch Todd
          stack made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2739 (See https://builds.apache.org/job/HBase-TRUNK/2739/)
          HBASE-5739 Upgrade guava to 11.0.2 (Revision 1311942)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/pom.xml
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2739 (See https://builds.apache.org/job/HBase-TRUNK/2739/ ) HBASE-5739 Upgrade guava to 11.0.2 (Revision 1311942) Result = SUCCESS stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/)
          HBASE-5739 Upgrade guava to 11.0.2 (Revision 1311942)

          Result = SUCCESS
          stack :
          Files :

          • /hbase/trunk/pom.xml
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK-security #167 (See https://builds.apache.org/job/HBase-TRUNK-security/167/ ) HBASE-5739 Upgrade guava to 11.0.2 (Revision 1311942) Result = SUCCESS stack : Files : /hbase/trunk/pom.xml /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java
          Andrew Purtell made changes -
          Link This issue relates to HBASE-5955 [ HBASE-5955 ]
          Hide
          Lars Hofhansl added a comment -

          When was guava introduced to Hadoop? I don't find a reference to it in Hadoop-1.0.x.

          Show
          Lars Hofhansl added a comment - When was guava introduced to Hadoop? I don't find a reference to it in Hadoop-1.0.x.
          Hide
          Todd Lipcon added a comment -

          I think we introduced it in HDFS-918 maybe?

          Show
          Todd Lipcon added a comment - I think we introduced it in HDFS-918 maybe?
          Hide
          Todd Lipcon added a comment -

          Err... sorry, HDFS-941. Mixing up my DN performane JIRAs here

          Show
          Todd Lipcon added a comment - Err... sorry, HDFS-941 . Mixing up my DN performane JIRAs here
          stack made changes -
          Fix Version/s 0.95.0 [ 12324094 ]
          Fix Version/s 0.96.0 [ 12320040 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          stack made changes -
          Fix Version/s 0.98.0 [ 12323143 ]
          Hide
          stack added a comment -

          Marking closed.

          Show
          stack added a comment - Marking closed.
          stack made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          9h 53m 1 Ted Yu 06/Apr/12 16:47
          Patch Available Patch Available Resolved Resolved
          4d 3h 36m 1 stack 10/Apr/12 20:23
          Resolved Resolved Closed Closed
          530d 23h 6m 1 stack 23/Sep/13 19:30

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development